From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70A144559E; Sat, 6 Jul 2024 06:59:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B73C410E7; Sat, 6 Jul 2024 06:59:32 +0200 (CEST) Received: from smtp-fw-52003.amazon.com (smtp-fw-52003.amazon.com [52.119.213.152]) by mails.dpdk.org (Postfix) with ESMTP id 8B33540268 for ; Sat, 6 Jul 2024 06:59:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1720241972; x=1751777972; h=from:to:cc:date:message-id:references:in-reply-to: mime-version:subject; bh=H1Mj6g7Zd0LuVV4ujI7uR/6TdQGggdbfvYfWnlSR454=; b=NsiLxyaN2xueHZO4FazR0B+5d9gdtiSQ7bnslEbWDL8M0tCvyLKN56Pr bL4UtInmUjUp0tr7q9sjRksA5MBcpzLYB8ETNb0KtJpUcZe1ZyhBBDOf6 HVZRlSchu6YGd16VCcoOO25DmXad3XT4JZAnXSWdLC0aXQppmu4t9z5bi Y=; X-IronPort-AV: E=Sophos;i="6.09,187,1716249600"; d="scan'208,217";a="9823827" Subject: RE: [PATCH 1/1] net/ena: restructure the llq policy user setting Thread-Topic: [PATCH 1/1] net/ena: restructure the llq policy user setting Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-52003.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2024 04:59:30 +0000 Received: from EX19MTAEUB002.ant.amazon.com [10.0.10.100:22617] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.20.169:2525] with esmtp (Farcaster) id 83f494a0-0c14-43e7-bd49-ca4253e6dc2d; Sat, 6 Jul 2024 04:59:28 +0000 (UTC) X-Farcaster-Flow-ID: 83f494a0-0c14-43e7-bd49-ca4253e6dc2d Received: from EX19D007EUA004.ant.amazon.com (10.252.50.76) by EX19MTAEUB002.ant.amazon.com (10.252.51.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Sat, 6 Jul 2024 04:59:28 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D007EUA004.ant.amazon.com (10.252.50.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Sat, 6 Jul 2024 04:59:27 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.034; Sat, 6 Jul 2024 04:59:27 +0000 From: "Brandes, Shai" To: Ferruh Yigit CC: "dev@dpdk.org" Thread-Index: AQHauBYQ/uO8tA/Rsk+Vc5+GTyayrLHoknAAgAC/8vg= Date: Sat, 6 Jul 2024 04:59:27 +0000 Message-ID: <4b40c990-edf4-4f0e-a796-2e6444feae14@email.android.com> References: <20240606133300.500-1-shaibran@amazon.com> <20240606133300.500-2-shaibran@amazon.com>, <34477f84-4462-4846-8ccb-ee035cb77f68@amd.com> In-Reply-To: <34477f84-4462-4846-8ccb-ee035cb77f68@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_4b40c990edf44f0ea7962e6444feae14emailandroidcom_" MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_4b40c990edf44f0ea7962e6444feae14emailandroidcom_ Content-Type: text/plain; charset="windows-1255" Content-Transfer-Encoding: quoted-printable Sure, thanks! =E1=FA=E0=F8=E9=EA 5 =E1=E9=E5=EC=E9 2024 20:32,=FE Ferruh Yigit =EB=FA=E1: CAUTION: This email originated from outside of the organization. Do not cli= ck links or open attachments unless you can confirm the sender and know the= content is safe. On 6/6/2024 2:33 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr` > devargs with a new shared devarg named `llq_policy` that > implements the same logic and accepts the following values: > 0 - Disable LLQ. > Use with extreme caution as it leads to a huge performance > degradation on AWS instances from 6th generation onwards. > 1 - Accept device recommended LLQ policy (Default). > Device can recommend normal or large LLQ policy. > 2 - Enforce normal LLQ policy. > 3 - Enforce large LLQ policy. > Required for packets with header that exceed 96 bytes on > AWS instances prior to 5th generation. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > Hi Shai, This patch changes device parameters and impacts end user. Although this is not part of ABI policy, and we don't have an explicit policy around it, but since it may impact end user experience, would you be OK to postpone this patch to v24.11 release, where ABI break is planned? --_000_4b40c990edf44f0ea7962e6444feae14emailandroidcom_ Content-Type: text/html; charset="windows-1255" Content-Transfer-Encoding: quoted-printable
Sure, thanks!

=E1=FA=E0=F8=E9=EA 5 =E1=E9=E5=EC=E9 2024 20:3= 2,=FE Ferruh Yigit <ferruh.yigit@amd.com> =EB=FA=E1:
CAUTION: This email originated from outside of the= organization. Do not click links or open attachments unless you can confir= m the sender and know the content is safe.



On 6/6/2024 2:33 PM, shaibran@amazon.com wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr`
> devargs with a new shared devarg named `llq_policy` that
> implements the same logic and accepts the following values:
> 0 - Disable LLQ.
>     Use with extreme caution as it leads to a huge= performance
>     degradation on AWS instances from 6th generati= on onwards.
> 1 - Accept device recommended LLQ policy (Default).
>     Device can recommend normal or large LLQ polic= y.
> 2 - Enforce normal LLQ policy.
> 3 - Enforce large LLQ policy.
>     Required for packets with header that exceed 9= 6 bytes on
>     AWS instances prior to 5th generation.
>
> Signed-off-by: Shai Brandes <shaibran@amazon.com>
> Reviewed-by: Amit Bernstein <amitbern@amazon.com>
>

Hi Shai,

This patch changes device parameters and impacts end user.
Although this is not part of ABI policy, and we don't have an explicit
policy around it, but since it may impact end user experience, would you be OK to postpone this patch to v24.11 release, where ABI break is planned?=



--_000_4b40c990edf44f0ea7962e6444feae14emailandroidcom_--