From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6C25EA04B7;
	Tue, 13 Oct 2020 15:10:54 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2345A1DA83;
	Tue, 13 Oct 2020 15:10:51 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 896B51D736
 for <dev@dpdk.org>; Tue, 13 Oct 2020 15:10:48 +0200 (CEST)
IronPort-SDR: bwlCWlx1ujl/iWNAVOc7a4Z+Yj7xiNAfu8iU8LqYhHG0sYxxSc7w+AEAtD/tajv9m6quaSTMG9
 8oIQove733Pg==
X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="165116434"
X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="165116434"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Oct 2020 06:10:46 -0700
IronPort-SDR: ZwUKHb9iisilzPADTiB9jipoapq6Q1D9MZIE79MdEF0psBsUsvRboKRFe6xa3B4hCbPPe3m36v
 P7jrWfkRixjA==
X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="530389290"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64])
 ([10.213.214.64])
 by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Oct 2020 06:10:34 -0700
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: arybchenko@solarflare.com, Stephen Hemminger
 <stephen@networkplumber.org>, Haiyue Wang <haiyue.wang@intel.com>,
 Jeff Guo <jia.guo@intel.com>, Shepard Siegel
 <shepard.siegel@atomicrules.com>, Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>,
 Igor Russkikh <igor.russkikh@aquantia.com>,
 Pavel Belous <pavel.belous@aquantia.com>,
 Somalapuram Amaranath <asomalap@amd.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>,
 "Min Hu (Connor)" <humin29@huawei.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>, Marcin Wojtas <mw@semihalf.com>,
 Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,
 Ziyang Xuan <xuanziyang2@huawei.com>,
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>,
 "Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Beilei Xing <beilei.xing@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>,
 Alfredo Cardigliano <cardigliano@ntop.org>,
 Shijith Thotton <sthotton@marvell.com>,
 Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 "K. Y. Srinivasan" <kys@microsoft.com>,
 Haiyang Zhang <haiyangz@microsoft.com>, Long Li <longli@microsoft.com>,
 Harman Kalra <hkalra@marvell.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Keith Wiles <keith.wiles@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,
 Yong Wang <yongwang@vmware.com>
References: <20200913220711.3768597-1-thomas@monjalon.net>
 <20201013100634.2482593-1-thomas@monjalon.net>
 <20201013100634.2482593-3-thomas@monjalon.net>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <4b439205-55e2-5ba4-903a-90056887e980@intel.com>
Date: Tue, 13 Oct 2020 14:10:28 +0100
MIME-Version: 1.0
In-Reply-To: <20201013100634.2482593-3-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 2/3] ethdev: reset all when releasing a
	port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/13/2020 11:06 AM, Thomas Monjalon wrote:
> The function rte_eth_dev_release_port() is partially resetting
> the struct rte_eth_dev. The drivers were completing this reset
> with more pointers set to NULL in the close or remove operations.
> 
> More pointers are reset at ethdev level,
> and some redundant assignments are removed from PMDs.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Haiyue Wang <haiyue.wang@intel.com>
> Acked-by: Jeff Guo <jia.guo@intel.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>