DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>,
	<andrew.rybchenko@oktetlabs.ru>
Subject: Re: [RFC] ethdev: introduce ethdev dump API
Date: Wed, 12 Jan 2022 10:41:03 +0800	[thread overview]
Message-ID: <4b666dfb-aa0c-a166-c171-7399c82d6fba@huawei.com> (raw)
In-Reply-To: <3408456.iIbC2pHGDl@thomas>

Hi, Thomas,
	fixed in v2, thanks.

在 2022/1/11 20:48, Thomas Monjalon 写道:
> Please use --cc-cmd devtools/get-maintainer.sh so all maintainers are Cc'ed.
> 
> 11/01/2022 12:54, Min Hu (Connor):
>> --- a/doc/guides/rel_notes/release_22_03.rst
>> +++ b/doc/guides/rel_notes/release_22_03.rst
>> @@ -55,6 +55,12 @@ New Features
>>        Also, make sure to start the actual text at the margin.
>>        =======================================================
>>   
>> +   * **Added the ethdev dump API, for query private info of ethdev.**
>> +
>> +     Added the ethdev dump API which provides functions for query private info
>> +     from device. There exists many private properties in different PMD
>> +     drivers. The information of these properties is important for debug. As
>> +     the information is private, the new API is introduced.
>>   
> 
> A blank line is missing.
> Also please check the comment above asking to start the actual text at the margin.
> 
> [...]
>> +typedef int (*eth_dev_dump_t)(struct rte_eth_dev *dev, FILE *file);
> 
> There is a dump function for rte_flow: rte_flow_dev_dump().
> This one should have a clear scope: private device infos?
> 
> 
> 
> .
> 

  reply	other threads:[~2022-01-12  2:41 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 11:54 Min Hu (Connor)
2022-01-11 12:10 ` Morten Brørup
2022-01-12  2:40   ` Min Hu (Connor)
2022-01-11 12:48 ` Thomas Monjalon
2022-01-12  2:41   ` Min Hu (Connor) [this message]
2022-01-12  2:44   ` Min Hu (Connor)
2022-01-12 10:13     ` Thomas Monjalon
2022-01-12 10:56       ` Min Hu (Connor)
2022-01-12  2:40 ` [RFC v2] " Min Hu (Connor)
2022-01-12  7:20   ` Morten Brørup
2022-01-12 11:15     ` Min Hu (Connor)
2022-01-14 17:56       ` Ajit Khaparde
2022-01-15  0:24         ` Min Hu (Connor)
2022-01-18 15:33           ` Ajit Khaparde
2022-01-12 11:14 ` [RFC v3] " Min Hu (Connor)
2022-01-12 12:05   ` Ray Kinsella
2022-01-18 15:34     ` Ajit Khaparde
2022-01-25 12:56       ` Ferruh Yigit
2022-01-25 12:58         ` Ferruh Yigit
2022-01-25 13:45           ` Min Hu (Connor)
2022-02-03 13:21             ` Ferruh Yigit
2022-02-07  1:37               ` Min Hu (Connor)
2022-02-07  1:35 ` Min Hu (Connor)
2022-02-07  1:47 ` [PATCH] " Min Hu (Connor)
2022-02-07 11:46   ` Ferruh Yigit
2022-02-07 12:18     ` Morten Brørup
2022-02-07 12:35       ` Ferruh Yigit
2022-02-07 12:56         ` Morten Brørup
2022-02-07 15:35           ` Ferruh Yigit
2022-02-08  0:39             ` Min Hu (Connor)
2022-02-08 10:21               ` Ferruh Yigit
2022-02-08 11:14                 ` Min Hu (Connor)
2022-02-08 12:59                   ` Ferruh Yigit
2022-02-08 13:52                     ` Thomas Monjalon
2022-02-09  1:07                       ` Min Hu (Connor)
2022-02-09  1:06                     ` Min Hu (Connor)
2022-02-08  2:46     ` Min Hu (Connor)
2022-02-08  2:45 ` [PATCH v2] ethdev: introduce " Min Hu (Connor)
2022-02-09  1:21 ` [PATCH v3] " Min Hu (Connor)
2022-02-10 12:32   ` Ferruh Yigit
2022-02-10 12:34     ` Ferruh Yigit
2022-02-11  4:53       ` Min Hu (Connor)
2022-02-10 12:37   ` Ferruh Yigit
2022-02-10 13:16     ` Min Hu (Connor)
2022-02-10 13:22       ` Ferruh Yigit
2022-02-10 15:50         ` Ferruh Yigit
2022-02-11  4:52           ` Min Hu (Connor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b666dfb-aa0c-a166-c171-7399c82d6fba@huawei.com \
    --to=humin29@huawei.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).