From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DDE6A0561; Thu, 18 Mar 2021 01:58:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2094540698; Thu, 18 Mar 2021 01:58:55 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 9244B40683 for ; Thu, 18 Mar 2021 01:58:53 +0100 (CET) IronPort-SDR: lRoLqxKKjA/YbM9i8bnttkDWEwjjp2uWJJOcY+vpzT4wTbpIjYzItjWxF2YM4O6Dbze9OSsXln 5m5wgH2DQOQg== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="176705658" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="176705658" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 17:58:52 -0700 IronPort-SDR: ltzKOfK2reoziSWoMj1elP9c8dM0PW6XSwadnpFmbB4UMjOr6uB3inTgE9zkuSboxN3kzcVmCp rGhAWPqD5+FQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="412867034" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 17 Mar 2021 17:58:52 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 17 Mar 2021 17:58:51 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 18 Mar 2021 08:58:49 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Thu, 18 Mar 2021 08:58:49 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon , Andrew Rybchenko , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Richardson, Bruce" , "Wang, Xiao W" , "Wu, Jingjing" , "Xing, Beilei" , "Guo, Jia" , "Yang, Qiming" , "Wang, Haiyue" Thread-Topic: [PATCH v3 2/9] net: replace build option Thread-Index: AQHXGx5kPRO6EVgJi0iKOo/Ep48ucaqIMeQAgAADuICAAK+TgA== Date: Thu, 18 Mar 2021 00:58:49 +0000 Message-ID: <4b85087c0e3f475e8d01eba64b769d2a@intel.com> References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210317111551.2215332-3-qi.z.zhang@intel.com> <6388516.0yhbR63jCu@thomas> In-Reply-To: <6388516.0yhbR63jCu@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, March 18, 2021 6:01 AM > To: Zhang, Qi Z ; Andrew Rybchenko > ; Yigit, Ferruh > Cc: dev@dpdk.org; Richardson, Bruce ; Wang, > Xiao W ; Wu, Jingjing ; Xin= g, > Beilei ; Guo, Jia ; Yang, Qimin= g > ; Wang, Haiyue > Subject: Re: [PATCH v3 2/9] net: replace build option >=20 > 17/03/2021 22:47, Ferruh Yigit: > > On 3/17/2021 11:15 AM, Qi Zhang wrote: > > > Replace RTE_LIBRTE_ETHDEV_DEBUG with RTE_ETHDEV_DEBUG. > > > > > > Signed-off-by: Qi Zhang > > > > Hi Qi, Thomas, > > > > I see Thomas mentioned 'LIBRTE_' is redundant but not sure about > > renaming the existing compile time flag without notice. > > > > The flag is to be used for users, it is not internal, and it may be > > already used in some scripts and automation etc, this rename can break > them. > > > > 'LIBRTE_' is already used commonly, I think all library flags has it, > > do we really need to drop it from this current one? Even if we drop > > it, what about keeping it as alias for backward compatibility? >=20 > Yes I did not ask for removing now :) > Let's keep old name as alias and start using the new name (if you agree w= ith > the new name without LIBRTE_). OK, adding an alias makes sense to me Thanks Qi >=20