From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 321E3A04BA; Mon, 5 Oct 2020 09:11:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A46E1B62E; Mon, 5 Oct 2020 09:11:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 321F62C58 for ; Mon, 5 Oct 2020 09:11:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601881871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=A3dXIDc98zE+EZilYdYJ2cftHJe74LCqOrgQLB8okXE=; b=YoTtOdmLbJhVl/0CesGHlDlb3UV8IVg9n8yahAMxv7Pz3FsumffyhdyRjOTP040S0JbO+t CrFFcOBQ5YGrXxLfyrLm4FxM7TCwABNTKSMv+x1hTPus6+bGK69tS45HID4wlvU7h5bU3I ptNZTqCe9152B35RD42RUleZotk76iw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-vKb8djHYPx27oN399VecVA-1; Mon, 05 Oct 2020 03:11:09 -0400 X-MC-Unique: vKb8djHYPx27oN399VecVA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91907425CC; Mon, 5 Oct 2020 07:11:08 +0000 (UTC) Received: from [10.36.110.35] (unknown [10.36.110.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A88C73674; Mon, 5 Oct 2020 07:11:07 +0000 (UTC) To: Tom Rix , dev@dpdk.org, akhil.goyal@nxp.com, nicolas.chautru@intel.com, ferruh.yigit@intel.com References: <20201002085931.265699-1-maxime.coquelin@redhat.com> <20201002085931.265699-2-maxime.coquelin@redhat.com> <8b19943c-7430-ab0d-9635-d465d91f1c82@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <4ba62928-0dd6-4d65-4882-d1eb6b21d4d4@redhat.com> Date: Mon, 5 Oct 2020 09:11:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8b19943c-7430-ab0d-9635-d465d91f1c82@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix API naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/3/20 5:26 PM, Tom Rix wrote: > > On 10/2/20 1:59 AM, Maxime Coquelin wrote: >> DPDK APIs have to be prefixed with "rte_" in order to avoid >> namespace pollution. >> >> Let's fix it while fpga_5gnr_fec API is still experimental. >> >> Signed-off-by: Maxime Coquelin >> --- >> app/test-bbdev/test_bbdev_perf.c | 6 +++--- >> doc/guides/bbdevs/fpga_5gnr_fec.rst | 14 +++++++------- >> drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 +++++----- >> .../rte_pmd_bbdev_fpga_5gnr_fec_version.map | 2 +- >> .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h | 6 +++--- >> 5 files changed, 19 insertions(+), 19 deletions(-) >> >> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c >> index 45c0d62aca..14f150704e 100644 >> --- a/app/test-bbdev/test_bbdev_perf.c >> +++ b/app/test-bbdev/test_bbdev_perf.c >> @@ -612,14 +612,14 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, >> #ifdef RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC >> if ((get_init_device() == true) && >> (!strcmp(info->drv.driver_name, FPGA_5GNR_PF_DRIVER_NAME))) { >> - struct fpga_5gnr_fec_conf conf; >> + struct rte_fpga_5gnr_fec_conf conf; >> unsigned int i; >> >> printf("Configure FPGA 5GNR FEC Driver %s with default values\n", >> info->drv.driver_name); >> >> /* clear default configuration before initialization */ >> - memset(&conf, 0, sizeof(struct fpga_5gnr_fec_conf)); >> + memset(&conf, 0, sizeof(struct rte_fpga_5gnr_fec_conf)); >> >> /* Set PF mode : >> * true if PF is used for data plane >> @@ -647,7 +647,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, >> conf.flr_time_out = FLR_5G_TIMEOUT; >> >> /* setup FPGA PF with configuration information */ >> - ret = fpga_5gnr_fec_configure(info->dev_name, &conf); >> + ret = rte_fpga_5gnr_fec_configure(info->dev_name, &conf); >> TEST_ASSERT_SUCCESS(ret, >> "Failed to configure 5G FPGA PF for bbdev %s", >> info->dev_name); >> diff --git a/doc/guides/bbdevs/fpga_5gnr_fec.rst b/doc/guides/bbdevs/fpga_5gnr_fec.rst >> index 6760391e8c..5849b31857 100644 >> --- a/doc/guides/bbdevs/fpga_5gnr_fec.rst >> +++ b/doc/guides/bbdevs/fpga_5gnr_fec.rst >> @@ -170,12 +170,12 @@ queues, priorities, load balance, bandwidth and other settings necessary for the >> device to perform FEC functions. >> >> This configuration needs to be executed at least once after reboot or PCI FLR and can >> -be achieved by using the function ``fpga_5gnr_fec_configure()``, which sets up the >> -parameters defined in ``fpga_5gnr_fec_conf`` structure: >> +be achieved by using the function ``rte_fpga_5gnr_fec_configure()``, which sets up the >> +parameters defined in ``rte_fpga_5gnr_fec_conf`` structure: >> >> .. code-block:: c >> >> - struct fpga_5gnr_fec_conf { >> + struct rte_fpga_5gnr_fec_conf { >> bool pf_mode_en; >> uint8_t vf_ul_queues_number[FPGA_5GNR_FEC_NUM_VFS]; >> uint8_t vf_dl_queues_number[FPGA_5GNR_FEC_NUM_VFS]; >> @@ -214,15 +214,15 @@ parameters defined in ``fpga_5gnr_fec_conf`` structure: >> the FLR time out then set this setting to 0x262=610. >> >> >> -An example configuration code calling the function ``fpga_5gnr_fec_configure()`` is shown >> +An example configuration code calling the function ``rte_fpga_5gnr_fec_configure()`` is shown >> below: >> >> .. code-block:: c >> >> - struct fpga_5gnr_fec_conf conf; >> + struct rte_fpga_5gnr_fec_conf conf; >> unsigned int i; >> >> - memset(&conf, 0, sizeof(struct fpga_5gnr_fec_conf)); >> + memset(&conf, 0, sizeof(struct rte_fpga_5gnr_fec_conf)); >> conf.pf_mode_en = 1; >> >> for (i = 0; i < FPGA_5GNR_FEC_NUM_VFS; ++i) { >> @@ -235,7 +235,7 @@ below: >> conf.ul_load_balance = 64; >> >> /* setup FPGA PF */ >> - ret = fpga_5gnr_fec_configure(info->dev_name, &conf); >> + ret = rte_fpga_5gnr_fec_configure(info->dev_name, &conf); >> TEST_ASSERT_SUCCESS(ret, >> "Failed to configure 4G FPGA PF for bbdev %s", > > 4G ? > > Consider a future patch to clean this up. > >> info->dev_name); >> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c >> index 61f9c04ba2..1d73f9540e 100644 >> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c >> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c >> @@ -1944,10 +1944,10 @@ fpga_5gnr_fec_remove(struct rte_pci_device *pci_dev) >> } >> >> static inline void >> -set_default_fpga_conf(struct fpga_5gnr_fec_conf *def_conf) >> +set_default_fpga_conf(struct rte_fpga_5gnr_fec_conf *def_conf) >> { >> /* clear default configuration before initialization */ >> - memset(def_conf, 0, sizeof(struct fpga_5gnr_fec_conf)); >> + memset(def_conf, 0, sizeof(struct rte_fpga_5gnr_fec_conf)); >> /* Set pf mode to true */ >> def_conf->pf_mode_en = true; >> >> @@ -1962,15 +1962,15 @@ set_default_fpga_conf(struct fpga_5gnr_fec_conf *def_conf) >> >> /* Initial configuration of FPGA 5GNR FEC device */ >> int >> -fpga_5gnr_fec_configure(const char *dev_name, >> - const struct fpga_5gnr_fec_conf *conf) >> +rte_fpga_5gnr_fec_configure(const char *dev_name, >> + const struct rte_fpga_5gnr_fec_conf *conf) >> { >> uint32_t payload_32, address; >> uint16_t payload_16; >> uint8_t payload_8; >> uint16_t q_id, vf_id, total_q_id, total_ul_q_id, total_dl_q_id; >> struct rte_bbdev *bbdev = rte_bbdev_get_named_dev(dev_name); >> - struct fpga_5gnr_fec_conf def_conf; >> + struct rte_fpga_5gnr_fec_conf def_conf; >> >> if (bbdev == NULL) { >> rte_bbdev_log(ERR, >> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map b/drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map >> index d723bc9b0e..db43cd8403 100644 >> --- a/drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map >> +++ b/drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map >> @@ -5,6 +5,6 @@ DPDK_21 { >> EXPERIMENTAL { >> global: >> >> - fpga_5gnr_fec_configure; >> + rte_fpga_5gnr_fec_configure; >> >> }; >> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h b/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h >> index 70a4acf0b7..c2752fbd52 100644 >> --- a/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h >> +++ b/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h >> @@ -30,7 +30,7 @@ extern "C" { >> /** >> * Structure to pass FPGA 4G FEC configuration. > > 4G ? > > There are a number of 4G references in this file's comments. > > Consider a future patch to clean this up. Agree, I noticed that. It has to be fixed in another series. >> */ >> -struct fpga_5gnr_fec_conf { >> +struct rte_fpga_5gnr_fec_conf { >> /** 1 if PF is used for dataplane, 0 for VFs */ >> bool pf_mode_en; >> /** Number of UL queues per VF */ >> @@ -64,8 +64,8 @@ struct fpga_5gnr_fec_conf { >> */ >> __rte_experimental >> int >> -fpga_5gnr_fec_configure(const char *dev_name, >> - const struct fpga_5gnr_fec_conf *conf); >> +rte_fpga_5gnr_fec_configure(const char *dev_name, >> + const struct rte_fpga_5gnr_fec_conf *conf); >> >> #ifdef __cplusplus >> } > > Changes look complete. > > Reviewed-by: Tom Rix > Thanks, Maxime