From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49935A04BC; Fri, 9 Oct 2020 14:51:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 278E21D637; Fri, 9 Oct 2020 14:51:39 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id F1D2B1D635 for ; Fri, 9 Oct 2020 14:51:36 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id q5so9744925wmq.0 for ; Fri, 09 Oct 2020 05:51:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=uQ86Qt1IEpl8BDyfz0/nACs4COXsxqHHaZsZ/sOs4Qc=; b=GT98O/lj1E980+wuW6BkwDxvhZRYY2AoquyJHuH+k4CtdZTJXl1nO5YXn89cRmnuec DD/H2y9B+ZJ0GHt9pBMv71E77nt7F0r3kmh4rcEbuTZXpag14rLDm6tWxDC4ZbIjtQ1H Nc4D7qcEEXg6SxW9M3qv4kF1fJDr4EM6RkEZ+eleZD3oomtOpcUuR3TGmhlBU425H5Lx LJoUBgfvbiAOYb23FHrMvcW4nMY/DTR8ZDpgnJRuQPXPBjsjGCbva1r8EAAdEE3p20OE xda+3HzD8pPiwYyk+DkUtcwzMpkbTArGilD4ruSiuC7V/PldEmt5kn3HA66UO/OKV/I6 c8Ww== X-Gm-Message-State: AOAM533tY2ZxvpMCTBpXS3gt4WMulcIguKrr9KFEMJLkeMRKODrbmzH/ tMH1d9B+1jGewZ11D3Y2Cw5EbDBDxKFzKw== X-Google-Smtp-Source: ABdhPJxxf8FAhDLfsDsYOlrgT1+rrfMou9gN3h6RQA4oWzAj0kOPkJAiGoTJHjjm64XpxeQ+1uw3hw== X-Received: by 2002:a7b:c317:: with SMTP id k23mr13506637wmj.44.1602247896637; Fri, 09 Oct 2020 05:51:36 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y4sm11085543wrp.74.2020.10.09.05.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 05:51:35 -0700 (PDT) Message-ID: <4ba7d93db044cb820b89f20ef7cea8abe7a75404.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Fri, 09 Oct 2020 13:51:35 +0100 In-Reply-To: <20201009103202.GA1474@bricha3-MOBL.ger.corp.intel.com> References: <20201008170536.124111-1-bruce.richardson@intel.com> <20201008170805.GF1106@bricha3-MOBL.ger.corp.intel.com> <4e40d3fa1af950ab760995828c46125211f5960b.camel@debian.org> <20201009103202.GA1474@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH] build: use libpcap only from pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 2020-10-09 at 11:32 +0100, Bruce Richardson wrote: > On Fri, Oct 09, 2020 at 10:09:11AM +0100, Luca Boccassi wrote: > > On Thu, 2020-10-08 at 18:08 +0100, Bruce Richardson wrote: > > > On Thu, Oct 08, 2020 at 06:05:36PM +0100, Bruce Richardson wrote: > > > > All recent linux distro's - including RHEL 8 and Ubuntu 18.04 - pro= vide a > > > > pkg-config file for libpcap, and using other methods of finding the= library > > > > can cause issues when cross-compiling, so we can limit build suppor= t for > > > > pcap versions without a .pc file. > > > >=20 > > > > Signed-off-by: Bruce Richardson > > > > --- > > > > config/meson.build | 8 +------- > > > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > >=20 > > > > diff --git a/config/meson.build b/config/meson.build > > > > index 69f2aeb60..edc6c195a 100644 > > > > --- a/config/meson.build > > > > +++ b/config/meson.build > > > > @@ -163,13 +163,7 @@ if libbsd.found() > > > > endif > > > > =20 > > > > # check for pcap > > > > -pcap_dep =3D dependency('pcap', required: false) > > > > -if pcap_dep.found() > > > > - # pcap got a pkg-config file only in 1.9.0 and before that meson = uses > > > > - # an internal pcap-config finder, which is not compatible with > > > > - # cross-compilation, so try to fallback to find_library > > > > - pcap_dep =3D cc.find_library('pcap', required: false) > > > > -endif > > > > +pcap_dep =3D dependency('libpcap', required: false, method: 'pkg-c= onfig') > > > > if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap= _dep) > > > > dpdk_conf.set('RTE_PORT_PCAP', 1) > > > > dpdk_extra_ldflags +=3D '-lpcap' > > >=20 > > > Just sending this as an RFC for consideration, since I hit problems w= ith > > > the pcap code when testing 32-bit (x32) builds, and remembered having= hit > > > it previously too. > > >=20 > > > Does anyone see an issue with limiting our pcap detection to pkg-conf= ig > > > only in this case? > > >=20 > > > /Bruce > >=20 > > Sadly it's not yet available in Debian stable: > >=20 > > https://packages.debian.org/buster/amd64/libpcap0.8-dev/filelist > >=20 > > Also for Ubuntu 18.04, it's only available with the bionic-updates > > repository, and only for the past month - it shipped without it. > >=20 > > I'm absolutely keen on using only pkg-config (so much that I did the > > packaging changes myself to ship it in libpcap-dev [1][2]) but perhaps > > in the interest of compatibility it's better to wait next year, so that > > the new Debian stable supports it, and the Ubuntu 18.04 LTS fix had the > > chance to rollout everywhere? > >=20 >=20 > Thanks, that's exactly the sort of feedback I was looking for! >=20 > It seems to be the pcap-config support in meson which causes cross-buildi= ng > issues, so I wonder would it still work ok if we changed this to only use > pkg-config for the initial search and then use find-library if that faile= d? >=20 > # check for pcap > -pcap_dep =3D dependency('pcap', required: false) > -if pcap_dep.found() > - # pcap got a pkg-config file only in 1.9.0 and before that meson = uses > - # an internal pcap-config finder, which is not compatible with > - # cross-compilation, so try to fallback to find_library > +pcap_dep =3D dependency('libpcap', required: false, method: 'pkg-config'= ) > +if not pcap_dep.found() > + # pcap got a pkg-config file only in 1.9.0 > pcap_dep =3D cc.find_library('pcap', required: false) > endif That would be fine - is the 'method' option supported in the minimum version we support right now? --=20 Kind regards, Luca Boccassi