DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jeff Guo <jia.guo@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
	anatoly.burakov@intel.com, thomas@monjalon.net,
	bernard.iremonger@intel.com, dev@dpdk.org, helin.zhang@intel.com,
	gaetan.rivet@6wind.com, qi.z.zhang@intel.com,
	arybchenko@solarflare.com, bruce.richardson@intel.com,
	matan@mellanox.com, shaopeng.he@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] but/pci: fix fd close for hot-unplug
Date: Thu, 8 Nov 2018 11:10:29 +0800	[thread overview]
Message-ID: <4bcbd2be-240e-9f60-86f8-f0d9ca7e1293@intel.com> (raw)
In-Reply-To: <20181107113344.79229734@shemminger-XPS-13-9360>

hi, stephen

On 11/8/2018 3:33 AM, Stephen Hemminger wrote:
> On Wed,  7 Nov 2018 17:41:31 +0800
> Jeff Guo <jia.guo@intel.com> wrote:
>
>> When device is hot-unplugged, the device fd will be deleted in kernel.
>> Then in the progress of detaching device, if it try to close the fd,
>> it will cause a kernel crash, which shown a kernel null pointer error.
> If this happens, then it is a kernel bug and the kernel should be fixed.
> Working around it in userspace is not a great long term solution.


agree with you. The key is sometime hold by kernel. But i think it is at 
least reasonable for avoiding no-use process in user space, whatever 
kernel's behavior. I am not sure if there is any better idea we can 
find, but seems it is an option now.

  reply	other threads:[~2018-11-08  3:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07  9:41 [dpdk-dev] [PATCH 0/2] expose device states " Jeff Guo
2018-11-07  9:41 ` [dpdk-dev] [PATCH 1/2] eal: expose device states in rte device Jeff Guo
2018-11-07 19:32   ` Stephen Hemminger
2018-11-09  7:35     ` Jeff Guo
2018-11-07  9:41 ` [dpdk-dev] [PATCH 2/2] but/pci: fix fd close for hot-unplug Jeff Guo
2018-11-07 19:33   ` Stephen Hemminger
2018-11-08  3:10     ` Jeff Guo [this message]
2018-11-08 21:55       ` Stephen Hemminger
2018-11-09  3:26         ` Jeff Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bcbd2be-240e-9f60-86f8-f0d9ca7e1293@intel.com \
    --to=jia.guo@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=matan@mellanox.com \
    --cc=qi.z.zhang@intel.com \
    --cc=shaopeng.he@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).