[dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

[dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

[David Marchand]

This API saw no update since its introduction and will help applications
like OVS ([1] and [2]) that currently look at rte_eth_devices[] to
achieve the same.

1: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1285
2: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1476

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/ethdev/rte_ethdev.h | 8 --------
 lib/ethdev/version.map  | 6 ++----
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index d2b27c351f..e888836471 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -1894,9 +1894,6 @@ uint16_t rte_eth_find_next(uint16_t port_id);
 	RTE_ETH_FOREACH_DEV_OWNED_BY(p, RTE_ETH_DEV_NO_OWNER)
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Iterates over ethdev ports of a specified device.
  *
  * @param port_id_start
@@ -1907,7 +1904,6 @@ uint16_t rte_eth_find_next(uint16_t port_id);
  *   Next port id of the device, possibly port_id_start,
  *   RTE_MAX_ETHPORTS if there is none.
  */
-__rte_experimental
 uint16_t
 rte_eth_find_next_of(uint16_t port_id_start,
 		const struct rte_device *parent);
@@ -1926,9 +1922,6 @@ rte_eth_find_next_of(uint16_t port_id_start,
 		port_id = rte_eth_find_next_of(port_id + 1, parent))
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Iterates over sibling ethdev ports (i.e. sharing the same rte_device).
  *
  * @param port_id_start
@@ -1939,7 +1932,6 @@ rte_eth_find_next_of(uint16_t port_id_start,
  *   Next sibling port id, possibly port_id_start or ref_port_id itself,
  *   RTE_MAX_ETHPORTS if there is none.
  */
-__rte_experimental
 uint16_t
 rte_eth_find_next_sibling(uint16_t port_id_start, uint16_t ref_port_id);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 3eece75b72..c52720851a 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -71,7 +71,9 @@ DPDK_22 {
 	rte_eth_dev_vlan_filter;
 	rte_eth_devices;
 	rte_eth_find_next;
+	rte_eth_find_next_of;
 	rte_eth_find_next_owned_by;
+	rte_eth_find_next_sibling;
 	rte_eth_iterator_cleanup;
 	rte_eth_iterator_init;
 	rte_eth_iterator_next;
@@ -157,10 +159,6 @@ EXPERIMENTAL {
 	rte_eth_dev_rx_intr_ctl_q_get_fd;
 	rte_flow_conv;
 
-	# added in 19.05
-	rte_eth_find_next_of;
-	rte_eth_find_next_sibling;
-
 	# added in 19.08
 	rte_eth_read_clock;
 
-- 
2.23.0

Re: [dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

[Andrew Rybchenko]

On 9/6/21 4:02 PM, David Marchand wrote:
> This API saw no update since its introduction and will help applications
> like OVS ([1] and [2]) that currently look at rte_eth_devices[] to
> achieve the same.
> 
> 1: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1285
> 2: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1476
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Re: [dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

[Kinsella, Ray]

On 06/09/2021 15:19, Andrew Rybchenko wrote:
> On 9/6/21 4:02 PM, David Marchand wrote:
>> This API saw no update since its introduction and will help applications
>> like OVS ([1] and [2]) that currently look at rte_eth_devices[] to
>> achieve the same.
>>
>> 1: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1285
>> 2: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1476
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>

Re: [dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

[Ferruh Yigit]

On 9/8/2021 9:54 AM, Kinsella, Ray wrote:
> 
> 
> On 06/09/2021 15:19, Andrew Rybchenko wrote:
>> On 9/6/21 4:02 PM, David Marchand wrote:
>>> This API saw no update since its introduction and will help applications
>>> like OVS ([1] and [2]) that currently look at rte_eth_devices[] to
>>> achieve the same.
>>>
>>> 1: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1285
>>> 2: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1476
>>>
>>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> 

Applied to dpdk-next-net/main, thanks.