From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver
Date: Thu, 22 Feb 2018 18:42:10 +0530 [thread overview]
Message-ID: <4be9feae-544a-65db-1871-5f80b23c0e9b@nxp.com> (raw)
In-Reply-To: <1519292089-13851-6-git-send-email-nipun.gupta@nxp.com>
Hi Nipun,
Some trivial inputs:
On Thursday 22 February 2018 03:04 PM, Nipun Gupta wrote:
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
> MAINTAINERS | 6 +
> config/common_armv8a_linuxapp | 5 +
> config/common_base | 5 +
> config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 +
> drivers/raw/Makefile | 1 +
> drivers/raw/dpaa2_cmdif/Makefile | 33 +++++
> drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 139 +++++++++++++++++++++
> drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 35 ++++++
> .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map | 4 +
> mk/rte.app.mk | 1 +
> 10 files changed, 235 insertions(+)
> create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
> create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
> create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
> create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a646ca3..e06df3b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -725,6 +725,12 @@ F: drivers/crypto/zuc/
> F: doc/guides/cryptodevs/zuc.rst
> F: doc/guides/cryptodevs/features/zuc.ini
>
> +Rawdev Drivers
> +--------------
> +
> +DPAA2 CMDIF
> +M: Nipun Gupta <nipun.gupta@nxp.com>
> +F: drivers/raw/dpaa2_cmdif/
I think you should put one more new line here. For all the sub-section
for Maintainers, there are 2 new lines before new sub-section starts.
>
> Eventdev Drivers
> ----------------
> diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
> index 507b28a..32e3cfe 100644
> --- a/config/common_armv8a_linuxapp
> +++ b/config/common_armv8a_linuxapp
> @@ -94,3 +94,8 @@ CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048
> #
> CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
> CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048
> +
> +#
> +# Compile DPAA2 Command Intefrace driver
^^^^^^^^^
Interface - spell mistake
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=y
> diff --git a/config/common_base b/config/common_base
> index ad03cf4..a549b54 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -587,6 +587,11 @@ CONFIG_RTE_RAWDEV_MAX_DEVS=10
> CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV=y
>
> #
> +# Compile DPAA2 CMDIF support
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=n
> +
> +#
> # Compile librte_ring
> #
> CONFIG_RTE_LIBRTE_RING=y
> diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> index afdbc34..ce1ffc5 100644
> --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> @@ -42,3 +42,9 @@ CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n
> CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_INIT=n
> CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_DRIVER=n
> CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_RX=n
> +
> +#
> +# Compile DPAA2 Command Intefrace driver
> +#
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=y
If already added in armv8a, why is it required in arm64-dpaa2 as well?
Rawdevices are intended to be custom and I think they should be added
only to the SoC specific configuration files.
-
Shreyansh
next prev parent reply other threads:[~2018-02-22 12:57 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 9:34 [dpdk-dev] [PATCH 0/9] Introduce DPAA2 Command Interface raw driver Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 1/9] mempool/dpaa2: add functions exposed to DPDK applications Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 2/9] bus/fslmc: expose API to free dpci device Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 3/9] bus/fslmc: keep Tx queues information for DPCI devices too Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 4/9] bus/fslmc: add preprocessors to get flc and frc from fd Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Nipun Gupta
2018-02-22 13:12 ` Shreyansh Jain [this message]
2018-02-23 6:35 ` Nipun Gupta
2018-02-22 14:31 ` Jerin Jacob
2018-02-23 6:35 ` Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 6/9] raw/dpaa2_cmdif: add attribute get functionality Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 7/9] raw/dpaa2_cmdif: support enqueue dequeue operations Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 8/9] doc: add DPAA2 CMDIF rawdev guide Nipun Gupta
2018-02-22 9:34 ` [dpdk-dev] [PATCH 9/9] doc: add dpaa2 command interface rawdev to release notes Nipun Gupta
2018-04-07 14:33 ` [dpdk-dev] [PATCH v2 0/9] Introduce DPAA2 Command Interface raw driver Nipun Gupta
2018-04-07 14:33 ` [dpdk-dev] [PATCH v2 1/9] mempool/dpaa2: add functions exposed to DPDK applications Nipun Gupta
2018-04-07 14:33 ` [dpdk-dev] [PATCH v2 2/9] bus/fslmc: expose API to free dpci device Nipun Gupta
2018-04-07 14:33 ` [dpdk-dev] [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI devices too Nipun Gupta
2018-04-25 1:47 ` Shreyansh Jain
2018-04-25 3:53 ` Shreyansh Jain
2018-04-07 14:34 ` [dpdk-dev] [PATCH v2 4/9] bus/fslmc: add preprocessors to get flc and frc from fd Nipun Gupta
2018-04-07 14:34 ` [dpdk-dev] [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Nipun Gupta
2018-04-25 4:18 ` Shreyansh Jain
2018-04-07 14:34 ` [dpdk-dev] [PATCH v2 6/9] raw/dpaa2_cmdif: add attribute get functionality Nipun Gupta
2018-04-07 14:34 ` [dpdk-dev] [PATCH v2 7/9] raw/dpaa2_cmdif: support enqueue dequeue operations Nipun Gupta
2018-04-07 14:34 ` [dpdk-dev] [PATCH v2 8/9] doc: add DPAA2 CMDIF rawdev guide Nipun Gupta
2018-04-16 12:40 ` Hemant Agrawal
2018-04-07 14:34 ` [dpdk-dev] [PATCH v2 9/9] doc: add dpaa2 command interface rawdev to release notes Nipun Gupta
2018-04-23 12:23 ` Kovacevic, Marko
2018-04-25 1:50 ` Shreyansh Jain
2018-04-07 14:43 ` [dpdk-dev] [PATCH v2 0/9] Introduce DPAA2 Command Interface raw driver Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 0/7 v3] " Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 1/7 v3] mempool/dpaa2: add functions exposed to DPDK applications Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 2/7 v3] bus/fslmc: expose API to free dpci device Nipun Gupta
2018-05-01 9:45 ` Shreyansh Jain
2018-04-26 10:14 ` [dpdk-dev] [PATCH 3/7 v3] bus/fslmc: keep Tx queues information for DPCI devices too Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 4/7 v3] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 5/7 v3] raw/dpaa2_cmdif: add attribute get functionality Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 6/7 v3] raw/dpaa2_cmdif: support enqueue dequeue operations Nipun Gupta
2018-04-26 10:14 ` [dpdk-dev] [PATCH 7/7 v3] doc: add DPAA2 CMDIF rawdev guide Nipun Gupta
2018-05-01 9:45 ` [dpdk-dev] [PATCH 0/7 v3] Introduce DPAA2 Command Interface raw driver Shreyansh Jain
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 0/7] " Nipun Gupta
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 1/7] mempool/dpaa2: add functions exposed to DPDK applications Nipun Gupta
2018-05-03 13:49 ` Shreyansh Jain
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 2/7] bus/fslmc: expose API to free dpci device Nipun Gupta
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 3/7] bus/fslmc: keep Tx queues information for DPCI devices too Nipun Gupta
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 4/7] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Nipun Gupta
2018-05-03 14:10 ` Shreyansh Jain
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 5/7] raw/dpaa2_cmdif: add attribute get functionality Nipun Gupta
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 6/7] raw/dpaa2_cmdif: support enqueue dequeue operations Nipun Gupta
2018-05-02 17:15 ` [dpdk-dev] [PATCH v4 7/7] doc: add DPAA2 CMDIF rawdev guide Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 0/7] Introduce DPAA2 Command Interface raw driver Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 1/7] mempool/dpaa2: add functions exposed to DPDK applications Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 2/7] bus/fslmc: expose API to free dpci device Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 3/7] bus/fslmc: keep Tx queues information for DPCI devices too Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 4/7] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 5/7] raw/dpaa2_cmdif: add attribute get functionality Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 6/7] raw/dpaa2_cmdif: support enqueue dequeue operations Nipun Gupta
2018-05-03 16:33 ` [dpdk-dev] [PATCH v5 7/7] doc: add DPAA2 CMDIF rawdev guide Nipun Gupta
2018-05-04 7:15 ` [dpdk-dev] [PATCH v5 0/7] Introduce DPAA2 Command Interface raw driver Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 " Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 1/7] mempool/dpaa2: add functions exposed to DPDK applications Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 2/7] bus/fslmc: expose API to free dpci device Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 3/7] bus/fslmc: keep Tx queues information for DPCI devices too Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 4/7] raw/dpaa2_cmdif: introduce DPAA2 command interface driver Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 5/7] raw/dpaa2_cmdif: add attribute get functionality Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 6/7] raw/dpaa2_cmdif: support enqueue dequeue operations Nipun Gupta
2018-05-04 10:11 ` [dpdk-dev] [PATCH v6 7/7] doc: add DPAA2 CMDIF rawdev guide Nipun Gupta
2018-05-08 12:08 ` Thomas Monjalon
2018-05-05 18:44 ` [dpdk-dev] [PATCH v6 0/7] Introduce DPAA2 Command Interface raw driver Shreyansh Jain
2018-05-08 12:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4be9feae-544a-65db-1871-5f80b23c0e9b@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).