From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BCC112BDF for ; Fri, 4 Nov 2016 09:39:19 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C687A4E4DE; Fri, 4 Nov 2016 08:39:18 +0000 (UTC) Received: from [10.36.4.213] (vpn1-4-213.ams2.redhat.com [10.36.4.213]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA48dGYO017573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Nov 2016 04:39:18 -0400 To: Yuanhan Liu , dev@dpdk.org References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> <1478189400-14606-7-git-send-email-yuanhan.liu@linux.intel.com> Cc: Ilya Maximets From: Maxime Coquelin Message-ID: <4c0a5a53-ddea-2049-cb76-ac4068b1a933@redhat.com> Date: Fri, 4 Nov 2016 09:39:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478189400-14606-7-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 04 Nov 2016 08:39:18 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 6/8] net/virtio: move queue configure code to proper place X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 08:39:20 -0000 On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > The only piece of code of virtio_dev_rxtx_start() is actually doing > queue configure/setup work. So, move it to corresponding queue_setup > callback. > > Once that is done, virtio_dev_rxtx_start() becomes an empty function, > thus it's being removed. > > Signed-off-by: Yuanhan Liu > --- > drivers/net/virtio/virtio_ethdev.c | 2 - > drivers/net/virtio/virtio_ethdev.h | 2 - > drivers/net/virtio/virtio_rxtx.c | 187 ++++++++++++++++--------------------- > 3 files changed, 79 insertions(+), 112 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime