Re: [dpdk-dev] [PATCH v6 1/5] ethdev: add access to eeprom

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/25/2018 11:01 AM, Zijie Pan wrote:
> add new APIs:
> - rte_eth_dev_get_module_info
> - rte_eth_dev_get_module_eeprom
> 
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> Acked-by: Remy Horton <remy.horton@intel.com>
> ---
> Cc: remy.horton@intel.com
> Cc: john.mcnamara@intel.com
> Cc: marko.kovacevic@intel.com
> Cc: thomas@monjalon.net
> 
>  doc/guides/nics/features.rst            |   11 ++++++++
>  lib/librte_ether/rte_dev_info.h         |   18 +++++++++++++
>  lib/librte_ether/rte_ethdev.c           |   26 +++++++++++++++++++
>  lib/librte_ether/rte_ethdev.h           |   43 +++++++++++++++++++++++++++++++
>  lib/librte_ether/rte_ethdev_core.h      |   12 +++++++++
>  lib/librte_ether/rte_ethdev_version.map |    2 ++
>  6 files changed, 112 insertions(+)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index 1b4fb97..bb183e2 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -749,6 +749,17 @@ Supports getting/setting device eeprom data.
>    ``rte_eth_dev_set_eeprom()``.
>  
>  
> +.. _nic_features_module_eeprom_dump:
> +
> +Module EEPROM dump
> +------------------
> +
> +Supports getting information and data of plugin module eeprom.
> +
> +* **[implements] eth_dev_ops**: ``get_module_info``, ``get_module_eeprom``.
> +* **[related]    API**: ``rte_eth_dev_get_module_info()``, ``rte_eth_dev_get_module_eeprom()``.
> +
> +

New feature added also needs to be added default.ini file, please replace this
feature somewhere close the related features in default.ini

And please keep Thomas' Ack for next version