From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB2C743CA3; Thu, 14 Mar 2024 12:02:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B27FB42EA3; Thu, 14 Mar 2024 12:02:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 91A2B42E6A; Thu, 14 Mar 2024 12:02:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710414123; x=1741950123; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=mU48LzQjxvYrlPxbu0lwMQx1xUWoz3tlpA/sRiml7Uc=; b=eqxRTV4LJAEOfuOQyHPKxD+xwzc+s66pgSI1riZJG1zy8chI2EAuORWR oLX79GGuxECLeYO09ojaAoMsdXuKXD8JSJ92zClmO08cb5wNDtbme0Pcu HkMA2IuAwo+QXio40wImSd1kq+Hnr3B33Jjj4kKYk2dSuZ4JjTCG7FpjX u7IJriaOUTaCYZ8TOoT4VhzJmDfnP/C1Sbj29cMyZkUiLnM0Ey1Q15BGO ohfpov4fLZGVqWnHkjt71xvI32kRWnujops9TdEFj7MBktb8ZWiTk10xI G+EX9D3pvUqll9yr3f3sz+1XmpI1Uyv0I2g1JLkYMqSy37grBm8BRZ8mA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="15951814" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="15951814" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 04:02:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="12649104" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Mar 2024 04:02:01 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Mar 2024 04:02:00 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Mar 2024 04:02:00 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 14 Mar 2024 04:02:00 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 14 Mar 2024 04:01:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GI/Y9RcH9tpePRurzzmnD2saSjJOSLlZDhuTzP18qN3YSGbzcYbmPf5KSmyl4HZ3RmNwacC/np7P7PiwN0N0nUi8dw/+qkgPlrTq7htrWGue2ANuOiClln/nSdQzuz1O5pNneo+aeK6O0z6OzPwNL6J3GNfm1ZZZYQ8bXQWSLB0co5lK7qCqE07Lr+gICvTZo1bDFboxtoVdscOw0NZMKdsPfsW9NESEGa298Z+Lm/sEcd/3DMZ5VABKKSPEu2tQFEmqbYZU2gaYmaylEgElST+teD50AjHq1eo488uV8wA2ml1bg67Un/fFPOlKJQXnTT4+BShFRqdhMZgp5/7vLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=61XXqCKMEnKrysNcQa4cQP+fw13lSfj+j15GGiWGPck=; b=CiBvwO4HkDLGs0hCugIpPJKRB8XfHADvdzeS4iUmPRCGa1G2xXlV/k1eRGG4sOD+blyzBZvI95Lvyg8P+BVYfBj2vHcnmQ5/GzEVcC+4uHXytc+ZVpqJIucYHKp0CrTtp3BL4eFbV5C7BWAepDyTARuV7xKyyKT96KN98v0taylLarYn1sXG95lR/0aQpcDm2q3AHErRPwhxV+NNXNUgQmjbzhm7Vf6ibrQkh35BWfR/v1aZqyf6n+zpFCiIoS1PQjrZvSXzv8ZqQN1uAGr6ILdcmjD7jRGNnsVYjAGUgclR6CPjF9CLgvSoL/jcIC7rmb41DJWxfJ7MRaZ7RIi0xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by PH7PR11MB5916.namprd11.prod.outlook.com (2603:10b6:510:13d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Thu, 14 Mar 2024 11:01:57 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::ab9d:3c81:51ea:7bb4]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::ab9d:3c81:51ea:7bb4%3]) with mapi id 15.20.7386.015; Thu, 14 Mar 2024 11:01:57 +0000 Message-ID: <4c19291d-ba76-4834-b8b9-cebf407e5357@intel.com> Date: Thu, 14 Mar 2024 12:01:50 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] bus/pci: fix secondary process save 'FD' problem Content-Language: en-US To: Chaoyong He , CC: , Zerun Fu , , , Long Wu , "Peng Zhang" References: <20240124104523.2022242-1-chaoyong.he@corigine.com> <20240129092231.3531217-1-chaoyong.he@corigine.com> <20240129092231.3531217-3-chaoyong.he@corigine.com> From: "Burakov, Anatoly" In-Reply-To: <20240129092231.3531217-3-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU6P191CA0066.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53e::6) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|PH7PR11MB5916:EE_ X-MS-Office365-Filtering-Correlation-Id: 2517c637-a59a-46fd-c898-08dc44162a5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t4cUMTeq5IsJMa5t4JjaBwgmlyiGjAeXFwP62PY7etq9vBgQBx9qZ7QS39fGBPPPvCKxjcJWr5cOIX9JSr30tzhECP9bj9feTm76RYbAyDfauYIn/cyxhNaiQ3XQ9L2o4P3GGZfv5Cy2VmLY4AfFN5EcwLjYfmFAvZtvuBC8NRvIYL9LGlkd/mMq1QPrUeyK6EJ1tlxv0wPK3N1FyUkTlitAjvi1YpgHRsYprlHO1avutvAQAT63nBZfJMTie+fSI2cm2bFYXBDunyj1O5Tu6S8gx6+QcgZaF45+qNgmDq+iPaEPOEWB/MIR7WuBZqvv2POQteMhu/QVZ5q12ped2tCXY8KNz4zdReTBFg7pl2Tvv1wxyc78xzzlTqGtaY/oY056crzAXT1nQVIokUggRmZeUQuEW+pr9sd5QzBWlvg3hFuk5J9x1Xi24L9yi+AMkdAwgPIs2gWgR/r9VZ8IWcwFEYcWJQ95t6Plo2bLOBamrmByWCQBLnG9XUr81PuoG/87n4Obhz/JXsLhbXAVzuttfQn7QlP1Te29G49t28rR+8mzZgiGFlgSc+mRIjyhY3pwtXG3YBPES9M+YYxBZFprhwwZjq/idAzpBS4x47zVU43OpGRS1eWH4w8gvA+4aMWYfiT1soX+X+6/Wfn+UJPwOczZCTCdp2nckC+Pt40= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGZLcVJiWnNXQWtzM3dFN3paV3RhdHpaWEoyQlBhU2JzNGJmMDNBcjhlWDRP?= =?utf-8?B?TjluYWNETlJPQmdqcjBFWmxFcDI4TXhRODhhYmtJK2o5OWVRVHB4UEFLb21j?= =?utf-8?B?MXR4bVdMVW1xUzVaOHM4ZSsrei93TXd3eDVmeHBuVEJQWlYyd0hiWmFyZjFE?= =?utf-8?B?UFB3elBvL3BqZFVhS2VUblljWWRMMW5ESnk5TGlOM0lRbEo2VEE5OGtvQTJk?= =?utf-8?B?cmNDOFU3WlVvOFlxaW1aT21pWnZMUmcyeStaUHdZQmZLaHR0YW9wZFJ2bm54?= =?utf-8?B?RmdjRTJsQmlaZTExaFJBRjRNd3EzMzIwaTI4OURoUi91alo4STRPSnZlUGR3?= =?utf-8?B?aWZzQnhONXdBTUR6R0lHTVFSVEkyQlpoSmlsY0phUDQ1cEE5ZGZ4Y0xUM29C?= =?utf-8?B?cW5CWUp6d0ZrSVc0MkhUeHkzam1mOGh0dFRnMkMzYW5adXFWblRhT1JJcTAw?= =?utf-8?B?bnhWU1BlRi9URzM3WFl5LzdqSVlqYm1ZSys1MUl5dWN5MHhPOWl1RHZzWlNH?= =?utf-8?B?UklyOUNoNm96T1cvYTZXRkQ5STVNRStJT2tCamFEWVFyMWhPQTZnMGJzVUJQ?= =?utf-8?B?WnA3djdxZWluNnFZbnVudmtLMzBZM1Z4eGVRdm1iYnZMbFJqOG9rTTlGZHVX?= =?utf-8?B?d1RXOGVrMVBjR3VMNXNyYjNSUU5lZmh6anlRQld5aU9UVW5nS2YzUVArSTVh?= =?utf-8?B?bXloMmlGL3RsdDNndVRYSXpYeFFsQjdXUVNBb29KYno3Q1l1Y1hpL3IyNFd0?= =?utf-8?B?NmxNanVlV2thWXRtQ2Y4M0R6NENYMHI0QUlZY0M4RnI0M2JPUDc1OW52dFdO?= =?utf-8?B?MC80d0s0ZkZVVFNIb2hMcUltOEp1MjQ5MTZpeUpDb2lRTnNPeXhkUXdrcGRY?= =?utf-8?B?K3JKSlh0WEU4bGhsdGp2NVZUcU0wbktwbjM4MGdwV3U4OWlyUXpnWUd3eW5W?= =?utf-8?B?Ty9xZWxQOHh0bGpmSmY0Q2c0U0wySy9YQzZ0R2V2YjFJRmNxVTZjcjBaVElz?= =?utf-8?B?MldzWHdkQ09mV1ZRUzdROEJGRG5uQTdiV2t5YTIyOG1jRVh1YXJnM3EvNEdC?= =?utf-8?B?UkFFZS9qSVNhUnhxVG5oNVQrQUE4SnpYTERYWHNheHJOVGR4d2NnVUJrc0lO?= =?utf-8?B?WXFDZUVUcm82andkR2RJcnBYQ1hkS1NnSi9zZm53dHJ3VVVwcHd5dU9xb3RR?= =?utf-8?B?RElvdnMyTVlpelRvdW8wa3dnMHppUlZTYm1ieUxoamI1TDY0RTVPYjhuREF4?= =?utf-8?B?bzlrV2VmWTU2VW1KOG5yaDBMaFErWE5nQ0xmZTR2MnQ4TkRJTm45V1ZsZHNJ?= =?utf-8?B?bDkxeUg3MFhwRGV6NWVwVFhZamRuYklTN1BjS2FOKy9MbjZtcXNoak92L0Rn?= =?utf-8?B?VFhkYWFkQUNXdnB2NHdDTDlJQWVjR0V5cktOd3c5WFQ3Rnlody9zT3NhbkVl?= =?utf-8?B?VUJLQURSR0psM3lSQ09jU2g2VGRQS0E2cEZhNnV4TGxINS9rdENHT1FZZkYz?= =?utf-8?B?Sk5zdHRBVHdNQk02cjVYMkdOdENKRzZLM2dDZWxVK1VHOGVhOGVaWnA5TVlt?= =?utf-8?B?R2hyWmFGRkZFNHFlZExSMjZhTkEzMG5LbldJZzgrSWk5L1hYL3NyV1BrOGZG?= =?utf-8?B?R0JYUEVQaXhUMWxtSnptUFR4Z0FPV1pSSFhtNGpuQkJDY3k3VW5nMG1KM1pE?= =?utf-8?B?VXBjQXpFRGRwTVN6MUVqaSt0enNNR084Qm8vS0J5M0RvQWJYUEl5Z3hXbFB1?= =?utf-8?B?bUhjQkVsWEtVa0pnbm9aS1NYL2lJRVFjbjFNMW1tRkV5VGNIRnFqd01ObEpi?= =?utf-8?B?cmRhdGEwVjZWYWQ0Q2NRMHVBUTVuV2tleEg1TzRvbTZxZUhoMVpNWmlIRTZT?= =?utf-8?B?TzBqMmhCTXVValQ5YVJnYmtLNTdONktGNmhwUzFuZjBxb1ZnQThUcXgwRUtR?= =?utf-8?B?NG0zZ2dYblQrRnVZWHkrWk13U2tYSG8zaHZsblh6RDQ5Vjc1RkRNTDdwc0JT?= =?utf-8?B?eStMRkZzVVd1KzFodE1OVW9TbStieHN1dGJ4RW1FU1BNd0V6eHFOcXJiS0pM?= =?utf-8?B?QmZ3YzFTajNIZTlGNWc1YVMyQjNac2g5VzBXNzh2UWlRUVdmaWdNTm9hMXFI?= =?utf-8?B?WHArWmV6ejdxcDJoQ3Ewc002bzR1b1RTQ21RN3JoSmdwQlc3RS9EdnRHdFJu?= =?utf-8?B?ZWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2517c637-a59a-46fd-c898-08dc44162a5f X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:01:57.1916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uKyn6KJHKBqadw4VGsm+3y6DQum29aRVsPp3MPA9+BkSfFgbCesybrT8fiRZ2wpuebxiN3oNOXlPpIj5PTQhejX2zEpbxqL9n6ldoWaPI28= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5916 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/29/2024 10:22 AM, Chaoyong He wrote: > From: Zerun Fu > > In the previous logic the 'fd' was only saved in the primary process, > but for some devices this value is also used in the secondary logic. > > For example, the call of 'rte_pci_find_ext_capability()' will fail in > the secondary process. > > Fix this problem by getting and saving the value of 'fd' also in the > secondary process logic. > > Fixes: 9b957f378abf ("pci: merge uio functions for linux and bsd") > Cc: mukawa@igel.co.jp > Cc: stable@dpdk.org > > Signed-off-by: Zerun Fu > Reviewed-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly