From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FADB42B2C; Wed, 17 May 2023 19:34:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75FBB40EE1; Wed, 17 May 2023 19:34:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 35AD8406B7 for ; Wed, 17 May 2023 19:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684344838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uqvokx/Yjyp3mMvpte7PosRTaxxua/n+EazULw4ccFQ=; b=H7PcvIcrGeblOc87Td08w4GrVVlRl9jOrno76DlffGNSdRtTuP86juL8chQXNhfR1PTv1q KIzx+rGaLt7aIO1OjX7yDkdfLVvBDLPbK3kncQjvble8qTXId/cY7YYuw0kCn4xEBzSpgV VFUit+9MHCrfYsW7tgP993g2ZQVRSBE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-SbU3EWtHOlGALc95mXYQtw-1; Wed, 17 May 2023 13:33:57 -0400 X-MC-Unique: SbU3EWtHOlGALc95mXYQtw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 22A5C1C05AAB; Wed, 17 May 2023 17:33:57 +0000 (UTC) Received: from [10.39.208.42] (unknown [10.39.208.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FA5B40C2063; Wed, 17 May 2023 17:33:56 +0000 (UTC) Message-ID: <4c426886-90aa-80d6-5372-c891eff3fcab@redhat.com> Date: Wed, 17 May 2023 19:33:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one To: Eelco Chaudron , chenbo.xia@intel.com, david.marchand@redhat.com Cc: dev@dpdk.org References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431452543.558450.14131829672896784074.stgit@ebuild.local> From: Maxime Coquelin In-Reply-To: <168431452543.558450.14131829672896784074.stgit@ebuild.local> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Eelco, On 5/17/23 11:08, Eelco Chaudron wrote: > This change will allow the vhost interrupt datapath handling to be split > between two processed without one of them holding an explicit lock. > As I had a tuned PVP benchmarking setup at hand, I ran a 0.02% loss RFC2544 test with and without this patch to ensure moving to RX locks would not introduce performance regression. I can confirm there are no performance regression introduced with this patch applied: Tested-by: Maxime Coquelin And the patch looks good to me: Reviewed-by: Maxime Coquelin Thanks, Maxime > Signed-off-by: Eelco Chaudron > --- > lib/eal/include/generic/rte_rwlock.h | 17 ++++++ > lib/vhost/vhost.c | 46 +++++++++-------- > lib/vhost/vhost.h | 4 +- > lib/vhost/vhost_user.c | 14 +++-- > lib/vhost/virtio_net.c | 90 +++++++++++++++++----------------- > 5 files changed, 94 insertions(+), 77 deletions(-) >