From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0074.outbound.protection.outlook.com [104.47.42.74]) by dpdk.org (Postfix) with ESMTP id 546EEFFA for ; Wed, 6 Sep 2017 10:32:17 +0200 (CEST) Received: from MWHPR03CA0053.namprd03.prod.outlook.com (10.174.173.170) by BN3PR03MB2257.namprd03.prod.outlook.com (10.166.74.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 08:32:15 +0000 Received: from BL2FFO11OLC007.protection.gbl (2a01:111:f400:7c09::186) by MWHPR03CA0053.outlook.office365.com (2603:10b6:301:3b::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Wed, 6 Sep 2017 08:32:15 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC007.mail.protection.outlook.com (10.173.160.142) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11 via Frontend Transport; Wed, 6 Sep 2017 08:32:14 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v868WA1O001298; Wed, 6 Sep 2017 01:32:11 -0700 To: Zhiyong Yang , References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-2-zhiyong.yang@intel.com> CC: , , , From: Hemant Agrawal Message-ID: <4c6b2939-1e22-b1be-89bb-135731f7e24e@nxp.com> Date: Wed, 6 Sep 2017 14:02:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170904055734.21354-2-zhiyong.yang@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131491603345563840; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(189002)(24454002)(377454003)(81156014)(498600001)(6246003)(8676002)(77096006)(68736007)(50466002)(356003)(23746002)(47776003)(2950100002)(305945005)(64126003)(229853002)(36756003)(85426001)(76176999)(2906002)(4001350100001)(83506001)(81166006)(50986999)(8936002)(4326008)(626005)(86362001)(575784001)(53546010)(54356999)(230700001)(189998001)(54906002)(31686004)(65826007)(97736004)(31696002)(33646002)(104016004)(105606002)(65956001)(53936002)(106466001)(5660300001)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2257; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC007; 1:QpuLBf29Rrpq6NFHkPrznYHa+KHSlZ2eDcWAmhGoIHAlM5EYRhInPtBeSmHPdgLQ+Ss9gFi47BcLoPL7U5glYtpZVwkcW6W2X+Buy6bMuLRf7n2Ki2ceAc+TxzRHJUbk X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b10a4245-ba78-42e0-e0c0-08d4f501c6d2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR03MB2257; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2257; 3:kVgsNoCQA2RNG+cCH3oKukPcRkTowA/139pxX5izs92NU9Qy4TGDumFlkSBV7b7MagiBSLC8zMmfKFk+bayZSkZPLxE6edEKL3r5AO7DZoQJcntq0ZzVd/vVpDP25tp9rUGj/1ni8BA4A5q8vpp40kAEJjvbDHh8uHu8zjATxWY5nu3Z9+pHfKJZTArJ5C9+uPorBswxQCFpU/3qMuK9PxJpBCKLgW3V62wOU9lWETA7lPcFUljp3Tk16bBhz7F8bDu4kggRGWFtB54AUPgvGRcDRs7Q+w5bHaeCwuZPRQf4AzaOipovPc8HmYqCCOx9pZ52i9XxUa/XBSnSnKsMjW9nwfVV1mFHnlwfQ+wv5AE=; 25:RiUKsYfDcmXTk8t8kOH0DEBRMnj6E7+0HIv3bXYjwYtXbJ64l5lU6tab/89O9aF1cbvDz/heRGD8Ex/MjDVo2zFLC+appzSVWoP5wFlEiTACy+4qLy9ZTLc6Wwzd/baIlyB5e086R0/mpjhHAsiOW4dc6skR/oDXJxXDVapdXN3MiFF6M9KIaVFfwF/qMBxDHiZdbkr/yb4HTpxZC42GTw+BgtDlrejTLvqMzcHQVJjeXp32kPdqH1ow8a2R9wG2f1Rl16M6/JnR/c0zFvrngeH/3ITBkhsUsPgob4SR72aqHX4vUSrYqyilfuMipm1U8m4vNuYxAP70kFvn1tu2eQ== X-MS-TrafficTypeDiagnostic: BN3PR03MB2257: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2257; 31:joSZvKtOIrPBAsBUxgLzQ1fRiSkc2UTkBt4jCWTUNeuRZAfJJtXhulGAWc1wYfuE4FttBqUztC8l6b4W7tT+mbOMDC9gtH8vlAKVEOcfVofYDlXf4ivV+a/rSbCsoNo3ucBlMzh2SDLFZCoS4+MrNCIC/oZTivAqmttjRfCUipVwmJ0//4WA0VQo4dGExnFwLzf6Q2uk3Yc8LwkuQ+HoDBTs+yWkyDW5mJxDYMaGZmw=; 4:k2ntiQ9tuKbCyWuhhAknSuhH0xxFWPN3g+8WU0rjFoPXRvH7jlfhKu/TFhbU28LOKgiyuxzot3wpkHzTE2qjFAviEgS/PufjgD7BKoJ0804qGc3qtP7TQ2K8R0MqnW/Wrlrj8ytjQ5PO1VFNQ6qZEzeuGhUZlT8Sb0zjSGaEKzJoAxraJvcItXPrpll2S57h8Q4J26bGmabYx3GbotM+dK/gommPjhO7UwfZpkWYCK2sSw81YmXt7JehLocLpYjJf+DwQxQS27ayZw3QeOlpAgsoM77u6+14jra3dcT0k2s= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123559100)(20161123556025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123563025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2257; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2257; X-Forefront-PRVS: 0422860ED4 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN3PR03MB2257; 23:UU1d4KiZWnAHcrt6QmsIcusL7Fs8LWuiO7rHP?= =?Windows-1252?Q?FXfJxXTR9CxNat9qjhfPwBEliq48WwZIODHy5t8KGJSoUMV73nJKeTg8?= =?Windows-1252?Q?UHKUPWaC46EA3stDJA/05UBzKRo9nJSzHTmsqMFnmvtKU7rurIlgS1vZ?= =?Windows-1252?Q?uMc0y+8UFN4yeKuP6Qti8Z3SIj0W9dzuRqNDd/LCVwSGf+PafhAr7Mn3?= =?Windows-1252?Q?A6cmTAOdiHQhrN0ZwqhVRorQgPTUxkeVrqosGRC7ta6FUZLRfceOp6cD?= =?Windows-1252?Q?+HN5nlzCuZDlw4vcgYVhNa09UpzjJi7bmW/yLr04n8dYRwGVDw1/IBd8?= =?Windows-1252?Q?UVvdIJTZyv7dk8ZcbdM6jOlTRPM4nhetLy8MYeAhS8EYrgf1Tk3hh0FV?= =?Windows-1252?Q?QWFrtkdp9YoxmkvzgVNmz50kmHaWOVBF0mHJT3Z3rQcqiQqCxNGJNRwB?= =?Windows-1252?Q?4Sya+OGdXZ86TQCjHqQ27NZFkKC/iNA006XkOT78ZVadAH5QVyfRVT2n?= =?Windows-1252?Q?A4ID7DobbsKXZUsoHglyxmT4SEwRURxfxQEQWVpiXrLlEO6nUCJo2PU+?= =?Windows-1252?Q?54iGd6qFSStaqP5W9oaGCGQr5PZOHJ4fNZPyRiunucU8teL4TVe5o0OH?= =?Windows-1252?Q?sjkz20PGenWZhz2NmQvEYtpy03NtaAB04ZQhNzBIr33q69fvB4FLcFuW?= =?Windows-1252?Q?25bWlSAz7tfNqRvPuH0qdll/PRyI8H4u5nc1moG7x7iz+31wF2vfWqYn?= =?Windows-1252?Q?cvv9OgEoivPAZnC8yM1Gy2zg3X6VdbTrW+2l4vuXqfl9PnFKaVEYn/Dx?= =?Windows-1252?Q?QemmGt+BQmr0Hp4iiQTHP2DcaMOX/mX8I/Uqgzp8hUxoywpdoaDhLPRM?= =?Windows-1252?Q?RuDJFJb0tgxPcbYoIzZmVVP6saMFI72fX92TqlnBmyx9p1Dlcjsj/gg4?= =?Windows-1252?Q?GH7JcSu+eSxRUUwHe1McyBop9+D0z9u8WSRldbwGOf9r1ZldzknwKqtS?= =?Windows-1252?Q?ynohqnJ+90BnYV9zqPvC5zdjKFNKs2G4mjzP7U9vttKvU7e8VehUuaxG?= =?Windows-1252?Q?1JT/wdaxDenrfKO2jg7SWp4bltfbOOpOM5QuotbibjJZZGotKPxI79vT?= =?Windows-1252?Q?Mx5jJByrCLMG2ZYIHROl1bDSuspnkmjY0+vjvKeBx0ZW9JXIPWXtj4Rb?= =?Windows-1252?Q?/3TeNt7LGQ9ozFnnq4He/J757HnjrbA8B2gqR/eBQS2u4GCXO82Kc4ke?= =?Windows-1252?Q?BXgzbhYzViTlAs4nJZ1HJDKE/iKclbnWTaDZybeoNueyEyWL32NwqLq9?= =?Windows-1252?Q?iHBaNpEHinokYjPsl8RcYgHANeYTaUk7KDCFI3jDDjRxv2vVlv+QAO6j?= =?Windows-1252?Q?kB6L5gHt/YRGKvcdz5CGEZNZN7BlOPW0IQbnWdF680HP1M/+psVgLVAx?= =?Windows-1252?Q?m2gLvmpVytOGXBfzyznruHoVb5mbAAMJ0AB9lJMzw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2257; 6:5Yo/jSSmtRx/eNq/fkOVNdnF4tXaBRhh8mQITwSSGDDIj35YDfaOzMiB+BFRGtc56nVZ1OPHs6P1OiegsbqWHVikCkMSFrPt9IEh/w44TF248kmzGNANmC9dzxpYxvt+qwR1egxZ2d7g3kYvvGLu2Pyg7Ylx7Ecx9i3pdmqSyCHOdlHZi6xWBXN4AGea9cvJUWYq77QQkpoZP6xA69Tf731zexwNS4hk+SuAti4r2QyHI20D8RBHKYS085FSKnTyzpTgd7oJlnxcTBoHICmR6pJjBg2EIHu+UDSuQG91SylPd1OZdCh41yBWW5fJZldSdvKYutC7YXN0JAw+9/57Cw==; 5:BQfnUvi32+axtxgJA48kZOrGa3G7S+SQchbyldF6oIhCbTT+AZhtrUviQxs++VsgTO1A32F790ncGXMV4z+rcTUufLMg3YZWU4WolVwuNueOUowuBsAbQI+RNPsDlV8CSRHDuO/wN5cx59f9XxpGNw==; 24:CpH7bS62tXDAehP8SIHzn1dlOC08Tllcgw35xF2MV+pcZa3IaRb1gPp/1hsS56/VmjtG0YZZoL2o3fNr2JuJa8TZHZ4FMRi1U6vySBo80k8=; 7:P2jki5ocwVR+q7WXYdrsCr6ahkT5DUco9vKh0b15K93pIt/W40Oguvf6A4/ZuKAIrEEaSTMe2W+Qu8ob0GcxdMUVHCJszymn6VmQHKv61dfAZwchiJF9NIElI6hgw8IXT6RfbW95qoSYdSz1p/0F0tSKbedfcOntTUwEMlslgpI57JJ8XrLUNmVlaPNY7gl2Z6LsP4EaclLYQq5jPSZS7Bef+2bIv6EhcSqtUAozaVY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 08:32:14.4003 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2257 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 08:32:18 -0000 On 9/4/2017 11:27 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. > Modify the APIs, drivers and app using port_id at the same time except > some drivers such as MLX4 and MLX5 due to fail to compile them in my > server. > > Fix some checkpatch issues from the original code and remove some > unnecessary cast operations. > > Signed-off-by: Zhiyong Yang .. diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 128bc5221..3b52d0f24 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -360,7 +360,7 @@ struct rte_event_dev_info { > /**< Maximum number of event priority levels by this device. > * Valid when the device has RTE_EVENT_DEV_CAP_EVENT_QOS capability > */ > - uint8_t max_event_ports; > + uint16_t max_event_ports; > /**< Maximum number of event ports supported by this device */ I think, you can leave this one. Or a bit of variable movement will help in structure alignment. if you still want to change, please also change dpaa2_eventdev.h struct dpaa2_eventdev { - uint8_t nb_event_ports; - uint8_t resvd_1; + uint16_t nb_event_ports; > uint8_t max_event_port_dequeue_depth; > /**< Maximum number of events can be dequeued at a time from an > @@ -428,7 +428,7 @@ struct rte_event_dev_config { > * This value cannot exceed the *max_event_queues* which previously > * provided in rte_event_dev_info_get() > */ > - uint8_t nb_event_ports; > + uint16_t nb_event_ports; > /**< Number of event ports to configure on this device. > * This value cannot exceed the *max_event_ports* which previously > * provided in rte_event_dev_info_get() .. > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h b/lib/librte_eventdev/rte_eventdev_pmd.h > index 3d72acf3a..ef7c932a7 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd.h > @@ -265,7 +265,7 @@ typedef void (*eventdev_queue_release_t)(struct rte_eventdev *dev, > * > */ > typedef void (*eventdev_port_default_conf_get_t)(struct rte_eventdev *dev, > - uint8_t port_id, struct rte_event_port_conf *port_conf); > + uint16_t port_id, struct rte_event_port_conf *port_conf); > please also update dpaa2_eventdev_port_def_conf > /** > * Setup an event port. > @@ -281,7 +281,7 @@ typedef void (*eventdev_port_default_conf_get_t)(struct rte_eventdev *dev, > * Returns 0 on success. > */ > typedef int (*eventdev_port_setup_t)(struct rte_eventdev *dev, > - uint8_t port_id, > + uint16_t port_id, > const struct rte_event_port_conf *port_conf); > please also update dpaa2_eventdev_port_setup > /** > @@ -379,7 +379,7 @@ typedef void (*eventdev_dump_t)(struct rte_eventdev *dev, FILE *f); > * The number of stat values successfully filled into the values array > */ > typedef int (*eventdev_xstats_get_t)(const struct rte_eventdev *dev, > - enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id, > + enum rte_event_dev_xstats_mode mode, uint16_t queue_port_id, > const unsigned int ids[], uint64_t values[], unsigned int n); > > /** > @@ -407,7 +407,7 @@ typedef int (*eventdev_xstats_reset_t)(struct rte_eventdev *dev, > * values, and do not fill in any data into xstats_names. > */ > typedef int (*eventdev_xstats_get_names_t)(const struct rte_eventdev *dev, > - enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id, > + enum rte_event_dev_xstats_mode mode, uint16_t queue_port_id, > struct rte_event_dev_xstats_name *xstats_names, > unsigned int *ids, unsigned int size); >