From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
dev@dpdk.org, alialnu@mellanox.com, orgerlitz@mellanox.com,
wenzhuo.lu@intel.com, beilei.xing@intel.com,
bernard.iremonger@intel.com
Cc: hemant.agrawal@nxp.com, jerinj@marvell.com,
viacheslavo@mellanox.com, thomas@monjalon.net,
ruifeng.wang@arm.com, phil.yang@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: enable empty polls in burst stats
Date: Mon, 6 Jul 2020 18:05:45 +0100 [thread overview]
Message-ID: <4ca0b9e5-9808-7c2f-a818-225058e875be@intel.com> (raw)
In-Reply-To: <20200626220943.22526-5-honnappa.nagarahalli@arm.com>
On 6/26/2020 11:09 PM, Honnappa Nagarahalli wrote:
> The number of empty polls provides information about available
> CPU head room in the presence of continuous polling.
+1 to have it, it can be useful.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Tested-by: Phil Yang <phil.yang@arm.com>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
<...>
> /*
> * First compute the total number of packet bursts and the
> * two highest numbers of bursts of the same number of packets.
> */
> total_burst = 0;
> - burst_stats[0] = burst_stats[1] = burst_stats[2] = 0;
> - pktnb_stats[0] = pktnb_stats[1] = pktnb_stats[2] = 0;
> + memset(&burst_stats, 0x0, sizeof(burst_stats));
> + memset(&pktnb_stats, 0x0, sizeof(pktnb_stats));
> +
> for (nb_pkt = 0; nb_pkt < MAX_PKT_BURST; nb_pkt++) {
> nb_burst = pbs->pkt_burst_spread[nb_pkt];
> - if (nb_burst == 0)
> - continue;
> total_burst += nb_burst;
> - if (nb_burst > burst_stats[0]) {
> - burst_stats[1] = burst_stats[0];
> - pktnb_stats[1] = pktnb_stats[0];
> +
> + /* Show empty poll stats always */
> + if (nb_pkt == 0) {
> burst_stats[0] = nb_burst;
> pktnb_stats[0] = nb_pkt;
just a minor issue but this assignment is not needed.
> - } else if (nb_burst > burst_stats[1]) {
> + continue;
> + }
> +
> + if (nb_burst == 0)
> + continue;
again another minor issue, can have this check above 'nb_pkt == 0', to prevent
unnecssary "burst_stats[0] = nb_burst;" assignment if "nb_burst == 0".
<...>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2020-07-06 17:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:43 [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation Honnappa Nagarahalli
2020-06-17 14:43 ` [dpdk-dev] [PATCH 2/5] app/testpmd: enable burst stats for flowgen mode rx path Honnappa Nagarahalli
2020-06-18 14:57 ` Phil Yang
2020-06-17 14:43 ` [dpdk-dev] [PATCH 3/5] app/testpmd: enable burst stats for noisy vnf mode Honnappa Nagarahalli
2020-06-18 7:16 ` Jens Freimann
2020-06-17 14:43 ` [dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation Honnappa Nagarahalli
2020-06-18 15:01 ` Phil Yang
2020-06-23 13:33 ` Ali Alnubani
2020-06-17 14:43 ` [dpdk-dev] [PATCH 5/5] app/testpmd: enable empty polls in burst stats Honnappa Nagarahalli
2020-06-18 15:05 ` Phil Yang
2020-06-23 13:34 ` Ali Alnubani
2020-06-17 15:16 ` [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation Jerin Jacob
2020-06-18 4:03 ` Honnappa Nagarahalli
2020-06-18 10:16 ` Jerin Jacob
2020-06-18 15:08 ` Phil Yang
2020-06-23 13:33 ` Ali Alnubani
2020-06-26 22:09 ` [dpdk-dev] [PATCH v2 " Honnappa Nagarahalli
2020-06-26 22:09 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: enable burst stats for flowgen mode rx path Honnappa Nagarahalli
2020-07-06 16:02 ` Ferruh Yigit
2020-07-06 17:06 ` Honnappa Nagarahalli
2020-07-06 17:17 ` Ferruh Yigit
2020-07-06 18:46 ` Honnappa Nagarahalli
2020-06-26 22:09 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: enable burst stats for noisy vnf mode Honnappa Nagarahalli
2020-07-06 16:08 ` Ferruh Yigit
2020-07-06 16:59 ` Honnappa Nagarahalli
2020-07-06 17:11 ` Ferruh Yigit
2020-07-06 17:41 ` Honnappa Nagarahalli
2020-06-26 22:09 ` [dpdk-dev] [PATCH v2 4/5] app/testpmd: fix burst percentage calculation Honnappa Nagarahalli
2020-07-06 16:10 ` Ferruh Yigit
2020-06-26 22:09 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: enable empty polls in burst stats Honnappa Nagarahalli
2020-07-06 17:05 ` Ferruh Yigit [this message]
2020-07-06 19:11 ` Honnappa Nagarahalli
2020-07-07 9:32 ` Ferruh Yigit
2020-07-06 15:36 ` [dpdk-dev] [PATCH v2 1/5] app/testpmd: clock gettime call in throughput calculation Ferruh Yigit
2020-07-06 16:53 ` Honnappa Nagarahalli
2020-07-06 17:19 ` Ferruh Yigit
2020-07-06 23:32 ` [dpdk-dev] [PATCH v3 1/3] " Honnappa Nagarahalli
2020-07-06 23:32 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: fix burst percentage calculation Honnappa Nagarahalli
2020-07-06 23:32 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: enable empty polls in burst stats Honnappa Nagarahalli
2020-07-07 17:47 ` [dpdk-dev] [PATCH v3 1/3] app/testpmd: clock gettime call in throughput calculation Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca0b9e5-9808-7c2f-a818-225058e875be@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alialnu@mellanox.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=orgerlitz@mellanox.com \
--cc=phil.yang@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).