DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	David Marchand <david.marchand@redhat.com>
Cc: Liron Himi <lironh@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte epoll functions
Date: Tue, 28 Apr 2020 03:43:30 +0200	[thread overview]
Message-ID: <4cd2eaf1-d1d4-0ac1-754b-77d7ef1e18ed@partner.samsung.com> (raw)
In-Reply-To: <20200427095750.0d96a532@hermes.lan>


W dniu 27.04.2020 o 18:57, Stephen Hemminger pisze:
> On Mon, 27 Apr 2020 17:01:21 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
>> On Mon, Apr 27, 2020 at 4:51 PM Stephen Hemminger
>> <stephen@networkplumber.org> wrote:
>>> On Mon, 27 Apr 2020 13:33:27 +0000
>>> Liron Himi <lironh@marvell.com> wrote:
>>>   
>>>> Hi,
>>>>
>>>>
>>>> We noticed that the implementation of rte_epoll_wait doesn't stopped on signal such as SIGINT.
>>>>
>>>> Is anyone know why?
>>>>
>>>> If that on purpose and cannot be changed, how application can exit gracefully when using rx interrupts for example.
>>>>
>>>> Regards,
>>>> Liron
>>>>   
>>> I noticed that, submitted a patch, and it has been unmerged for 9 months
>>> https://protect2.fireeye.com/url?k=b1d79a91-ec04c185-b1d611de-0cc47a31ce4e-7c8024d7bc014fef&q=1&u=https%3A%2F%2Fpatchwork.dpdk.org%2Fpatch%2F57047%2F
>> - Indeed, there was no review nor any comment about the "bien fondé"
>> of this patch for 9 months,
>> - We don't need a new symbol, this should be fixed + symbol versioning
>> to keep current behavior.
>>
>>
> We do need a new symbol. People may want the old behavior.
Do we need new symbol and new functionality?
One can use signalfd to create a file descriptor for set of signals and 
just pass it to epoll.

-- 

Lukasz Wojciechowski
Principal Software Engineer

Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com


      reply	other threads:[~2020-04-28  1:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 13:33 Liron Himi
2020-04-27 14:50 ` Stephen Hemminger
2020-04-27 15:01   ` David Marchand
2020-04-27 16:57     ` Stephen Hemminger
2020-04-28  1:43       ` Lukasz Wojciechowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cd2eaf1-d1d4-0ac1-754b-77d7ef1e18ed@partner.samsung.com \
    --to=l.wojciechow@partner.samsung.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).