From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CF23A0542; Fri, 18 Nov 2022 11:40:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E84544021F; Fri, 18 Nov 2022 11:40:10 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id 5DC8B4003F for ; Fri, 18 Nov 2022 11:40:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qe5aDi8Ir1eGArmBjatkI+GNjICZsNvbGnF9xMF3CPZb9UhEOAk8n/vhhODmDTw+cJ0XXAcHMU1J2WOboM5Smb/JZ0XEHMjE3jAn8GdqyEh24D9Ne/e+WSTcSU9qZueffKfDrleNX58uCWt4pyFkxU7axiF2AIZGBGeADHBONIiypXUbWqv8t55ofifY1SefuNn0gbgKS5PprUF4QWQ/H1INvfTZPVCmTwab26Wqvd3e35hiILQCpY9VOStXDsSDrK38D+XrYXs5OZ/PMMY6IawWZLLaMZEOFYuSQBNik+F7uUfcRgzgx6JdSqJWTiPYIXsxpbse5147H9A4IdCKfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FxW95bNyEtIYCBD2BlPY/xTvRYzTMLrNFJddwkeEh0U=; b=maCidgckpdfCRZfKgdahqxzYaTUtyfG18wAFbnVDx947Y5fkABocZWFKL+5Y7Be3YPaTh9VQq0AfmewJ2qnTBaNznYGuF0qY6TvdUz+6+cP+hdFsey9jUXCt+sj4u2XOe6l+ElcM2Clp2VDgg/Pwy2DmdyhedYSyFohMl81fZTsyL7M+0BOBF8fojgmGpiCNYQRTFVOANJIb+oh6HMTmUyTxTARVmZV26qyx+Qm2WGQhxhSmAVI4BCkunl/SfSrCuMIXoaFjanHkd2RQWXXXVttEZMhuzLd6zqi9wLpeyK4JwPuAmJXNBarqo/q+bukeMymrXtOHJKI2HHCRa0Ja5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxW95bNyEtIYCBD2BlPY/xTvRYzTMLrNFJddwkeEh0U=; b=RDzuFLHdkpuynEVejZymYaIgUJPgkcw1Q+7BUjmff+r20XH63QibqxSfi1xxPT9pf3xbfVsp14xuKQgbMQ+AUbYF0kZLl+QeQ+4I3v/8lvHVHu6X4cUsfJa2BV4oTfEj5GMIKyNzf1FNH3eVkbPEyN4CfSbsZjou1SoXD++2eNE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5169.namprd12.prod.outlook.com (2603:10b6:610:b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Fri, 18 Nov 2022 10:40:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5813.020; Fri, 18 Nov 2022 10:40:06 +0000 Message-ID: <4cdd1d8f-69ed-a97f-32f5-65289642fef2@amd.com> Date: Fri, 18 Nov 2022 10:40:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Suanming Mou , david.marchand@redhat.com, Aman Singh , Yuying Zhang Cc: dev@dpdk.org References: <20221117085537.24372-1-suanmingm@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix action destruction memory leak In-Reply-To: <20221117085537.24372-1-suanmingm@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0411.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5169:EE_ X-MS-Office365-Filtering-Correlation-Id: 30026de2-6d76-43c2-8988-08dac951410f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cKS+OpbOPQ38Tv9HSP9sXNaa1lGFuS7/EG2KLE+gx4SHjPkkgMsiAVf4ALk3GpP5rcSTxIb7vh+qGS7HbzzDwRw7RKWn9UC+NaNoiTjZk5am5WoPKs4tRJD9unfNXe7r5pr4A7JOLpbdezYI2V+GZZ0MHppOWbT3bVN6hHgyZC0Ncbewm1WkfgF4aU3I3soXAKlHToyYJv1PQnk+SuILaqu7SL4MFpTA95AP9JgHaBsfQTEYcVOkb0gIEme7ImXAtWlaqi5CsYNxMzxp9OU0Zv9tcnygh1LIIzMLqy5jjQxyja9s3oV16WGIQmFvMvSwEt3GVQO9JntdHUM7VKAIGNe34eOvplXl1omOBzvJz2TbsA31YAsXOQivtSm4eC+ROPkYV0B6IMLNd2N8k2u8fOM8IXxhdAdlvDNL+G/UAitAmvoz4CsxcU3SyPi7ECJKhZGyDNKs/vJkLQ7f9+TyHGS1Km69QwhfwBxs6i8bj7Jsqj0cUipfJPuANpWOIP3pB2HaxPT/vo4ix5GDHh3QC+p8ZH9Z4Aw29kPWWoZkGWxeLTdxEwcoiSswABJ4SQkDwVpDP/NBNlvM383WLb6+1dQOBoKgx4NsYkzzN+GiUkn/9wLaRZjG3geUWKFvg9Q4dUYSHWbtyisHuNP3Zr/bKcBOeagNmniE8KRH4v6nnKrrgJkIanksyu1fLz6tVi8UINIYn1s2BF3ikmy8O9yP+gWOrGOgfC/Brpja4N4Qwuw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(451199015)(110136005)(6666004)(53546011)(31686004)(26005)(6512007)(186003)(6506007)(66946007)(8936002)(8676002)(41300700001)(66476007)(2616005)(478600001)(5660300002)(2906002)(66556008)(4326008)(6486002)(44832011)(83380400001)(38100700002)(316002)(36756003)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGFLZ1BuTUNpNkxrTUVUTkcrYWpvOW8xK0prcVZkZGpUUFdkdFArMHVCSytK?= =?utf-8?B?L21YczFxTG5tUXpXQjZ2cUNIOEw3NGNNSytwOC9jcVFhdkNjVjUrdGp5OEZp?= =?utf-8?B?Z2VQakdzOU9maml4OGcvL1hOdUNvVnl1VHdFcXp1QmhOaTBCQ0FlalJCdXow?= =?utf-8?B?QVRTeEtpUUQ0bEpmNTlCQ0FlK3ZyTWd2WmVqSUdKTThXR05Rc09UaENUbnVR?= =?utf-8?B?eW5WeFh6d1h3TkhnWmhrcmNDejUyRVhFT0FGZWVCUkl3Z0dwaUdnaW91c0Rz?= =?utf-8?B?NkZ2bVNNeFVMNWZqS3l3QkM0bU9lSmh4N1V1QW1JQTR5bThyNDV6YS9GNGxK?= =?utf-8?B?NEhkVUJUWTlMUm5EMjljUzZoaGFJTWNrbGdTVk16eW1hdzZ5eHh2cG9lMW9I?= =?utf-8?B?cTM2SlR5RytaQlZySEk0RDluOUpnV1pHZDNrb3kwcnR3Rm1KY2NPMy9BSHNV?= =?utf-8?B?Rk9Nd2pjNkxlQW1PbCtjemxReEdZNmNFZUtqOFVKVkszVnAydlVHT1c2N05v?= =?utf-8?B?NkZUbG5ZcklxQnFhRkJMWUpTbHhOV0RuOEhTM1Z6Z3E1bHZ0S1RTL1Rac2Z3?= =?utf-8?B?M1p6Ky8weUQ5bDY0bjBtWWs2NmZWVzZkbDlGaWl5UDh5bHQ5bHJiWVppQmhi?= =?utf-8?B?YUtvOWhYZ2dMZUozNVpGVjJnM3NmRFRQSkNmcDM4eTVhSk1wbE5sNnZBbUZr?= =?utf-8?B?ZFBTdmIxckI0TU14cW1pL0FBbmlpeHpDNW43Nm9IMUl4NHdSU1dJRmV0OVpS?= =?utf-8?B?VUIzTXlmc1pCSHFWbXFKd2czUWNVS3lHNzFHUnZZV3dPM2lZR0lJalozRUJu?= =?utf-8?B?ajh2aHJTZnRhSGpqZldhbkUzY2xOZ0RtUGZROWdIMkdOVWxSaG9uMHlPK3ZF?= =?utf-8?B?RXlTUlpPNkthNlNYT1gyQnlOZjVYNkJtUTZRbjNpbXpWZWlXV01lUUFUMXpw?= =?utf-8?B?R2V5ODJFakkwNjgxVU5jZEtzNDNBSUN6VkZ3UytySTRKSEtHelB3ci9mNFdk?= =?utf-8?B?RnpHRjJrZjhTMmZMMWJGYWUvL0g5b2tUaHdKUUsrMjhtZENyNS9ib3N0VUJN?= =?utf-8?B?Zkx1MURyZDdJZDVmQ1dDcWM5ZXFzNWVaTk9LdmxyZzBXYjNvMFJKUnNIVTVX?= =?utf-8?B?Y3JaaVMrWTB2YitoKytzZGhzUWR3ZmZFZXRvV1dTRXExeHBNQXVFK1NGT2li?= =?utf-8?B?anJrTEMwSEQ4SE5Gd0p4ckdIeG01ajlqS2R5WmhTa1JJQlBoSlE3a0ovL2Ni?= =?utf-8?B?YTJ5Y1czWVFnaE5XUWdPU2RVUi94TDREWTVkT3dPUTRTdWlTejZtSk5OUVBC?= =?utf-8?B?dVNYSFBBbUUyMkhpMDJ1Ymd0Z1JKQ2czT1ZWbE9UeklUT0ZqV3FJcXY4NDRC?= =?utf-8?B?UldTcjhVdEM2MVMvbFoxS1J2MnkwK1ZTWFJhajhPRitNRjBPYTNORjJIM09n?= =?utf-8?B?L2lMdzZkMFN0OS9RN0ZhcWsyckwvSFBEZWhoNlJnYzVtczNTdWxRSG51a082?= =?utf-8?B?NFpjSDZRVUpKbE85dkxUMDFYVXFFZkFqVk5ZWFlpNWw0QXpUWStnUDhoWnZO?= =?utf-8?B?ZXJhRG04czErOHFzUXFyd0dPMVlBS0gvQm5hSEpZZkhxUUM4ZUM4RFYwQ2lu?= =?utf-8?B?SXVrUEs2em9KZytlZGRRMGRBUVFHbm5JYm1mT1JBUXI1MWx5ZmkreHRMaVp6?= =?utf-8?B?ZEhQanYycGxlM1puVDdlb21sMUV1NER0NUgrdUJMaWlYNmdaU0VoUjl1bXFE?= =?utf-8?B?K3h2KzhaUm5BQzBrTHA1eW9OYmVodDN6RC9lVGZMZnh2NmlpandNQmd5ZlA5?= =?utf-8?B?Mnh4UFpFMzVXLzByZzFuY3pFTk5FNFkvZkh6a0tONTVIek9TT0dHMGYrbi9X?= =?utf-8?B?OHc3bGNRS1JXZDhWOStmQjByWVBqVUtGeXVjckNJVi9uOGQxWGVqYncxV28x?= =?utf-8?B?WVo3bGhreDNjZnlVeUl3YWQzSXk2RmszbWF6RDdEWkxwWEVqVHlrZnozVHIx?= =?utf-8?B?bjJtcFdtSnVCdXFsZXF2SW5iY1hCbktaazVFaUdKUmdFRjExNXlhNEY3Z1dQ?= =?utf-8?B?YkpkRmFHcU1UZnVIQXJzL2l6Q0w0cXNPRmNiaDU0Z0NiY1Zqc2llaFdSdml2?= =?utf-8?Q?nlHCyMeztuX4t004CWB9IjSuq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30026de2-6d76-43c2-8988-08dac951410f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:40:06.2570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: asVVBx1cgKEVjjZILUf5Pw9S3SlpRiWThkbiTnTPMLFBlsYO+sCb4fzw4haMWIYn X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5169 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2022 8:55 AM, Suanming Mou wrote: > In case action handle destroy fails, the job memory was not freed > properly. This commit fixes the possible memory leak in the action > handle destruction failed case. > > Fixes: c9dc03840873 ("ethdev: add indirect action async query") > > Signed-off-by: Suanming Mou > --- > app/test-pmd/config.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 982549ffed..719bdd4261 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2873,9 +2873,9 @@ port_queue_action_handle_destroy(portid_t port_id, > job->type = QUEUE_JOB_TYPE_ACTION_DESTROY; > job->pia = pia; > > - if (pia->handle && > - rte_flow_async_action_handle_destroy(port_id, > + if (rte_flow_async_action_handle_destroy(port_id, Why 'pia->handle' check removed, was it unnecessary to check it at first place? > queue_id, &attr, pia->handle, job, &error)) { > + free(job); > ret = port_flow_complain(&error); > continue; > } Just to double check, when this if branch not taken, 'rte_flow_async_action_handle_destroy()' not failed case, testpmd 'port_queue_flow_pull()' functions frees the 'job', right?