From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D443245C0A;
	Tue, 29 Oct 2024 12:48:13 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6442D4014F;
	Tue, 29 Oct 2024 12:48:13 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 0483D40144
 for <dev@dpdk.org>; Tue, 29 Oct 2024 12:48:11 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25F3013D5;
 Tue, 29 Oct 2024 04:48:41 -0700 (PDT)
Received: from [10.57.58.134] (unknown [10.57.58.134])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B11D03F73B;
 Tue, 29 Oct 2024 04:48:10 -0700 (PDT)
Message-ID: <4cffb8f1-322e-41b9-9803-d3fcbda043db@arm.com>
Date: Tue, 29 Oct 2024 11:48:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/7] dts: add support for externally compiled DPDK
Content-Language: en-GB
To: Patrick Robb <probb@iol.unh.edu>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
 =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= <tomas.durovec@pantheon.tech>
References: <20240930160204.19582-1-tomas.durovec@pantheon.tech>
 <20241021134935.1210500-1-luca.vizzarro@arm.com>
 <20241021134935.1210500-6-luca.vizzarro@arm.com>
 <CAJvnSUBBTVG0pj-fjLdATRJUztTUYaGkOy9YfVREhbZP7WG+Kw@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAJvnSUBBTVG0pj-fjLdATRJUztTUYaGkOy9YfVREhbZP7WG+Kw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Patrick,

On 29/10/2024 01:19, Patrick Robb wrote:
>     diff --git a/dts/conf.yaml b/dts/conf.yaml
>     index 814744a1fc..8a65a481d6 100644
>     --- a/dts/conf.yaml
>     +++ b/dts/conf.yaml
>     @@ -5,12 +5,24 @@
>       test_runs:
>         # define one test run environment
>         - dpdk_build:
>     -      arch: x86_64
>     -      os: linux
>     -      cpu: native
>     -      # the combination of the following two makes CC="ccache gcc"
>     -      compiler: gcc
>     -      compiler_wrapper: ccache
>     +      # dpdk_tree: Commented out because `tarball` is defined.
> 
> 
> Should this key name be extended to clarify the desired value is a path, 
> and whether it is absolute or relative?

We could amend the key name to something more suitable if we wished. The 
path could be either absolute or relative, so it doesn't matter. I 
assume you are referring to change `dpdk_tree` to `dpdk_tree_path` and 
`tarball` to `tarball_path` or something similar?

> +1 to Dean's concerns about using the tarball without --tarball flag if 
> dpdk_tree is commented out and tarball is defined.

As replied to Dean, this scenario currently works, and I have also just 
re-tested it for completeness. I need some more details to figure out 
what's happening.

Best,
Luca