From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Cc: skhare@vmware.com, Chas Williams <chas3@att.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent
Date: Fri, 20 Apr 2018 01:10:23 +0100 [thread overview]
Message-ID: <4d08acfb-57d7-a347-a772-3c268b49a3ff@intel.com> (raw)
In-Reply-To: <20180318014552.16703-1-3chas3@gmail.com>
On 3/18/2018 1:45 AM, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>
> The vmxnet3 never attempts link speed negotiation. As a virtual device
> the link speed is vague at best. However, it is important for certain
> applications, like bonding, to see a consistent link_status. 802.3ad
> requires that only links of the same cost (link speed) be enslaved.
> Keeping the link status consistent in vmxnet3 avoids races with bonding
> enslavement.
>
> Author: Thomas Monjalon <thomas@monjalon.net>
> Date: Fri Jan 5 18:38:55 2018 +0100
>
> Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chas Williams <chas3@att.com>
>From Thomas Monjalon <thomas@monjalon.net>:
> Yes, OK for ETH_LINK_FIXED.
>From Yong Wang <yongwang@vmware.com>:
> Yes and it makes sense for vmxnet3 to use ETH_LINK_FIXED.
Converted into explicit ack:
Acked-by: Yong Wang <yongwang@vmware.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-04-20 0:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 1:45 [dpdk-dev] " Chas Williams
2018-03-20 14:12 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-03-20 14:42 ` Chas Williams
2018-04-05 10:03 ` Thomas Monjalon
2018-04-05 15:01 ` Chas Williams
2018-04-17 19:25 ` Ferruh Yigit
2018-04-17 20:24 ` Thomas Monjalon
2018-04-18 16:23 ` Ferruh Yigit
2018-04-18 16:59 ` Yong Wang
2018-04-20 0:10 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d08acfb-57d7-a347-a772-3c268b49a3ff@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=skhare@vmware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).