From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0087.outbound.protection.outlook.com [104.47.32.87]) by dpdk.org (Postfix) with ESMTP id D71D9FFA for ; Thu, 28 Sep 2017 13:35:10 +0200 (CEST) Received: from CY1PR03CA0041.namprd03.prod.outlook.com (10.174.128.51) by BN3PR03MB2353.namprd03.prod.outlook.com (10.166.74.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 28 Sep 2017 11:35:06 +0000 Received: from BN1AFFO11FD038.protection.gbl (2a01:111:f400:7c10::177) by CY1PR03CA0041.outlook.office365.com (2603:10b6:600::51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12 via Frontend Transport; Thu, 28 Sep 2017 11:35:06 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD038.mail.protection.outlook.com (10.58.52.242) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Thu, 28 Sep 2017 11:35:05 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8SBZ3bW031406; Thu, 28 Sep 2017 04:35:04 -0700 From: Shreyansh Jain To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-12-shreyansh.jain@nxp.com> Message-ID: <4d0e7de5-efeb-3527-9517-292335b8752a@nxp.com> Date: Thu, 28 Sep 2017 17:15:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131510721057031021; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(39860400002)(39380400002)(346002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(377454003)(199003)(189002)(24454002)(64126003)(4326008)(54906003)(31696002)(86362001)(50466002)(97736004)(65956001)(65806001)(8656003)(85426001)(316002)(5660300001)(65826007)(58126008)(104016004)(83506001)(23676002)(93886005)(6916009)(2950100002)(50986999)(2870700001)(76176999)(54356999)(53936002)(189998001)(6246003)(33646002)(356003)(8676002)(81166006)(8936002)(47776003)(81156014)(53546010)(36756003)(498600001)(305945005)(6666003)(68736007)(31686004)(77096006)(2906002)(106466001)(229853002)(105606002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2353; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD038; 1:Vm69KMOcv2oShdXpZuV0DgI/DfwQg0icfnG+Z1xfOOUOHZQxGX20z9I1AeZFQQslCbnF6QLpnbOasPEodrbP103GGOQfDFcdVYWzKkIWOWWTyRtUT57VBuj3mdkHcE9m X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93e23466-f57f-4943-220c-08d50664f737 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN3PR03MB2353; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 3:/ilJzCnyMNz5JaCjSb+H39/BACfhpEbheiF+S5HXllxcnByiMuWCCYkcdWjiKMnmJ3uc2WJ0IkZK6wtyTuXI1lLY/QreS24OhLA0XUJL4FuWEbzJSI6nJgzs/SgfnDqs2RZn746wr2tuJBZz76h7ROHelZTZEhaiQj99nulxtJUwanzDd6N3JLovJjfvReFl6kKLMJJFUHnyCD9TLhtzVdkolpCt3lm0WaH8rjIrauWzmrXXwEG37nOSY7jQoSJJcSlqVyzCK5/J8JCRtWJt9AUHpJhUdYTxeBXFqiOSqVWb516Bf3KLH6i6ec/mwk/+zMsdXAr4/slNxYW+JvG/TRxbd4i+lywHhxny7e/87G8=; 25:4p3DB1IVm5knRwQf4btpKW7hNCsj6RZN1JSfAmdQNjYJOq8hPpNy2EU70PmUc9Ih60c+t1yrLRGbb0e4ENnXGjMBNulC5/gk5MVtMT5GlT1AwB8Sqf2m6410hjKCRPiRz7AwjfoCc9wNbXklI+H74Doq8AkeAzd15WGPyjUpp9qXjynFlGOFc9KqFylFGwaH9vQi98SoPoxztgdH+BLHZuHwIk+rsAONLwnwBYm9e0Btq1qhjFgWdGUD3CZPSU8V4M/05uZI+5WIajS3cu67E9hz4JvmzS8zbMOFxxgrhR3PlN0zJeaB0F9U0HV0v56JjXqj1zNTAml1/fiyMVLBpw== X-MS-TrafficTypeDiagnostic: BN3PR03MB2353: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 31:7HlkXyJWr73OmVbdWXCJfq60AquI2HgqEpClz15AVoNiN0i5FbRWq6OHMoBFgRJYMNdHOkiLvdcTaQwIpphP9w5b2ezrhlACGiSRj4Q/LIu2EhR44thOsKfTBTTM44KbGi+mEP0QAnGzLz8Vn5xyoWLlpILUuElWKkzsQUMG0xS6SYEJESs0GzMa0RQva4+BFvT2cS7k9XuhRTntr0dl+mQcMuHRKg03Tn3TUx6g4h0=; 4:B8ptAgGsRE+/riukHmtg+wtZXlntfAJmiMGvDoiwF/aOMOM0JpwNeBbk17ioUGi9uAZL54gmXO3LXumhkqwvS2oFJHPkatLLjcVWD4DVnwjodPBxcKZyTZ1FLAsYAWJ+EtZJtpq7M8qb7WZv8KFFLHQXBJPuzI46AGrTIZvVB/SMC5txTkxonkmmGGBvmntE5wrELbHmj0QpWRAlC4miZWwqV91xMSWIUyz9RI/+hqEllXuJxESJrr49w/8EMw4cI+qmATHvBmbe1PIYySoLb578a8gjQQHb92/s0g21wdQ= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6096035)(20161123556025)(20161123559100)(20161123565025)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2353; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2353; X-Forefront-PRVS: 0444EB1997 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIyMzUzOzIzOnRWNExqME1ZaFcrc1JOV2U0L1A0S1RHbjhk?= =?utf-8?B?eldSNXlZallyMENKYXlkZDRrck50WUZnbG10NDQveTdRNTVxZnRnVW81cTdw?= =?utf-8?B?Yjh1Qy9lSjJEMzg3SmZzWEU0Ty9ObFhVaWpSd0RLNmp6dnAwK2EybjVhbmpQ?= =?utf-8?B?V1dzSjlFSGJKTHI0aXM5ak0vT1hPZllqamNEbE1zdmdtNGNrWDJ5WjgyZU41?= =?utf-8?B?K3lVZU9RMm9qZERVR2Q1YndwV25mdWNzYlRTMVVkc0F2RVIzeEJzZHlTS0Vl?= =?utf-8?B?dGRzS0wzUHBFdHM0d2ZZc000T3pkTXFNZnZ4T0NXTFlpTHVqbXFuRTdnK2pQ?= =?utf-8?B?MS9PU2ZjMTFWYzdoMEMvR0pWeUl5eW1SQ1hyV2VnQS80UUJiZXlaQzNnVDk5?= =?utf-8?B?VW9Ib2VPUmladkQvV1Z4YWRlMFZ6WW5vdzNqSDBRSFBpTkZNWmxpSFNGS2JX?= =?utf-8?B?WENBVTZITXYwQkY4aE9WWkg1TEU2RHVQQWZjZlRFRHdZb3JrME84V3NEVCti?= =?utf-8?B?SmlwY1FmV1RVRVRsTndNTkl2TGUzM1RnOU9kNlE2Nk9tb2JHZUJweEdyaVpW?= =?utf-8?B?OHZmMk1LeVFsTWxhU29uellmVkRuYWhVbEV1U2podXBibUZyc2NFVFhBV2NT?= =?utf-8?B?eTN1ZUpKb21mR0RqT2luYXBRSExreXFnK0VUV09OdVFySllBQnFYMW43bGJM?= =?utf-8?B?V2dsUVo3TTBTVjRWZE13b096a2FIWlpCKys5VnhjY2hoQ056Q1ZlUm92MzFn?= =?utf-8?B?SmtQdzA5R1NNNnZyVXAyZmZCNXR5dlRlK1FQWGEzbG1lTjRnZWJWTlFmZXRC?= =?utf-8?B?R3VUVTdvbzRMdlZlMlc2VEZlZEUzL0VMMy9RRkVGRUVPOW14L2p6My9zY3I2?= =?utf-8?B?bkxBMVF6MFpxWWlaYWJlRUxZMXBVdStxV3BzbnF3T3oyZVRhQng5ZGk2WUNH?= =?utf-8?B?NnpTUmhPVjFtLy84dHVPOXNvWjgzMGJWV0YrQkpBbU5YSU93MVhYaGc4YVYz?= =?utf-8?B?d3o5ekVVaGpuZEJCM0g5SmRxbnNvK2NDaGpIc2ZMWC9oQmorZ2tHdzVmYUR4?= =?utf-8?B?N3ZqRkNaV1Y1bGs1L3dEM2JQaTZocWwwZ0dFN2ZyaTFxb1JkNWxybytYSEFK?= =?utf-8?B?VjJURlpycXFvSHBJZE1oV2xTQjZzcVZTdmUxcyt3N0czdFFrMHIwV0R4bEky?= =?utf-8?B?RWJiek9OeEloSC9BWlpNVzhsY0ZuUDZYbHJqdkdMRlhrc05Tczc2YzR6d21N?= =?utf-8?B?MXlpZURmTFBKbldiMHRoWDMvOFBreEl5Z3lzWjJiUlBrTXc2M014dit0Y3JT?= =?utf-8?B?MU1ucTRRNEZueEVUNDJzTEFNVnpGRUk2Zkt5ZDNpZ1RLMmNmNmpNdnc2OXFt?= =?utf-8?B?SENKTkk0Yi9wUWo0dUU5SVpEN1NxbGNoOVRDd2NnR2xTYnhxOEtkdzhyY1B4?= =?utf-8?B?b2g1TlVvWlNRQW5teDVPUnR4cVAzUUdMMTI4M1N6b3Rzbm1MdlFTeVhWZzY3?= =?utf-8?B?ckdYUmxXOU1kaWRrRHQvVkJuU24vQnF5aExmVndMTjlZTnc3MG9uOG4zemtv?= =?utf-8?B?RWRycnkrQnYrZnIwSk8rNVg1TkcyQzdWdHZ6R0ZvV2c2ZUZTdUZ3c0x6UE5D?= =?utf-8?B?K08xNGZnMWJSWWQwTWgvQXBTZitlSnhtV1hRZXNRUGJJbG5EYmlUOE1jajd6?= =?utf-8?B?WWFwcUdaU2xRdE0wSVNGdDFuVk44YU9IUFNFWlJud2Q5M2Q0T0lEb0FvSktQ?= =?utf-8?B?OC9NV21xUk1jTlNUSUpFaHdsQnRsd0VYRXhIZGcvMUEvVVNodXFyQ2E2ZzR6?= =?utf-8?B?WHNqa2YwV3h3YlpMd1ZoZG9VZUFlQUtqZlZqUmsvMEo3YU9kS3ROTjhTOUoz?= =?utf-8?B?UmRIYUtPMmhqajJtdmlwNHhlYmtOTHdvaVA2ZGU0SmR5Q1NhQ2x5MXpQV0Nq?= =?utf-8?Q?BEjQ4lpHJP/sJFdrvlsS7yyxnViGSI=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 6:+DWWzkWDs/KJBNUwUDyCaRbN5ckP0oeQtTEGA/taun47/9Rr8pAzOMvrGATXnXcAIl/sVPD+VjwPO1VRnHMY0/5cBEFI4/HJEY/u1SseJ+uAtm9hFOHypvUAe9JjqO8SaILWBhgQ8nhNc9jF7/2WOcKuLuv67NV4eJxRO2HLjsopCOlm75E/pgo+9UX/pLVpuV933Wc0+sF5s21sOLGRGh6dgvLcIH4pr+lFSE1Nb4VggcX71iB4Z8Ik0nrjNXZnTdxd9nSvgjH0N8L73fFOPtNYN12+mGmxZASwr+95cIST2E6BMtufKjS/pWDQ+hdNdYXR3ZcRT0D6sLEGiHding==; 5:+4U1LU8c4flCHA+CJmSdfHMYIPJ/TxGjKQDxdT0n61sZ13fJS40Q1oh9hCX2X/jzIpsCXRC0zUiZRWlleIi/SOc6M7pKCeCjk5NjpF4jMxqTWUFSgxTMqZOkyOIf+qYKMYgBooNWDnC5rtxTdmzxKg==; 24:yCve05ZZwQHUkP6e3Rs6QzGCb+nBADrbqKJa7LAnNzAuF2eMWu7+Hwh8bkCyz9yLZbOAmz4BSfGbBykZQRBfFHLL4THLFy+eTxoH9S/B+Qs=; 7:c6PDDnY55BTaSg2DAidPXWOb80ZRTZtDeue9K6ver433dImqKoWRRl+AMALhjFwa+QcOsMhTZUBfHDO46O2THxT7M2vtBCfVvmstMZmsk1okUwVwMBdF6PE03DtfB6R36mT76bhelgcV0mil2A3MBWgLFhegXdbEAUnpx9/Xw/P2LfudsifGXEvrZHwz0uEhYbSvUtSM3LmfG0Cu/SN7HREdmc5VCSm8HUl+au9gLLs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2017 11:35:05.5159 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2353 Subject: Re: [dpdk-dev] [PATCH v4 11/41] bus/dpaa: add QMan driver core routines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 11:35:11 -0000 On Tuesday 19 September 2017 07:48 PM, Shreyansh Jain wrote: > On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:21 PM, Shreyansh Jain wrote: >>> Signed-off-by: Geoff Thorpe >>> Signed-off-by: Roy Pledge >>> Signed-off-by: Hemant Agrawal >>> Signed-off-by: Shreyansh Jain >> >> <...> >>> +#ifdef RTE_LIBRTE_DPAA_CHECKING >> >> This is not defined anywhere, it looks this will come from config file >> in further patches, config file update can be moved to this patch. > > Its more of a debugging macro and it was introduced in later patches. > Not that I see any reason why it can't be introduced here. I will fix this. > >> >>> +    eqcr->busy = 0; >>> +    eqcr->pmode = pmode; >>> +#endif >> In the v5, taking cue from yours and Thomas' comments, I have removed a few debugging macros and combined a couple. I have also changed this to "HWDEBUG" and documented this. This macro is necessary for enabling some internally debugging configurations (like error queues).