From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m13-44.163.com (m13-44.163.com [220.181.13.44]) by dpdk.org (Postfix) with ESMTP id 0F7862BA1 for ; Tue, 22 Aug 2017 10:30:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=Qtg5U IzJT+q+rT5PeQGP0he3XyTdEO9QEeCM75WbbJI=; b=V/NoYr2n3h20fXdLmrRYk bjSqPVtRXArWxZg1fMdmjyOYFfJmwCDIhjmsXCiyQJMLWPVeOHKzC6WpjzPGODya N4mJzqOLvzU2HMaYAtoGfHvcLIc+NfNdBPdjSpZDF+ELbjarbuKhOAIVW2B0jLaC xSsEotg+BlVhxdpFTjJ1y4= Received: from zimeiw$163.com ( [131.228.104.68] ) by ajax-webmail-wmsvr44 (Coremail) ; Tue, 22 Aug 2017 16:30:01 +0800 (CST) X-Originating-IP: [131.228.104.68] Date: Tue, 22 Aug 2017 16:30:01 +0800 (CST) From: zimeiw To: "Ferruh Yigit" Cc: dev@dpdk.org X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 163com In-Reply-To: References: <2f4bdab7-9873-e293-26fd-36ef5f2d80a1@126.com> <34912f2e.542d.15e084275cd.Coremail.zimeiw@163.com> X-CM-CTRLDATA: mIWifmZvb3Rlcl9odG09MTUwMzo1Ng== MIME-Version: 1.0 Message-ID: <4d5af588.9018.15e09100fb5.Coremail.zimeiw@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: LMGowAA3P++J65tZVtScAA--.60960W X-CM-SenderInfo: 52lpvxrz6rljoofrz/xtbBUQs80laDvFqYTQACsQ X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Intel 82599ES send packets failed on dpdk-17.05.1 after traffic testing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 08:30:07 -0000 aGksCgoKbm8gdXNlIHJ0ZV9ldGhfdHhfcHJlcGFyZSgpPwoKCkkgc2V0IHR4cV9mbGFncyB2YWx1 ZSBhcyBiZWxvdywgIG1heSBpdCBjYXVzZSB0aGlzIGlzc3VlPwoKCiAgLnR4cV9mbGFncyA9IH5F VEhfVFhRX0ZMQUdTX05PWFNVTVMgCgoKLS0KCkJlc3QgUmVnYXJkcywKemltZWl3CgoKCkF0IDIw MTctMDgtMjIgMTU6NDk6NTYsICJGZXJydWggWWlnaXQiIDxmZXJydWgueWlnaXRAaW50ZWwuY29t PiB3cm90ZToKPk9uIDgvMjIvMjAxNyA1OjQ1IEFNLCB6aW1laXcgd3JvdGU6Cj4+IGhpLAo+PiBN eSB0ZXN0IGVudiBpcyBkZWxsIFQ0MzAgc2VydmVyLCBOSUMgaXMgaW50ZWwgODI1OTlFUy4KPj4g SSBpbnRlZ3JhdGUgbXkgYXBwIHdpdGggZHBkay0xNy4wNS4xIHZlcnNpb24uIGFmdGVyIGRvIHNv bWUgdGNwIHRyYWZmaWMgdGVzdGluZywgYXBwIGNhbiByZWNlaXZlIHBhY2tldHMgZnJvbSB0aGUg ODI1OTkgTklDLCBidXQgODI1OTkgTklDIHNlbmQgcGFja2V0cyBmYWlsZWQuCj4+IEJ1dCBteSBh cHAgd2l0aCBkcGRrLTE3LjAyIHdvcmtzIHdlbGwuIAo+PiAKPj4gCj4+IElmIGFueSBjaGFuZ2Ug d2l0aCBpeGdiZSBkcml2ZXI/IG9yIG5lZWQgc29tZSBhZGRpdGlvbmFsIGNvbmZpZ3VyYXRpb24g Zm9yIHRoZSBOSUM/Cj4KPnR4X3BrdF9wcmVwYXJlIGFkZGVkIGJ1dCBpdCBoYXMgYmVlbiBhZGRl ZCBvbiAxNy4wMiB3aGljaCBzZWVtcyB3b3JraW5nCj5mb3IgeW91ciBjYXNlLgo+Cj5KdXN0IHRv IGRvdWJsZSBjaGVjaywgYXJlIHlvdSB1c2luZyBydGVfZXRoX3R4X3ByZXBhcmUoKT8KPgo+PiAK Pj4gCj4+IAo+PiBUaGFua3MuCj4+IAo+PiAKPj4gLS0KPj4gCj4+IEJlc3QgUmVnYXJkcywKPj4g emltZWl3Cj4+IAo+Cg== >From ferruh.yigit@intel.com Tue Aug 22 10:30:37 2017 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A0CD82BA1 for ; Tue, 22 Aug 2017 10:30:36 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 22 Aug 2017 01:30:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,411,1498546800"; d="scan'208";a="140568160" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga005.jf.intel.com with ESMTP; 22 Aug 2017 01:30:33 -0700 To: "Hu, Jiayu" , "dev@dpdk.org" Cc: "Ananyev, Konstantin" , "Tan, Jianfeng" , "thomas@monjalon.net" , "Wu, Jingjing" , "Yao, Lei A" References: <1502333448-75976-1-git-send-email-jiayu.hu@intel.com> <1502960892-112960-1-git-send-email-jiayu.hu@intel.com> <1502960892-112960-2-git-send-email-jiayu.hu@intel.com> From: Ferruh Yigit Message-ID: <671112a6-6ac6-7476-4270-be1a0258f06e@intel.com> Date: Tue, 22 Aug 2017 09:30:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 08:30:37 -0000 On 8/22/2017 2:00 AM, Hu, Jiayu wrote: > Hi, >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, August 21, 2017 7:04 PM >> To: Hu, Jiayu ; dev@dpdk.org >> Cc: Ananyev, Konstantin ; Tan, Jianfeng >> ; thomas@monjalon.net; Wu, Jingjing >> ; Yao, Lei A >> Subject: Re: [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO >> >> On 8/17/2017 10:08 AM, Jiayu Hu wrote: >>> The GRO library provides two reassembly modes: lightweight mode and >>> heavyweight mode. This patch is to support the heavyweight mode in >>> csum forwarding engine. >>> >>> With the command "set port gro (heavymode|lightmode) >> (on|off)", >>> users can select the lightweight mode or the heavyweight mode to use. >> With >>> the command "set gro flush interval ", users can set the interval of >>> flushing GROed packets from reassembly tables for the heavyweight mode. >>> With the command "show port gro", users can display GRO >>> configuration. >>> >>> Signed-off-by: Jiayu Hu >> >> <...> >> >>> lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */ >>> @@ -434,13 +436,21 @@ extern struct ether_addr >> peer_eth_addrs[RTE_MAX_ETHPORTS]; >>> extern uint32_t burst_tx_delay_time; /**< Burst tx delay time(us) for mac- >> retry. */ >>> extern uint32_t burst_tx_retry_num; /**< Burst tx retry number for mac- >> retry. */ >>> >>> +#define GRO_HEAVYMODE 0x1 >>> +#define GRO_LIGHTMODE 0x2 >> >> Why these are not part of the gro library? >> Is the concept "lightweight mode and heavyweight mode" part of gro >> library or implemented only in testpmd? > > Lightweight mode and heavyweight mode are two reassembly methods we > provided in the GRO library. For applications, they are just two kinds of APIs. > Applications can select any of them to merge packets. GRO modes are defined in testpmd, and kept in testpmd variables, library seems not aware of these modes. What are these two APIs, rte_gro_reassemble() and rte_gro_reassemble_burst() ? Perhaps you can detail what Lightweight mode and heavyweight mode are, doc also don't have much about it. This still looks like gro library provides common API and testpmd calls these API with different parameters and calls these lightweight and heavyweight, if these modes are common use case, I believe they should be part of library. If not, instead of saying different gro modes, it can be presented as different gro usage samples in testpmd. testpmd good for testing dpdk, and good for providing usage sample for APIs, but I believe it shouldn't have the concepts coded in it, libraries should have it, that is what end user uses. > > In testpmd, we want to show how to use these two reassembly modes, so > I define two macros to present them. Users can select which one to use via > command line. > >> >>> + >>> #define GRO_DEFAULT_FLOW_NUM 4 >>> #define GRO_DEFAULT_ITEM_NUM_PER_FLOW DEF_PKT_BURST >>> + >>> +#define GRO_DEFAULT_FLUSH_INTERVAL 2 >>> +#define GRO_MAX_FLUSH_INTERVAL 4 >>> + >>> struct gro_status { >>> struct rte_gro_param param; >>> uint8_t enable; >>> }; >>> extern struct gro_status gro_ports[RTE_MAX_ETHPORTS]; >>> +extern uint32_t gro_flush_interval; >> >> <...>