From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: David Marchand <david.marchand@redhat.com>,
Ashwin Sekhar T K <asekhar@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] common/cnxk/roc_npa: fix npa_aura_fini
Date: Tue, 20 Jun 2023 11:49:38 +0200 [thread overview]
Message-ID: <4d76098c-e883-98be-89da-40fafa083d56@6wind.com> (raw)
In-Reply-To: <CAJFAV8wDoRfsjrsoSk1QV_PXcNw4hNt8dS2dV-U_mG66HK_nmw@mail.gmail.com>
Hello David,
I added a trace in mbox_get() to print when a mbox lock was already locked.
The traces were displayed when running an internal CI/CD test suite.
Best regards
Thierry
On 6/20/23 11:32, David Marchand wrote:
> On Tue, Jun 20, 2023 at 10:51 AM Thierry Herbelot
> <thierry.herbelot@6wind.com> wrote:
>>
>> Unlock mbox when an error is detected.
>
> Out of curiosity, how did you catch it?
>
> This issue could probably be caught with clang thread safety checks,
> but it is disabled on this driver atm.
> https://git.dpdk.org/dpdk/commit/drivers/common/cnxk?id=70cc4e1fed665712e68f2f45d98dda4abc6accda
>
>
--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
next prev parent reply other threads:[~2023-06-20 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 8:51 Thierry Herbelot
2023-06-20 9:27 ` [EXT] " Ashwin Sekhar T K
2023-06-20 9:29 ` Thierry Herbelot
2023-06-20 9:32 ` David Marchand
2023-06-20 9:49 ` Thierry Herbelot [this message]
2023-06-20 9:39 ` [PATCH v2] common/cnxk/roc_npa: unlock mbox in error cases Thierry Herbelot
2023-06-20 9:43 ` [PATCH v3] " Thierry Herbelot
2023-06-21 4:46 ` [EXT] " Ashwin Sekhar T K
2023-06-21 5:00 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d76098c-e883-98be-89da-40fafa083d56@6wind.com \
--to=thierry.herbelot@6wind.com \
--cc=asekhar@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).