From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD1E9A00C2; Thu, 5 Jan 2023 15:05:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDF1E42D1D; Thu, 5 Jan 2023 15:05:32 +0100 (CET) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 2124D40041; Thu, 5 Jan 2023 15:05:31 +0100 (CET) Received: by mail-qt1-f175.google.com with SMTP id i20so29942460qtw.9; Thu, 05 Jan 2023 06:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ogTUJYk2I4O+dP0CD9ZKfgtQorVSjW39zFWgCTckLAU=; b=GBX4qiuuHvktSQ3xs9ESd0X35+nqp/PXj2cUIMCHxSIz6TjqecZBHDZgVgr18b5B+S zfHjGmFebZ0qDrBRwaQk6qcvgq/Z9LfM46qXMGNgqxJEuABB3wUPZECpRg6TlK6i4HJX O66q6mg21UFmkdl1zuO1njpGcjeApAE3G9zaKONgrqpUUmimtLKpKwOKiZLIjwx06PR/ wHzIhXr4pyoGUyfa9bBr0drj/2TeZup3qeIpDxAvpJ5T6O966cUqAmYRN4F2bDl2baH2 p6680Ias2fPT5aIhY+a2POAUBmWyIEhbtf0ZF1XbB+N6HzKMaOwbi7RQp1jHu6+p6uVs jgFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ogTUJYk2I4O+dP0CD9ZKfgtQorVSjW39zFWgCTckLAU=; b=ecdu6BEqHTwnFOuEGZTAAyIRpdZX6HVYMX+LqO6RVR9udbkoNimOjRbQQFtZoiF5yr z79HR0WggyHHZ+U1PvtFStq4BKLrp/za6bXvaGQcELHZ22fjrjmRlFsFDIhC6jZX21Dp t8/wmjKTMz61Ufg+3gWJ15b7QkPq3M01tHgHqT5I/3DwzHd9F22fXQ7rSoo4s8rTyh9g 8pQ58o0tTmSV3jvxHsi+TiVGfRuai9X3QoVrD17Xlm4xjRnTOP9NymWlDgwN+lZjpkSW YrYwQ+ltFBVUckGWN3/M+eCMvOYr2vizrhhe+5J7zW/2VH0JztwVAliTVTJGx2tEJxXO w+pg== X-Gm-Message-State: AFqh2kq1VO/rQ1aLEDr+BY4loFsKAqzWd137aZusPQLJ6uCTYUY7eL2z lcLj9hXfURfZ1rEx5IEnH92rqhNnRknZ2A== X-Google-Smtp-Source: AMrXdXsaHq+/dK5yfONHhw49zpenVcbVjzOWE+oMA16zz7pYq6IIUZ/MxzjqOh21AkiSaeYK7F401w== X-Received: by 2002:ac8:7348:0:b0:3a6:89ac:caac with SMTP id q8-20020ac87348000000b003a689accaacmr66854531qtp.61.1672927530417; Thu, 05 Jan 2023 06:05:30 -0800 (PST) Received: from [10.249.158.126] (nat-216-240-30-11.netapp.com. [216.240.30.11]) by smtp.gmail.com with ESMTPSA id d9-20020a05620a240900b006f9f3c0c63csm26141762qkn.32.2023.01.05.06.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 06:05:30 -0800 (PST) Message-ID: <4d77aa17-5ea7-cdd7-fc5b-308348b2f3c2@gmail.com> Date: Thu, 5 Jan 2023 14:05:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] net/ena: fix deadlock in RSS reta update Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Stanislaw Kardach , Dawid Gorecki References: <20230105135733.4162954-1-david.marchand@redhat.com> From: "Zhang, Fan" In-Reply-To: <20230105135733.4162954-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/5/2023 1:57 PM, David Marchand wrote: > Add missing lock release in case of internal failure. > > Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/ena/ena_rss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c > index b682d01c20..d0ba9d5c0a 100644 > --- a/drivers/net/ena/ena_rss.c > +++ b/drivers/net/ena/ena_rss.c > @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev, > if (unlikely(rc != 0)) { > PMD_DRV_LOG(ERR, > "Cannot fill indirection table\n"); > + rte_spinlock_unlock(&adapter->admin_lock); > return rc; > } > } Acked-by: Fan Zhang