From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id BED851B974
for <dev@dpdk.org>; Tue, 10 Apr 2018 17:55:47 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
10 Apr 2018 08:55:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,432,1517904000"; d="scan'208";a="219290029"
Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128])
([10.237.220.128])
by fmsmga005.fm.intel.com with ESMTP; 10 Apr 2018 08:55:43 -0700
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net
References: <20180410150804.8774-1-david.hunt@intel.com>
<20180410154440.9723-1-david.hunt@intel.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <4d89308c-eadc-172a-6f00-5fb5b948588b@intel.com>
Date: Tue, 10 Apr 2018 16:55:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180410154440.9723-1-david.hunt@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix make defconfig on FreeBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2018 15:55:48 -0000
On 10-Apr-18 4:44 PM, David Hunt wrote:
> On FreeBSD, make defconfig generates the config as "defconfig_x86_64-bsdapp-",
> which does not resolve to any known config file.
>
> This fix starts by introducing a 'compiler' variable which is set by executing
> "${CC} --version" and pulling out the name of the compiler.
>
> On FreeBDS,
^^ FreeBSD :)
we get amd64 out of "uname -m", which was not handled by the list
> of checks, but which now resolves to x86_64-native
Probably should end with a period?
>
> The remaining code in the patch then takes ${compiler}, the "uname -m"
> output and assembles them all together into a valid freebsd config name,
> i.e. "defconfig_x86_64-native-bsdapp-clang"
Same here, end with period?
>
> Fixes: bce6c42c4ad5 ("mk: add sensible default target with defconfig")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
Left out my Tested-by.
--
Thanks,
Anatoly