From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA3234404F; Wed, 12 Jun 2024 17:16:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17BE842EBF; Wed, 12 Jun 2024 17:05:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id BFD7F42E9A for ; Wed, 12 Jun 2024 17:05:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204724; x=1749740724; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bci/RswR7kOamfoIt0VlBNW9AR5EieiDzJzG4Xd7pFA=; b=aPFhhb1RJsWvtlYqmmyYieepJzsFcOI7jdK2O3u1Xwf9yZnDBzBTJiat w+tkYyQBjyrXSXYbjfAJHX2AgVkAvdHx4yr+8Yy2lMueBxy15kxEOgMTq b77IfF/8lIyFUl2wmxQ+JZ5Ce/7DMU3BYifkW5F3mpHvyxwF+ild/lfk2 hUsJStokwoH0J7hDHGblWtj/5XYu0a6kKKRBP1XaQbnAdaD3rXWeTKhDY f1TdCBN/ET5IY+2WgoE5+3M+hVpqJ5bc7ocuKcgWIiQGPxLOB2PKFWUrn NAol7l/k+ZCLzUQocQZg1m26YOxdIgQTyxif0iRB3dCO86V5Rqh6xmebp w==; X-CSE-ConnectionGUID: FgjADzgURFGe+VZDTUlB4A== X-CSE-MsgGUID: TfvGa0VJR9uS5l6P33MsLA== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32459659" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32459659" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:05:23 -0700 X-CSE-ConnectionGUID: 8idE52RbRK6oRn5RMWg18A== X-CSE-MsgGUID: VdJR8yeSTfmemgbYOll+kw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39925520" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:05:22 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Ian Stokes , bruce.richardson@intel.com, Julianx Grajkowski Subject: [PATCH v2 076/148] net/ice/base: fix handling recipes when reusing is not supported Date: Wed, 12 Jun 2024 16:01:10 +0100 Message-ID: <4da3372fb312cda985e152845fa674e30491ab73.1718204528.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ian Stokes Switch recipe reuse feature caused issues on older FW which does not support this feature. Finding matching recipes was working incorrectly, what lead to resource starvation after multiple adding and removing recipes. Signed-off-by: Julianx Grajkowski Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_switch.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c index 9d576cabf6..e5930a5010 100644 --- a/drivers/net/ice/base/ice_switch.c +++ b/drivers/net/ice/base/ice_switch.c @@ -7340,6 +7340,12 @@ static u16 ice_find_recp(struct ice_hw *hw, struct ice_prot_lkup_ext *lkup_exts, hw->switch_info->recp_list, i, &refresh_required, is_add)) continue; + } else { + if (!recp[i].recp_created) + if (ice_get_recp_frm_fw(hw, + hw->switch_info->recp_list, i, + &refresh_required, is_add)) + continue; } /* Skip inverse action recipes */ -- 2.43.0