From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BE15FA05D3 for <public@inbox.dpdk.org>; Wed, 22 May 2019 18:08:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5AB64C80; Wed, 22 May 2019 18:08:25 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 3EAA92C39 for <dev@dpdk.org>; Wed, 22 May 2019 18:08:24 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id f8so2964996wrt.1 for <dev@dpdk.org>; Wed, 22 May 2019 09:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=reply-to:subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B/xiFgMbDneE3SjWUdvfIgvxPZiNNfXHLFZHSZzNreo=; b=gJGEJmxIlpdATZicFFkPdt6W6K2UlAs+vFzSKrD1WnQfqF7FxDhNl+yswmFAtMIs7B PpQFLvyqByXnum1wk4T6DDe333o5nRNc2WZCioDFBVwhYEQhQUNjwIfo9k70T/k2mxNG K6hfP/nn3EUnvHjQkdMjYYZAH3Ti0ncMHY5baOgW2jply5VDi0LV5dX7lKb8l0ZSValK 0VEDA5izw0ke5bXZNLV+Xe+xdOSxCstLMTGg7eCehy8bkiDIRQ3hQ3FmIdXL8GgLRHt9 FkHC/yV0PxbNlFEZSvntPCIyRyaFUVvhDWO5Ab1RFHjOzdCwNLjKFGeAIEibrIHjRUvX bvHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=B/xiFgMbDneE3SjWUdvfIgvxPZiNNfXHLFZHSZzNreo=; b=F8bBblSg+MiwHf1+H/uSp17Td4gim4qttx4Nm9wElJXSRhcC5DhwohJumjrJexgfN6 DL8prqV2z/PWspTyVTZ1Vs8D6QRMb7PQKAMg53vCcdNQ6ygwcpl6l2qZiH/sioi6beZY 1oNUiy29UlhUPxjZFCWYIhR+OMl744FoVHVWOEv0OozGlRYAESl6KziBDZJW583cZkep vKmZuEPu+7EqsD4WOz9w8gtGV6xgen/FLUW+FP8iT8OI4tCEfEvI/jhELqUXzS38hxzE vEWP76Bc2OiaBGVas2GZIr5RXf+umUHVDDeeSDObvwq3MEhssKnMlur2OUtJQzWqXlO9 uxyA== X-Gm-Message-State: APjAAAWZeV9YfomU3ssGL7pSwix8cdo9Sllbjz7SN2uylERcR5D68b0W WVbhKkmdmtvglJ7HZY0fk50XZQ== X-Google-Smtp-Source: APXvYqzaRgYe+jkEkJgqmBZ3pyex/JV2FwdkJmg4KsA2mYic6biqqtDLNa6neQ7GIKldIk8jxtXUpA== X-Received: by 2002:a05:6000:1209:: with SMTP id e9mr55164691wrx.205.1558541303877; Wed, 22 May 2019 09:08:23 -0700 (PDT) Received: from [10.16.0.69] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l16sm39955852wrb.40.2019.05.22.09.08.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 09:08:22 -0700 (PDT) To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org Cc: Olivier Matz <olivier.matz@6wind.com>, Didier Pallard <didier.pallard@6wind.com> References: <20190522154143.8041-1-nicolas.dichtel@6wind.com> <07c05411-51bb-2a8c-c941-bc7483683c02@intel.com> From: Nicolas Dichtel <nicolas.dichtel@6wind.com> Organization: 6WIND Message-ID: <4db07102-c4b0-2e54-634c-3dc576e8c5ef@6wind.com> Date: Wed, 22 May 2019 18:08:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <07c05411-51bb-2a8c-c941-bc7483683c02@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: nicolas.dichtel@6wind.com List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Le 22/05/2019 à 17:57, Burakov, Anatoly a écrit : > On 22-May-19 4:41 PM, Nicolas Dichtel wrote: >> move_pages() is only used to get the numa node id, but this function >> is not allowed by default in docker (it needs CAP_SYS_NICE and an update of >> the seccomp profile). >> get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in >> the default seccomp profile. >> >> Note that the returned value of move_pages() was not checked, thus some >> errors could be hidden (if the requested id was 0). >> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> >> Reviewed-by: Olivier Matz <olivier.matz@6wind.com> >> Reviewed-by: Didier Pallard <didier.pallard@6wind.com> >> --- > > I can see the check for move_pages and it's a good fix, but what is the relation > to docker init here? The patch by itself only enables handling of move_pages() > failure and adds nothing else. The commit message doesn't match the patch in > question IMO. I'm not sure to understand your comment. The call to move_pages() is replaced by a call to get_mempolicy(). What am I missing? Regards, Nicolas