From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 691001B62E for ; Mon, 16 Oct 2017 12:42:36 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id t69so1759921wmt.2 for ; Mon, 16 Oct 2017 03:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev-mellanox-co-il.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ZTgCqw0Yio4R1QP2fnOP/N+/aKhZ8RfPLI+P52yP76I=; b=sdTrsnmm3h5BgMJ96lcRLvayiSMp4ZHmmZFm6NVXppS6bJGjPCGy4nzyoS92TNeFkj GGDYVIiL793ZUJvl+2ewG3XknlzI3Bxi+d0TTqc4X1lQOR4GWXOID4mUsYWphbvygt3u U5E2h2gpsWPakAtrV9y+xVCGNdo+52fZQrQg9ioL1ykKU36V+mFW9DZhFmB4fWjrB3Td xSsUVvSxY8ZjH1Ly8YojGq/MdrPRbQJwfIAIrRmSrpVyMWD1x8VCO4oGkvrSWfpWjdrQ 85WuU8f3bkuWAnWtNQDi14U4lXw83MqHf5XgcEjEzHFBhnieFtrco7xbyWwPgCJBVlEj r2ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ZTgCqw0Yio4R1QP2fnOP/N+/aKhZ8RfPLI+P52yP76I=; b=in3E0TFNvF7fKYb/jJ3LGU/+VX/Wgm/FlHLc66J4nkMJ/87avrc65Lof8MmpDDda4v pLNIibNtVFJJWmNjj/iihWwdBpYxaImlQ1PjHyGUSHnGb+JbOr2e5aVh9C8KjyPAeg72 AUlWP9WYLsfkrQdGpHTJn4cyqVAWBA4nPmhMIG8K4Kfg7rNNS1eN6fzZqh4P3HU18rFQ mTu2u7sIgBXv3Vet1hsbC38pNJdW/1FFdMJIghAIqUQ7IfPEPImW7eAvNb3Q/3qPb5d5 HQjXGiLzTSYNWJBm4jg0NmLqqk6YJfQh82Wj9jFJqqHmHOvIbuMf1nExQ3eC/5O18KIc 8pTQ== X-Gm-Message-State: AMCzsaUjE03TdPIAWMFz+I2VUrJiCdQ7DgYkQPQBLjzQn+WE8mOtGQ4Z omtd3MP+pi40EPGzKj2db8kTEQ== X-Google-Smtp-Source: ABhQp+RUYTwN67pdLvhpr0b5KnnVh7nT26E2jZeUDFtH88uPoGWJItXzn9zTL6FELFFSHY3LKbKvTQ== X-Received: by 10.223.148.162 with SMTP id 31mr157229wrr.149.1508150549100; Mon, 16 Oct 2017 03:42:29 -0700 (PDT) Received: from [10.0.38.219] ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id s196sm9213218wmb.26.2017.10.16.03.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 03:42:28 -0700 (PDT) To: Sergio Gonzalez Monroy , dev@dpdk.org, pablo.de.lara.guarch@intel.com, aviadye@mellanox.com Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com, declan.doherty@intel.com, liranl@mellanox.com, nelio.laranjeiro@6wind.com, thomas@monjalon.net References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <1507987683-12315-5-git-send-email-aviadye@dev.mellanox.co.il> From: Aviad Yehezkel Message-ID: <4db0dd77-e85c-8082-f450-a50c61b25e49@dev.mellanox.co.il> Date: Mon, 16 Oct 2017 13:42:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 10:42:36 -0000 On 10/16/2017 12:30 PM, Sergio Gonzalez Monroy wrote: > On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote: >> From: Aviad Yehezkel >> >> Seems like transport was broken for a long time > > Commit message needs to be improved. Just mentioned what is wrong or > how do you fix it. > Given that it is a fix, you should start the commit title with "fix > ..." then also add the 'fixes' line with commit that added the bug. > That way you can easily see since when it was introduced. > > Thanks, > Sergio Will create such commit messages for future fixes as you instructed above. I will remove this patch from next version of fixes since there is a similar fix already provided by Tomasz Duszynski which I will review. Thanks, Aviad. >> Signed-off-by: Aviad Yehezkel >> --- >>   examples/ipsec-secgw/esp.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c >> index 70bb81f..56ad7a0 100644 >> --- a/examples/ipsec-secgw/esp.c >> +++ b/examples/ipsec-secgw/esp.c >> @@ -306,8 +306,8 @@ esp_outbound(struct rte_mbuf *m, struct ipsec_sa >> *sa, >>                   sizeof(struct esp_hdr) + sa->iv_len); >>           memmove(new_ip, ip4, ip_hdr_len); >>           esp = (struct esp_hdr *)(new_ip + ip_hdr_len); >> +        ip4 = (struct ip *)new_ip; >>           if (likely(ip4->ip_v == IPVERSION)) { >> -            ip4 = (struct ip *)new_ip; >>               ip4->ip_p = IPPROTO_ESP; >>               ip4->ip_len = htons(rte_pktmbuf_data_len(m)); >>           } else { > >