From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DD18E7CDC; Wed, 26 Sep 2018 09:55:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 00:55:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,305,1534834800"; d="scan'208";a="260328738" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga005.jf.intel.com with ESMTP; 26 Sep 2018 00:53:48 -0700 To: "Wang, Xiao W" , Kevin Traynor Cc: "Ye, Xiaolong" , "Bie, Tiwei" , "dev@dpdk.org" , "stable@dpdk.org" References: <20180910110531.138449-1-xiao.w.wang@intel.com> <20180914012517.44977-1-xiao.w.wang@intel.com> <57299da3-af0a-01a1-d4f5-0fbe8b9ce0be@redhat.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <4dc9c3b5-e4ad-463e-8634-064a6e4928a0@intel.com> Date: Wed, 26 Sep 2018 08:53:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 07:55:12 -0000 On 9/26/2018 1:12 AM, Wang, Xiao W wrote: > Hi, > >> -----Original Message----- >> From: Kevin Traynor [mailto:ktraynor@redhat.com] >> Sent: Wednesday, September 26, 2018 1:16 AM >> To: Wang, Xiao W >> Cc: Ye, Xiaolong ; Bie, Tiwei ; >> dev@dpdk.org; stable@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready >> >> On 09/14/2018 02:25 AM, Xiao Wang wrote: >>> If the device is not clearly reset by the previous driver and holds >>> some invalid ring addr, and the relay thread kicks it before HW is >>> properly re-configured, a bad DMA request may happen. >>> >>> Besides, the notify_addr which is used by the relay thread is set in >>> the vdpa_ifcvf_start function, if a kick relay happens before >>> vdpa_ifcvf_start finishes, a null addr is accessed. >>> >>> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") >>> >> >> Looks like this should be in stable branch too. Can you confirm? > > Yes, they should go also into stable branch, thanks for the notice. "Cc: stable@dpdk.org" already has been added while merging next-net Commit c5ea24905585 ("net/ifc: do not notify before HW ready") Thanks for checking.