From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by dpdk.org (Postfix) with ESMTP id D64312B9E; Fri, 22 Feb 2019 02:52:32 +0100 (CET) Received: by mail-qt1-f194.google.com with SMTP id o6so859948qtk.6; Thu, 21 Feb 2019 17:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=txd+cg/GqzJwkcCnVKJ44BQOtY90tKp8mQcQ7kF6/lA=; b=mSWV6Xh0osJNTPneoqwkC1Oni2gDrDtz32gQ/Zq3iK77zNSlhbtepbGxHq++DGeGmj QPR7mmZe5w/HfL+bxxK9Jc8xRcRggfDaUNdfo8m0e/fEIiPVCntGIhEFcIo1KZUn0POr 4xpFwWYjLwCx7IbhAul2v6fhVobrpiunMSeBwuBLWbpt7Ao5bGTAYBbcGVFbVzNNZMBa UVrZV7gXNkFWoIwIMi97XmQ1Tk1vywd9tAmWSxsNIIinADx+lcVB2FCPETEO4lQWW7Pr coNcs+jYGYMSoSH8CUiZ0GI6rGmdNRasnU4epI74uXLHiZIenjjMalRfdZS/A+nnJVN9 IjGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=txd+cg/GqzJwkcCnVKJ44BQOtY90tKp8mQcQ7kF6/lA=; b=beKvWczWBluzdjAaFIw5wkM8RVI28kyZLCgn++wEiXCfxk48PdJFBKwlBJATD4Hp+q T2olFp/mvrr4BITe62g7e3qLKvugMiW5j2C1Bu+tWtXkqoAu77FbMyI7Mkji1ssQe7ug LY33BkMXenVxjml3e89dQRZ3ak8Odxwkr8rXcCPEeMiEAnylvCJt4TQAGnh3/8NxqNzv chz9KnV36sH4MirVAiNF9qL6ibFVeyb9GQBehef/Y+RM3LEkF3vNGwU2RS8bABBIefmk XN3Yx2jNL1dirgw5R3ePFBx8UZyAViGXCLZWVcn9W+rKOI1QXxUd9AfxKygvszG8B0Al U3lg== X-Gm-Message-State: AHQUAubu0jyB0oowiCHR+gzcvj2AnNksfxJolp1uDLnc0sK/LZpasM1t dXZ4I54+gIk6wADm7PVSU+sGN8rB X-Google-Smtp-Source: AHgI3IZPyNsY2FJvcn5JIJxa9RZASjSanRPlHi+oOPUoaLyYGkXdgRulzFo31VHR+rmKD+CkEEhEjQ== X-Received: by 2002:ac8:803:: with SMTP id u3mr1217967qth.108.1550800352022; Thu, 21 Feb 2019 17:52:32 -0800 (PST) Received: from [10.29.45.45] ([164.106.75.254]) by smtp.gmail.com with ESMTPSA id 41sm58124qtm.71.2019.02.21.17.52.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 17:52:31 -0800 (PST) To: Hyong Youb Kim , Radu Nicolau Cc: Ferruh Yigit , Hari Kumar Vemula , dev@dpdk.org, "Pattan, Reshma" , JananeeX M , Declan , stable@dpdk.org References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com> From: Chas Williams <3chas3@gmail.com> Message-ID: <4de12ce5-fda5-520c-22ea-d693c5b0c2cd@gmail.com> Date: Thu, 21 Feb 2019 20:52:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 01:52:33 -0000 On 2/20/19 10:16 AM, Hyong Youb Kim wrote: > On Wed, Feb 20, 2019 at 02:56:36PM +0000, Radu Nicolau wrote: >> >> >> On 2/20/2019 12:33 PM, Ferruh Yigit wrote: >>> On 2/18/2019 3:58 PM, Radu Nicolau wrote: >>>> >>>> On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: >>>>> test_alb_reply_from_client test fails due to incorrect active slave >>>>> array's index. This was due to invalid active slave count. >>>>> >>>>> Count of internals->active_slave is not updated even when active slave >>>>> is deactivated. >>>>> Hence active slave count always keeps incrementing beyond the actual >>>>> active slaves. >>>>> >>>>> Fix is to set the internals->active_slave to starting index 0 whenever >>>>> it exceeds the number of slaves in active slave list and also update >>>>> the active slave count during slave de-activation. >>>>> >>>>> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Hari Kumar Vemula >>>>> --- >>>>> >>>> Acked-by: Radu Nicolau >>>> > >>> Hi Radu, Hari, >>> >>> There is another bonding patch, can you please check how related are they and if >>> are these fixing same root cause: >>> >>> net/bonding: avoid the next active slave going out of bound >>> https://patches.dpdk.org/patch/49573/ >>> >> Hi, it's a similar fix for the same root cause, but this one covers more (or >> all) situations that can cause active_slave to go out of bounds. > > If it covers more cases, please go with the new patch and drop mine. I > just want to see the issue fixed :-) Yes, it does cover a few more cases. There really isn't any coordination between slave activation/deactivation and the rx/tx burst routines. So checking at the beginning or the end of the various routines is about the same. > Thanks. > -Hyong >