From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E204743AA8; Fri, 9 Feb 2024 16:00:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B816842E64; Fri, 9 Feb 2024 16:00:13 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by mails.dpdk.org (Postfix) with ESMTP id 58ACD42E64 for ; Fri, 9 Feb 2024 16:00:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDHeGAUtucCMgWIzsj4mXTnnSXsZ3rxLMheg0Ot/qXq4OarbWsk8eT4OyUpRl1zWRki8+UpkOdUwJbN1fi9k+CWcFsh6WGmNBayX4wXzgKj4ov2Oclc0kcmery98cHBwsU462Ad1AFDtPkhEg2wfR3m0PQ808dlo9/KtO6T12xh5+GBBqEEzmr+SIujMAY6lZxcJ+XpM/+4u9sMado2HYTwCs/9pNJgANlbTvvmXkh4KMaouaBc/rWCOcR8vwcEj2ukoDq57voTi9d7fJ0ep3JGE2YmCJ+V1IYK05j3HZzRyog1sT0d9EvcCk1ntQ+atsKSfPjBo0XusGYOnTbG8xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vexn4nJhiofSy1y2aKYZrK429ylC9ZGjcm+P1+1s+6g=; b=eGCKMWGWxNabUqjNw2+aGTKgVj4D9sHXOP6bOG3eQ7IOZJ4dusEr7wYrmzcBybc+mgJH8IpETA+RikUdfGKExNPiAa8U0LJEdKDkDH8Mms6Zepu1uaKT4Z7aS9juWto+PShbBpvjy8EINx21JOVwRgjrWO4fhEPAFCZoAbjRTosa5wQvMQSfoFzi/dgZ8AFeFdmOj0lNl+ti2xlYlOQoFpykZE+PAswjIvnW5G/4Fq2u8feJW5XPWAHeuymLlKTaSRLmwvlHxGvrCVsahhBkcvmx9rx4CU8pdYu86MdByGqVx+0gEjapGHhwEgnoOeCyZ5Nlqiy7xFcldzK8KBKF6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vexn4nJhiofSy1y2aKYZrK429ylC9ZGjcm+P1+1s+6g=; b=cEhcVitgx75uPGkxmU979Vonr8Kptf4ETfr5jtS3CgUuiSyskalZjq97Jn0dh4Ui2GuhyfFhYnTUvDIwF18xdXuynjDlCbPyAq0lMPVlcLTKP32tmledDISq+Fz+isQ+oZ2ONbJnSBMaEMWgPLJ3bkl/pWd6xwimGyZzjEhcoYM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6907.namprd12.prod.outlook.com (2603:10b6:510:1b9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.34; Fri, 9 Feb 2024 15:00:10 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Fri, 9 Feb 2024 15:00:10 +0000 Message-ID: <4dfd536b-4f57-4d56-b864-a7c42c0fd746@amd.com> Date: Fri, 9 Feb 2024 15:00:05 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: add size parameter to raw_encap action Content-Language: en-US To: Gregory Etelson , Dariusz Sosnowski , "dev@dpdk.org" Cc: Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang References: <20231026073047.300888-1-getelson@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0681.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6907:EE_ X-MS-Office365-Filtering-Correlation-Id: 8399ebb4-a159-4f35-6ac9-08dc297fcf76 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WSmLK3qOdG6NY3mxwbTGXVEBW95Lkt9xxM5ZOBXMESQhXBz1DSIetlbbMvRMoEOCcVDknBCBCHaVYGscQd5s7cFcmkhB1zLm8bavep86BXP2iGlw2iASLikDVcYr9JzGwEz9m18bMRJKGKdJRnvRHwhh2NMRCw/cUNrqyZDYLaWnTMDqiZPlkOoM8MYzTG8iQZ4UomreC2snfEDsTombHDdLm6pHFVy/GjLH8bnMtIBVkhw6+FEFp8kuGzg0/6yP1TjAgYbcd9kG+Y6JuiN5pJ6vEiEVEz+2Vx8o0sifwH5ToIX/8e6RRfhgvyC7RcvlYr2ofN3ZC79lohrBQHu7O4WU7MoL3oHq3f4mrCzF5jk+5d1Nh9MkNNNckLEMdtGC5uJ6uLlcBih5JqOMJPXXxqVCoTpTFjfOa3qMzIBmor1Yn8kx4wR7TtS1tXMIMzHpUNbzzpeqKBMeoIr0ndSBIsVeJHaLIAZoAi5fz0t31yqO8lbjU6UaWzeG760v4y/67mW2XQZ4uBA99rBAUM/E7MGCBojrG9h6ij1SnC9UBrVgMj+NIMQcR7A5yYviNMcy X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(346002)(39860400002)(366004)(376002)(230273577357003)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(31686004)(478600001)(31696002)(83380400001)(6486002)(66476007)(53546011)(6512007)(36756003)(41300700001)(86362001)(26005)(2616005)(4326008)(66946007)(5660300002)(8936002)(54906003)(6666004)(44832011)(8676002)(2906002)(110136005)(38100700002)(66556008)(316002)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXl4VExWQkI5ZVlLNUtmNlFJNVI5S3BWU3ZFeFVmOS81RFp2U21ObFdQcnVp?= =?utf-8?B?dWlCNFhBcjM1OUxQQzh4anBwVXNFd2dFNlViZExLTnBVQkVtMDlGV2cvU2Nh?= =?utf-8?B?WWJnMmR4c2VadnhHeUdkR3cyVFhKZjhjN0NDdzNFTGZScmMwNnpSN3lkQi9U?= =?utf-8?B?TzFneVZlVFJrdkZ2YTd6c3ZRMHZ2UWR1aFhkVElYYkU2TnRSUjgzNEltZXlK?= =?utf-8?B?bE0vU1c1WjNSUDR2K0xLSEdtMWg1NVYvNWdRMTZhUmRoSktZMmZJcmpEWTNt?= =?utf-8?B?RDloWm53R1I0QVFQckdHSnJNYnh5KytMcEhkVlU3bzJ6RkVoNnJyWFRTcUQ2?= =?utf-8?B?dURXekdpQWUvYkJ4TU1XU0tIbFVEaUJROU1hTVU1MmdiZ1JSZlpCeDk4V2pG?= =?utf-8?B?ZCt4MTFSL2Q2czFWQnQ5WGxUWlV4L0JVcysvaGlNa09NS3FEWnVEeEtYOVJK?= =?utf-8?B?OEFtUlQ0eG5yQy8yR2I5WWlNcHJmZVZYa1JIWWovaVo4Z1RteEJTeWIvc3FW?= =?utf-8?B?WWREcDRyMTZrMXlBNWR3dUVlbEVObEIxK2RCTVVVeGVGRVZuWjNuRmJtalE1?= =?utf-8?B?MjlxNmp6THAvb2d4dHFJN0g1RjNoUmpZY0pueFFncngrSzcxcmVONDZmTmRo?= =?utf-8?B?MnRXTE5DUXBBeDdXV3NFc1ZONFB5RGNnd1JRUUlScHA2cTE2RzZmTU5IajJF?= =?utf-8?B?VVMxZURLWWJYMDJwcXd6ZDZlRUxFZndkQ1luc2Q5ZEJDZThtU1A3UzN4RXNM?= =?utf-8?B?U0daUGlnM0dhYXc3YXJlTHJnTkJKQTdKVTdBbjQzMWtIMDE0dDBjUFdCVWhq?= =?utf-8?B?NnNWRFBlc1ZYbHlUTFM3dExQUHMvZ3Y2V2VOcnBMUTd2dW1LS3cyYWdaaThX?= =?utf-8?B?T2xESWxxb3lrQSs5bDJ2WUo3eSs1WTNuaFdiWDJ2S21rOVI1RmxYQWVKbmZZ?= =?utf-8?B?b0JpNXdEZ09CeUt2akRDVGZnaE52amJEc3grY3NwRmFnc0plVlpoL2xWc3Fv?= =?utf-8?B?Qy9MQ2VhZGZ3T09YRXhDNnVSbCswN3htVHQybzloT0ZURUt1YUJMS3NBaDYy?= =?utf-8?B?Z2E5RG9SK29PNjRxc1ZXR3NuMkRiQ1huV2h3SGMwUUpWcmVFRXRnWm1IcDRa?= =?utf-8?B?TTdQSG9Xb1UrYlo2R2dYcksvMVFpZ0hBZ1ZGY3hqNkQvVFhINHJLZWFpT280?= =?utf-8?B?Qll2cHp4WmE5bWRGVVMvTm5vdC9nK3g2THQ5ZnVoNG52eFFDL0lwejFvRW00?= =?utf-8?B?Z3dGYXJSZmptQ2djdU9xVTJiZ0k4OXBPZm0vd2RVdnZWeW5vUEJ3M1JwRVFN?= =?utf-8?B?by9DbTBwYlMrLzRTS2lJQ2lXWThqUkZBY2hDY2pxK1BINHJkZXJKanRVRUV6?= =?utf-8?B?Z21lREN5WDNhRkFzc3lIWUMybjVMNjBHK1l4RmFPWjJMeERlbEt2bk13SXBR?= =?utf-8?B?OHF3dm9jdEJ6NThRZElnUEVPU1BTVUw4NTFoUUJvUWNVTHVxNUlNbkYzWWlS?= =?utf-8?B?dHlNU3JjaVdGcE5oUlV4UDBZYmlOWFBkcU04cHhDKzBBVjIyRHlad3BDb1hV?= =?utf-8?B?TmcvekpySTFUOHZwYlVGU0VzemlzQUMwa2ZvQU1WZVZ4a2diME44TU1qNm1R?= =?utf-8?B?RmJ1Z0kwa2kwZ2YyYzVKK0IwV0krNjh0VUdIQnBiNzhKTDdFb3hwZDdsMVk1?= =?utf-8?B?MmlXRC9UanduNHY3alRvNmw0TzdEa2tEK0MxZEFldTMzUmk0NUM2NnZUM2JB?= =?utf-8?B?bnk1NkI5bzdraTJ2bFpBME9zM3k3RWZ4dmZFYnoza015MXd0VlB3R0tKNjVx?= =?utf-8?B?K3EwSWJMTGVxZDhidCtxL3FVaXZEYnNDVW1qcGkzUlI2YUszKzNJZU82V3Vl?= =?utf-8?B?dXFEQ0xNTU1id2p6U1htT0czeGVqSXZwaS9aZ2FKV1RxTzlmUHVxT1duMmo0?= =?utf-8?B?aWE1am9BUk9WYmdBUGkvRlJGbHNZRU9abkFYYmxra0JhWkRMWk1QZHJ2cmJ1?= =?utf-8?B?VmxKM0NkbG1zYUg1d0EvU0kxa3g0cndFZUhVRytKWGl5dHpDeHB2TWlMNDMw?= =?utf-8?B?eGVvWHEwc08rNFlqUkNXZHhLM2Ryam12RCtWN3c2MVNzdjNxalFJQllobWU4?= =?utf-8?Q?t3Z8M4+d7R05Yxk+Djp00wCcQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8399ebb4-a159-4f35-6ac9-08dc297fcf76 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:00:09.9683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MD70BXs2ibRSdajl/0YIXbeLIELaUWLAcR1W7ShO3f0zP1qLhCdDiTU5UsEt8Y4J X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6907 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2024 2:01 PM, Gregory Etelson wrote: > Hello Ferruh, > > The patch did not fix an existing issue. > I remember it is for protection against similar buffer overwrite issue, not exactly for that specific issue. > It was proposed the code improvement. > Let's drop it for now. > Agree, I will drop. > I'll post a general solution in the next iteration. > Ack, thanks. > Regards, > Gregory > ------------------------------------------------------------------------ > *From:* Ferruh Yigit > *Sent:* Friday, February 9, 2024 15:55 > *To:* Dariusz Sosnowski ; Gregory Etelson > ; dev@dpdk.org > *Cc:* Maayan Kashani ; Ori Kam ; > Aman Singh ; Yuying Zhang > > *Subject:* Re: [PATCH] app/testpmd: add size parameter to raw_encap action >   > External email: Use caution opening links or attachments > > > On 2/9/2024 1:43 PM, Dariusz Sosnowski wrote: >>> -----Original Message----- >>> From: Dariusz Sosnowski >>> Sent: Friday, February 9, 2024 12:04 >>> To: Gregory Etelson ; dev@dpdk.org >>> Cc: Gregory Etelson ; Maayan Kashani >>> ; Ori Kam ; Aman Singh >>> ; Yuying Zhang >>> Subject: RE: [PATCH] app/testpmd: add size parameter to raw_encap action >>> >>> Hi Gregory, >>> >>>> -----Original Message----- >>>> From: Gregory Etelson >>>> Sent: Thursday, October 26, 2023 09:31 >>>> To: dev@dpdk.org >>>> Cc: Gregory Etelson ; Maayan Kashani >>>> ; Ori Kam ; Aman Singh >>>> ; Yuying Zhang >>>> Subject: [PATCH] app/testpmd: add size parameter to raw_encap action >>>> >>>> Testpmd always provides RAW_ENCAP flow action configuration with encap >>>> buffer and the buffer size. >>>> That implementation does not allow to create non-masked raw_encap >>>> action in the template API actions template. >>>> >>>> The patch adds the `size` parameter to testpmd `raw_encap` action >>>> configuration. >>>> Testpmd can create non-masked raw-encap action template and specify >>>> encap buffer during flow creation. >>>> >>>> Example: >>>> >>>> # total data size is 50 >>>> testpmd> set raw_encap 0 \ >>>>          eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01:aa / \ >>>>          ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / \ >>>>          vxlan vni is 1 / end_set >>>> >>>> testpmd> flow actions_template 0 create ingress \ >>>>          actions_template_id 50 \ >>>>          template raw_encap size 50 / jump / end \ >>>>          mask raw_encap size 50 / jump / end \ >>>> >>>> tstpmd> flow queue 0 create 0 template_table 0 \ >>>>         pattern_template 0 actions_template 0 postpone no \ >>>>         pattern ... end \ >>>>         actions raw_encap index 0 / jump group 1 / end >>>> >>>> The new `size` parameter is mutually exclusive with the existing >>>> `index` parameter. >>>> >>>> Signed-off-by: Gregory Etelson >>> >>> The following sequence of commands results in "Bad arguments" error, but I >>> think it should be accepted. >>> >>> testpmd> port stop all >>> Stopping ports... >>> Checking link statuses... >>> Done >>> testpmd> flow configure 0 queues_number 4 queues_size 64 >>> Configure flows on port 0: number of queues 4 with 64 elements >>> testpmd> port start all >>> Port 0: B8:CE:F6:7B:D8:E0 >>> Checking link statuses... >>> Done >>> testpmd> set raw_encap 0 eth src is 11:22:33:44:55:66 dst is >>> testpmd> aa:bb:cc:dd:01:aa / ipv4 src is 31.31.31.31 dst is 63.63.63.1 / >>> testpmd> udp src is 1 / vxlan vni is 1 / end_set flow actions_template 0 >>> testpmd> create ingress actions_template_id 100 template raw_encap index >>> testpmd> 0 / jump / end mask raw_encap index 0 / jump / end >>> Bad arguments >> >> I bisected the tree, and it appears that this issue is not caused by this commit, but it's an existing problem in testpmd. >> The root cause of "Bad arguments" is the fact that when parsing function for raw_encap index is called, >> parse_int() is called with size == 0, but raw_encap index size is sizeof(size_t). >> This causes a failure in validation introduced in commit 913b919906da ("app/testpmd: add size validation to token parsers"). >> >> The same issue appears for other cases where parse_int() is called with size == 0 e.g., parsing RSS queues in RSS flow action. >> I'll provide a patch for testpmd which addresses that. >> > > Hi Dariusz, > > I merged that patch recently, and it is still not merged to main repo, > so we can drop it from next-net if required, instead of having a fix on > top of it. > > That patch is because of a defect that overwrites some memory, and side > impact you mentioned was not expected. > Can you please sync with Gregory about it first? >