From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1054FA034D; Mon, 14 Mar 2022 11:32:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64DFD41152; Mon, 14 Mar 2022 11:32:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D2185410EF for ; Mon, 14 Mar 2022 11:32:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647253963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XSNSYYDslfPvvfAX9lumwoqlqn93jFLbuqlFJFV/6I=; b=b5+VSVgoMISgL5sTxtuJ7DNTi7fR5gjLz+Wg5YLNgPmLCqtLCoYg+UrtsiRwlJue9wJM6b K4E5csw/MWLDxSp4cc0RH3seN3ZfCVN/h7i8GfLYsIEwEI66OEO91sBCRB/q3rM+oXomUR iYO/nGwh+hxyQZ0cW224GGycwC1afKM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-eRQiHAdKOWew2U4huG7KPw-1; Mon, 14 Mar 2022 06:32:42 -0400 X-MC-Unique: eRQiHAdKOWew2U4huG7KPw-1 Received: by mail-wm1-f71.google.com with SMTP id 20-20020a05600c231400b00389886f6b23so6853817wmo.6 for ; Mon, 14 Mar 2022 03:32:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=6XSNSYYDslfPvvfAX9lumwoqlqn93jFLbuqlFJFV/6I=; b=XBgoLyOdW4N2Akr5J19igBujV9Rgmu4GwU06kDoOQyu3yn6CGPItTCKE3FmcrPnDpi dRUjhjTcSdIk9Ci2RmwS1zQOxKbpD7mTuZQZH2thMNuojN1+VV9NM+dOXgI2uNlJ6Vgy IROntI5nYlZ5rWV30M/e/G74VL5gj+pNdmpwmPsprX1SyvIuOAEp6fKJJVovrG0uYlRl sSpZJXjm1NE+aRfTmu8AeuCKHPtq1MNdF2OJJ2b3uCkbYwRS1dNoo1Q+4I8iwXj29vhX RZoFVHw5KcZasSDJj5kokNSiK9o4W7klMN0hvY1+VNXqFQJRo7Fue7o6XYscuNVGneB4 WRnA== X-Gm-Message-State: AOAM531fMTgNQ8OefAKKrxJOIoW6uL0sYIG/KDBEShdBUYTegWpHbQ2t ir6OrICZA+iRkTTn1A7K5A7TwFlwdwPaq1zWNpWcBnqOzc38k90wN+HLNL6hvZQEkqD1N7jQ9QS hStE= X-Received: by 2002:adf:8063:0:b0:1ef:78e3:330 with SMTP id 90-20020adf8063000000b001ef78e30330mr16120782wrk.424.1647253960871; Mon, 14 Mar 2022 03:32:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJN0ngWvB7Ur2Jn//cPMNagXYMueGzdjy/1Y0a+UxFHdRkfTVrRMKqRzZL2oSA6BFRXSg+qg== X-Received: by 2002:adf:8063:0:b0:1ef:78e3:330 with SMTP id 90-20020adf8063000000b001ef78e30330mr16120762wrk.424.1647253960642; Mon, 14 Mar 2022 03:32:40 -0700 (PDT) Received: from [192.168.0.36] ([78.18.23.103]) by smtp.gmail.com with ESMTPSA id q125-20020a1c4383000000b003899720641dsm18315593wma.30.2022.03.14.03.32.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 03:32:40 -0700 (PDT) Message-ID: <4dfde108-70ff-d916-4b42-5048d1a82042@redhat.com> Date: Mon, 14 Mar 2022 10:32:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Megha Ajmera , dev@dpdk.org, john.mcnamara@intel.com, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, sham.singh.thakur@intel.com References: <20220314095916.53574-1-megha.ajmera@intel.com> From: Kevin Traynor Subject: Re: [PATCH] Revert "sched: enable traffic class oversubscription unconditionally" In-Reply-To: <20220314095916.53574-1-megha.ajmera@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 14/03/2022 09:59, Megha Ajmera wrote: > This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e. > > When enabling TC OV unconditionally, it is observed the performance > drops by ~20% hence reverting this commit. > Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription unconditionally") > Signed-off-by: Megha Ajmera > --- Even though there is already a reference to the commit, it is better to add the DPDK style 'Fixes:' tag too for consistency and stable maintainers. Thanks.