From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id C209E379B
 for <dev@dpdk.org>; Thu, 23 Feb 2017 11:47:11 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga105.jf.intel.com with ESMTP; 23 Feb 2017 02:47:10 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,197,1484035200"; d="scan'208";a="228770203"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137])
 ([10.237.220.137])
 by fmsmga004.fm.intel.com with ESMTP; 23 Feb 2017 02:47:08 -0800
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>, dev@dpdk.org
References: <e9947d692913e91d1dc78b35ec1d9adb3df188ca.1487430782.git.gowrishankar.m@linux.vnet.ibm.com>
 <e7e627fcac568d2743d3dd3baea2e473782efe6b.1487824425.git.gowrishankar.m@linux.vnet.ibm.com>
Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>, Helin Zhang
 <helin.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>, Pradeep <pradeep@us.ibm.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <4e0b3481-cc3f-fe2a-1b51-239a1282d392@intel.com>
Date: Thu, 23 Feb 2017 10:47:08 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <e7e627fcac568d2743d3dd3baea2e473782efe6b.1487824425.git.gowrishankar.m@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v4] i40e: implement vector PMD for altivec
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Feb 2017 10:47:12 -0000

On 2/23/2017 4:39 AM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> 
> This patch enables i40e driver in powerpc along with its altivec
> intrinsic support.
> 
> Changes:
> v4 - docs and config update.
> v3 - minor corrections for coding style standard.
> v2 - minor corrections for gcc strict aliasing and coding style standard.
> 
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> ---
>  MAINTAINERS                                 |   1 +
>  config/defconfig_ppc_64-power8-linuxapp-gcc |   1 -
>  doc/guides/nics/features/i40e.ini           |   1 +
>  doc/guides/nics/features/i40e_vec.ini       |   1 +
>  doc/guides/rel_notes/release_17_05.rst      |   3 +
>  drivers/net/i40e/Makefile                   |   2 +
>  drivers/net/i40e/i40e_rxtx_vec_altivec.c    | 654 ++++++++++++++++++++++++++++
>  7 files changed, 662 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/i40e/i40e_rxtx_vec_altivec.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 24e0eff..8da7573 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -166,6 +166,7 @@ IBM POWER
>  M: Chao Zhu <chaozhu@linux.vnet.ibm.com>
>  F: lib/librte_eal/common/arch/ppc_64/
>  F: lib/librte_eal/common/include/arch/ppc_64/
> +F: drivers/net/i40e/i40e_rxtx_vec_altivec.c

Overall patch looks good to me, I would get it.

But this patch adds a new responsibility to "Chao Zhu", I believe this
requires an explicit ACK from him.

Thanks,
ferruh