From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21DAFA04DD; Fri, 20 Nov 2020 12:24:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EF7D4C90; Fri, 20 Nov 2020 12:24:12 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 290563B5 for ; Fri, 20 Nov 2020 12:24:09 +0100 (CET) IronPort-SDR: huIGV6zP3xxfsAiSSk0GTYC5Vn9V2/rsnJAo+2rxdMOUHCh9/qNs5kjZ3e8YGVAVgpGHh1q+aN iwOA0+Asy+jg== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="256165534" X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="256165534" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 03:24:07 -0800 IronPort-SDR: GwtH0zcb6ZkiIg3ZO1S00kmBzZbWMroiPRdNsXRMCSpLAzg0XavNfTWFepcx8MCw9h6OLm1yyF MjtA1toUydKA== X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="477194408" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.192]) ([10.252.18.192]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 03:24:04 -0800 To: Raslan Darawsheh , Dekel Peled , Slava Ovsiienko , Shahaf Shuler , Matan Azrad Cc: "dev@dpdk.org" References: <8e069ae0fd8b042051a81ee1227ac50e7d841200.1605691382.git.dekelp@nvidia.com> From: Ferruh Yigit Message-ID: <4e28bcba-3ccc-1d81-9bb8-a23ce1d7aeda@intel.com> Date: Fri, 20 Nov 2020 11:24:00 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/18/2020 3:34 PM, Raslan Darawsheh wrote: > Hi, > >> -----Original Message----- >> From: dev On Behalf Of Dekel Peled >> Sent: Wednesday, November 18, 2020 11:24 AM >> To: Slava Ovsiienko ; Shahaf Shuler >> ; Matan Azrad >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation >> >> Recent patch fixed the RSS action validation, making sure hairpin queues >> and standard queues are not used together in the same RSS action. >> The variable used for comparison was declared and initialized within the >> check loop, making the queue type comparison wrong. >> >> This patch moves the variable declaration to the start of the function, >> outside of the check loop. >> >> Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types") >> >> Signed-off-by: Dekel Peled >> Acked-by: Ori Kam >> Acked-by: Jack Min >> --- > > Patch applied to next-net-mlx, > Squashed into relevant commit in next-net, thanks.