From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA4BAA04FD; Wed, 10 Jun 2020 10:27:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8FC11D9E; Wed, 10 Jun 2020 10:27:39 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 991963B5 for ; Wed, 10 Jun 2020 10:27:38 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.62]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id BD77260055; Wed, 10 Jun 2020 08:27:37 +0000 (UTC) Received: from us4-mdac16-7.ut7.mdlocal (unknown [10.7.65.75]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id BC0CF8009B; Wed, 10 Jun 2020 08:27:37 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.42]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 40C8928004D; Wed, 10 Jun 2020 08:27:37 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id B2CF0A40059; Wed, 10 Jun 2020 08:27:36 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Jun 2020 09:27:30 +0100 To: Jerin Jacob , Bruce Richardson CC: "Ananyev, Konstantin" , Stephen Hemminger , "dev@dpdk.org" References: <20200608164640.189755-1-bruce.richardson@intel.com> <20200608121723.7a042105@hermes.lan> <20200609092949.GA1565@bricha3-MOBL.ger.corp.intel.com> <5710188e-4bba-c909-34cb-1bb67cbc3af0@solarflare.com> <20200609135717.GA1583@bricha3-MOBL.ger.corp.intel.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <4e577242-6e2e-03ba-b299-297c5cdf05d5@solarflare.com> Date: Wed, 10 Jun 2020 11:27:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25472.003 X-TM-AS-Result: No-6.577200-8.000000-10 X-TMASE-MatchedRID: u6ojmU07PKzbE+eFyyIBkfZvT2zYoYOwC/ExpXrHizzI13IEGi/Kk5Wi xnDxF7NQ6EHJvmrwzqkFGphL3rw6lLWPvW6oP7NyiVJZi91I9Jj8t4KjQ1om5m7pS2pg2KnZOki GGidO7I8JXAOpYzGkmQ51yjRxx3GzIeFIFB+CV+wD2WXLXdz+AaGEqigf79/L33Nl3elSfspvAM swCTtPsXBoNt72IIzt0pBYFw3jfMDFqOpCZ3blyVp0Bx5EayCF4NNiN6MhlPAh44tUX96R0Cc5a FljLyodFpDmxDbwMmByYqhkxaiSwRs45Zj9hz9mPPQ52FQZE7RDfut2Lc1Yh8bqJYow2PWAc8E5 p4psr/5CblH9HximwRh2k5gMHdhTszLAY5oHhBC5Xsf6ykoeEyIk3dpe5X+h4Po7B56a9VhbJHG A/RgNqwN3G6Ok+CNTT26esfIOsMATeBkfXMoITZRrnSy7UTtb2zgw5RT/BrZHrX2E2MkfRG8CWe 5rQ2bt4QVOPc5FfV6BRwAlrFOK9bSmTEY5EtKkmvnKSb020hwdLjiwtocA8vMH0AKMNc+6y6igH axqQh/fsQa4eA3tpsxeP1atcq+pgFZcSmL3XQxsExK7i/Tm03qLr3o+NE+Ij4jFvt2M5IK6MSe3 9Ehpt2uNWbA3vEMTsCUj8uKSZ56R9GF2J2xqMzl/1fD/GopdWQy9YC5qGvz6APa9i04WGCq2rl3 dzGQ1ACxMtuMHiBbNfjRaLx1pQ4fmUFFNTuFmQLpEgGBVfj0f5a1eoJYLBcKmExiJrMlz/gTZoO N9FKu5eGSzMO3OteQnq0+QtYPZ2F9sBvG3t4oGxECHxaZMBwbZYBYdvap6SswcLuSaZJZzlLqE1 zO6+EMMprcbiest X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.577200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25472.003 X-MDID: 1591777657-d-aD54nXKuFN Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/10/20 8:22 AM, Jerin Jacob wrote: > On Tue, Jun 9, 2020 at 7:27 PM Bruce Richardson > wrote: >> >> On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: >>> On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: >>>> >>>>> >>>>> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: >>>>>> On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson >>>>>> wrote: >>>>>> >>>>>>> Rather than continuing to recommend an 80-char line limit, let's >>>>>>> take a hint from the Linux kernel[1] and aim for an 100-char >>>>>>> recommended limit instead. >>>>>>> >>>>>>> [1] >>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 >>>>>>> >>>>>>> Signed-off-by: Bruce Richardson --- >>>>>>> devtools/checkpatches.sh | 2 +- >>>>>>> doc/guides/contributing/coding_style.rst | 2 +- 2 files changed, 2 >>>>>>> insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >>>>>>> index 158087f1c..4970ed830 100755 --- a/devtools/checkpatches.sh +++ >>>>>>> b/devtools/checkpatches.sh @@ -15,7 +15,7 @@ >>>>>>> VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh >>>>>>> # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL >>>>>>> to a valid path # to a dictionary.txt file if dictionary.txt is not >>>>>>> in the default location. >>>>>>> codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} >>>>>>> -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} >>>>>>> +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} >>>>>>> >>>>>>> # override default Linux options options="--no-tree" diff --git >>>>>>> a/doc/guides/contributing/coding_style.rst >>>>>>> b/doc/guides/contributing/coding_style.rst index >>>>>>> 4efde93f6..1db3a7bbe 100644 --- >>>>>>> a/doc/guides/contributing/coding_style.rst +++ >>>>>>> b/doc/guides/contributing/coding_style.rst @@ -21,7 +21,7 @@ The >>>>>>> rules and guidelines given in this document cannot cover every >>>>>>> situation, so * In the case of creating new files, the style should >>>>>>> be consistent within each file in a given directory or module. * >>>>>>> The primary reason for coding standards is to increase code >>>>>>> readability and comprehensibility, therefore always use whatever >>>>>>> option >>>>> will make the code easiest to read. >>>>>>> >>>>>>> -Line length is recommended to be not more than 80 characters, >>>>>>> including comments. +Line length is recommended to be not more than >>>>>>> 100 characters, including comments. [Tab stop size should be >>>>>>> assumed to be 8-characters wide]. >>>>>>> >>>>>>> .. note:: >>>>>> >>>>>> I would even support going to 120 characters. >>>>>> >>>>>> Acked-by: Stephen Hemminger >>>>> >>>>> I think 100 is enough. >>>>> >>>>> In my case, I have a 1080p 24" monitor, and with two terminals >>>>> side-by-side 100 characters just fits inside each vim window. Going to >>>>> 120 would be fine for single terminal at a time, but I would find >>>>> awkward for e.g. side-by-side diff comparison in meld etc. >>>> >>>> My preference would be to keep things as it is - 80 chars per line. >>>> Having multiple different formatting styles in one source file looks >>>> really awkward and make it hard to follow. >>> >>> +1 >>> >> I wouldn't personally consider increasing the max line length as a style >> change, but even if you consider it such I'd worry about rejecting style >> changes on the basis that it may be different to what is there before. That >> logic means that we can never, ever change any element of DPDK coding style. >> >> I can see the issue with changes that require us to rework the style of >> code in order to comply with the new style, but changing the max length >> from 80 to 100 does not make 80-char lines incorrect and needing changes. > > Another point is: Other projects derived from the Linux kernel coding > standard also > getting migrated to the new coding standard. This change would be useful for: > a) People works on multiple Linux coding standard derived projects Valid point, but not really strong. I think that .editorconfig solves it. > b) Some of the code such as 'base' and 'common' code for HW drivers > are shared between multiple projects. > Such code needs adjustment/change when pulling to the DPDK code base > it it still follows 80 chars per line. Base and common code are not required to follow DPDK coding style even now.