DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org
Cc: jiancheng pei <jpei@sonicwall.com>
Subject: Re: [dpdk-dev] [PATCH] net/kni: set packet input port in eth_kni_rx()
Date: Fri, 24 Jul 2020 15:45:20 +0100
Message-ID: <4e5d236e-d0d9-1d6a-f9e1-6fc658fbdf9e@intel.com> (raw)
In-Reply-To: <20200701074941.3847658-1-ferruh.yigit@intel.com>

On 7/1/2020 8:49 AM, Ferruh Yigit wrote:
> From: jiancheng pei <jpei@sonicwall.com>
> 
> Store port_id in pmd_internals when eth kni device is created.
> Then set packet port of rte_mbuf in function eth_kni_rx.

Overall looks good, except minor issues commented below.
Since I have sent on behalf of the Jecky, I will send a new version with below
modifications.

Suggested title:
"net/kni: set packet input port in Rx"

> 
> Signed-off-by: Jecky Pei <jpei@sonicwall.com>
> ---
> Sending patch to the email list on behalf of the Jecky, initially he
> sent as github pull request.
> ---
>  drivers/net/kni/rte_eth_kni.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
> index d88cb1778..e3f5b101d 100644
> --- a/drivers/net/kni/rte_eth_kni.c
> +++ b/drivers/net/kni/rte_eth_kni.c
> @@ -47,6 +47,7 @@ struct pmd_queue {
>  
>  struct pmd_internals {
>  	struct rte_kni *kni;
> +	uint16_t port_id;
>  	int is_kni_started;
>  
>  	pthread_t thread;
> @@ -78,9 +79,13 @@ eth_kni_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
>  	struct pmd_queue *kni_q = q;
>  	struct rte_kni *kni = kni_q->internals->kni;
>  	uint16_t nb_pkts;
> +	int i;
>  
>  	nb_pkts = rte_kni_rx_burst(kni, bufs, nb_bufs);
> -
> +	for (i = 0; i < nb_pkts; i++) {
> +		bufs[i]->port = kni_q->internals->port_id;
> +	}

You can remove the curly braces.

> +	

There is trailing whitespace.

>  	kni_q->rx.pkts += nb_pkts;
>  
>  	return nb_pkts;
> @@ -372,6 +377,7 @@ eth_kni_create(struct rte_vdev_device *vdev,
>  		return NULL;
>  
>  	internals = eth_dev->data->dev_private;
> +	internals->port_id = eth_dev->data->port_id;
>  	data = eth_dev->data;
>  	data->nb_rx_queues = 1;
>  	data->nb_tx_queues = 1;
> 


  reply	other threads:[~2020-07-24 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  7:49 Ferruh Yigit
2020-07-24 14:45 ` Ferruh Yigit [this message]
2020-07-24 15:10 ` [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx Ferruh Yigit
2020-07-29 17:02   ` David Marchand
2020-07-29 17:06     ` Ferruh Yigit
2020-07-29 22:28       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e5d236e-d0d9-1d6a-f9e1-6fc658fbdf9e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jpei@sonicwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git