From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A74641B9F; Wed, 1 Feb 2023 15:37:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 250394021D; Wed, 1 Feb 2023 15:37:55 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 27D9540141 for ; Wed, 1 Feb 2023 15:37:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675262274; x=1706798274; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=2wKgVHicTYXzQCnF2Fj/PRAolesYUowDtKPtMQ/O0Ug=; b=b11qJwXORglsJUg1qEIjNN7zeSezJ9Jj1NThkAuD/VCTH1hjHgBwTiUk KhVHj7KkEQOCjLRZlj9KtKY3RJ1OlA44iuxNQXK/sNG3Ft5atZ9UAFczp 5t6q89bJ8sQlW2vuU2VGA3AL7KNG4QBKbcS1PmJi/v3iYarVAAJQXrnVC +ASQj4VR8i+Mr20b7QpDyGkrpbVA5rtmNGMALi9Yz39nbXHkUFLv4Wbi0 7kM2pzBbJ6/wWKprD1KgOWyDQ3pop3QKgaTUstdgvt/7TDHRY3npFfNdf o8liJmBX5YVihipmscs0a54ZeEKve4L9CW0xeYZilE38O0KkBY3lpfzKx w==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="308497307" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="308497307" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 06:37:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="910340960" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="910340960" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 01 Feb 2023 06:37:53 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 06:37:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 06:37:52 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 06:37:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3igG7C/IwjLDLn1E1iKv4xUeXUP3FHi2ZMFNa+/psMrg69cMFOjNZ+XqsCiMRabbJGuia6bW43bTHKDR69fZxUjpE5LXxGtkUaD9/u/n8Pmp6rmiMrL6ZQkYkjKh67EIrcV76m+cb0jk0wxg1L90cx0DjYr0hnu9aCJbHvd77TLqaIQrnuuxGQSAsllMgG7AQl395zGRt70JsVevJWhlqfZvOyYbzJAqFNfl/MhelHkijZF0mfCHRRZ1d5rsLPgRXvfDQQRu0DUjwxSsinszoChZt9LrYzV3LLN4jtEMR6DrCi2iqKeV3XSOfvGkPS4X2LyPIwLav9CCzmPfCFF2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUPzXldwBMoSywtp4XR4zrE5XBBlBVcw6KRJan2gY60=; b=FFGxLWVbWgQmN3NDJ6H98s1ca2hYqw5DeQBDIpuJDq6Bg05T0SzdH0jnwihsLWbvLp71Yn60gXwrn/GmrpXaf8m3U8B4EKgo9xVq0aXlfFOlRc7aqyWArDy7k+ayLOxX647coUEYrJnrQpElWPvBNnlAYgCSbPt8RXdJvIBZ1YNLSmZ0YGAOn3KbswnuYndutGTG0XN2UDTAUFFhqadRMsqHOS9bDFD0Aj0ON6SCLPBvmLa21HSRDrjZRGcDohb7GWNJ8PQwO5zxIUFOjMZZeO2YfWkuAU9iGLgQWuST+0UFjnxl++LjnBkJWsEKU40q0q+Sm3P1uFulBjDcXVd0qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by BN9PR11MB5401.namprd11.prod.outlook.com (2603:10b6:408:11a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 1 Feb 2023 14:37:50 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::4207:1798:c852:8fb4]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::4207:1798:c852:8fb4%7]) with mapi id 15.20.6064.024; Wed, 1 Feb 2023 14:37:50 +0000 Message-ID: <4ea9ff4b-a968-ad9e-ba6b-d96755ed2480@intel.com> Date: Wed, 1 Feb 2023 14:37:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.0 Subject: Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16 Content-Language: en-GB To: Akhil Goyal CC: Anoob Joseph , "dev@dpdk.org" , "Tejasree Kondoj" References: <20221215035805.1777924-1-ktejasree@marvell.com> <20221215054211.1919093-1-ktejasree@marvell.com> From: "Nicolau, Radu" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0314.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::13) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|BN9PR11MB5401:EE_ X-MS-Office365-Filtering-Correlation-Id: f50e6a8c-0d38-46f7-11b7-08db0461e4fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qCKn1IC1j9MCCi/XhhLBAfzURgjwhv2G8KVroIdWK1quayzApKQzz8HcZg7G51DnxSBxaZ5L4xlIeY9WiY+HkyjdlFcj+zVb/nuF2ygS0pmBQCSqTAVvb868/n15qtMkawv05rnr5h2FyvG4+qZP8G1oberl/mlvpc/aVRWLryY7L2I7yx5jbUsyfuuxOICdEShX7c8RIYEbd1gtxYNURiAgK6ZRJSiw0DhaPqvztQgse4SsofAfB9N610mQZdJlIc2COVlKBOhuGK4n0VnFpBjx1QWJzBV3O2zIuygPW+OQOT9YT30uh4200AdBiT51XctFlnpGny6EQKBqh3s8KmgDZsNcfxpAfvLObKw2swVMYO2Hm5BTifH9k2p+pLNoU/t9SynP5hipIj/r948ViV5jOO5ZEssPUJIEFAKndxkaDBkyR1LaDIZJhalmVlK0vkWkgdadEijiX3urX5gygE7tX/T6a5Z9TAXvevdwEjzGL3hxIMgxtYC+DiZ5CZsLfw1M5Rvr3saNBgnNLPFr0SX+RnHBP36BgAC0fSRBqfz8h1PVbxc1dvXPZRMo6JmQASJsnaRW7j7QFXATpWDNRr/tgwFwr0zgh26yea/gkD9zHjHeb1q1mu4IjFMSoC4+yWDVRAsSGy0NtpsbTtae/AHIt8NLeJScQ73pSAtAivFPRFYuT23fCmI7EAVyQRBcfVxX1IlMSHEzktDsNvf81Int9F2+II1aIhNH0CkvnTt3CP7A1a5+qacKL8kWxWWM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199018)(8936002)(41300700001)(6916009)(8676002)(66946007)(66556008)(478600001)(6486002)(31696002)(86362001)(66476007)(4326008)(31686004)(316002)(36756003)(6506007)(54906003)(4744005)(55236004)(53546011)(5660300002)(6666004)(2906002)(6512007)(26005)(2616005)(38100700002)(186003)(82960400001)(83380400001)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nmw3MFRuYWNETXFid0E1cmU1ODRNTmhYOGIxN1RaUXgrQ29uckF2TlprbUNw?= =?utf-8?B?QWNQaWI1eiswa1J5M25LQnRLakJmWVNkMXRhVWhjRUNqRCtEWlM1REJPUEE5?= =?utf-8?B?c2pSUHV1aWhoeGlobVlVck9YcG1KYVhsQ3hQdGlPNWlDYy9odUxkZDhIdUdS?= =?utf-8?B?UDVteVdhaTd0dG9CL2ttWmwxekZ6YVRiYmFlYzFiQVpDa0dXVHlobFNROFI3?= =?utf-8?B?endoaGZkVmZ0cktrYWdacXErQ2dGWGJyQ0FzUEdIOUhuellRMnVxK2hockZy?= =?utf-8?B?akdjR2o5eDhwV2lMUFdWMFhFdmxhTWNTaGhvN3I5WkdpMjFoaEgwYUU4dkpX?= =?utf-8?B?N002UXQ5K0tzeXRielJiNGxMM1BDTmpZdG9uVG9JUCs2V3RHcjY4bWJTcDly?= =?utf-8?B?Ym5IM1VCR3JMZG1tS0FkR2R0SVdOTkRMUS9PdmJJa3JSek4rajAvNUVIS2J4?= =?utf-8?B?ai9qUy91aGdYdjk1bmR5R0k5QVRqbHdmVDE5dHlVMDNUTVY3TEdHcWJocXdn?= =?utf-8?B?TGQzMERNZnRtenF6ejE3VXRnWDlqSVpOSUpieTlLbFpEMWpveTZhMjJIVUJJ?= =?utf-8?B?NUhoQTBQakJPSGg0cHNDL3hsckVWOCtLZVMzYTljbUo2Uzc1OE5XR2doVVlK?= =?utf-8?B?TU00bzRlMmR6RFp0Vm85YlNNZE9rNTZNTlRhVGJkSHpQMzkxSVZyOUhnY05v?= =?utf-8?B?cmhITHF1V0ZBZzRGRzcwQyt6WUlQNGxCVnJHdC9KVnhjMDVUWTB1M3FEb0hZ?= =?utf-8?B?YUM3ZzNnVUtIaDN2WDRvbGFMN25pOUdMMVdWRVFiYXowQy83YmhUOTJRRDVX?= =?utf-8?B?L1pjSWtJZEVJZk1wZkZoMnVhWHZuaUMyNmo0K1EvRStMR1ExbkEzV3c5S3lP?= =?utf-8?B?NmZyVTNxNzk2WkluZGRYMkhVdXJWZUl6MmY5UEZyL09pZmttREZuUzRubzZy?= =?utf-8?B?bzZFMkE3WEZiWGpTRk5RenJXYkQ5VTNBR2toRWVyM3JPRjArai9qTkdiaGgy?= =?utf-8?B?TWMxQmkyME4ydWVreGxnV2VQbUFwNlV5UEVxTnF1a3A3bG5PN0FMZmZqV1J2?= =?utf-8?B?SmI4ZHZBdWJia1RuSzlOVTFrSnc1YzgxTkJORUtObEswSUxOaTNWUWR0MmFR?= =?utf-8?B?a3RhenNhL01BN3kreWxMUGlDbk16alFGR1J2dGY1T0RScm40TjdXVzdCQmdM?= =?utf-8?B?RDZZUFFoMG9sb1ZmdEVrdUVDSVNaa3FZbDR0Q3EydW9xV3Nna3MySGlqTy9r?= =?utf-8?B?WVdzMkc4dnFuQWlyQ0h1TEZVY3dWOWlRcHpRT053SFBYUlNvTjdJQ2FvZUp4?= =?utf-8?B?aGhkWTV5cVZ5eFVoZzZvRWdhMjE3elU0blFkU2J2YVZocHVHcmNXK1FpNFRW?= =?utf-8?B?cThtZlVJenBIUEVMYUhWYy9QbzBSU1F1WTlIdFlsaFpqbGJFK2p3L2xabHRs?= =?utf-8?B?TVUyUC9VU0hzazBoOC9jdEV3MU5qbExmQnBReGw3VzZGcFNpbWphN1hZWVNj?= =?utf-8?B?bXpJcVA4TnQ0UjdlWjc2dC9ENXd2UFZZeHlBYWFJbEpCczVTNG45NkdIWDJJ?= =?utf-8?B?VEdZbHFCN0N2MXltenIvQ0haei9ybGJoTURmaDRmUjBrMUxkMkxaTXV4MjFL?= =?utf-8?B?TmdSL3BNTzgySHp0VDhpZHhXalZLSmpuSEtzamxIYzlxclJCWWhxVjVnK1ZF?= =?utf-8?B?YjFaUUtGWlNKYXUvMjF5UXc0Wlp6dXlpWHorNFpOSXRpbjdaZGZjZ0NoNFF4?= =?utf-8?B?SVZpeW5Na2hVcFljRFFBVkRPcDZVZ1NFUFhOUWdubnZWQkkrN25BeWhya2Yw?= =?utf-8?B?Q0t4UXV0TlJsMU16MExnSk9OT056YlZrQXVmYVdNZ1BjR1hkQit6Q3N5RnZy?= =?utf-8?B?WEx2bE5HVm94UmU1REE4ZUdseVhaZndPL1o1UCtQK2RQK2pTZ09FT0FvVGw0?= =?utf-8?B?Wk1NQSthYUJJR01UZ1dPamtjQVkvaTAvZnBkMWVXUEQ1dkV6YkJXa0dsWGp3?= =?utf-8?B?ZE9FY1NzamhjTktEaS9IY1Q1RXpVdFh5YjV3MHhocTBPWXBVSU1qOUJuWllh?= =?utf-8?B?bTYzazZkNFdxajZ3eFMrTkplWWU4dTA5RUsvN3JnYlJZUFgzRHg4RW9pUEk0?= =?utf-8?B?RHowZVBWdzFFZVdJZFF1TTV5RlFpUThQeUhZeCsvemJJb3p4YkFHWXJRWkt0?= =?utf-8?B?Z3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f50e6a8c-0d38-46f7-11b7-08db0461e4fd X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 14:37:50.5529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5pB6sxGT8VvW4yWdLfXpN5Uh6YyF3Yfq3aPHcp/UDq12nb02Uv/xk6IgJXagrMUSqw0byaebKyLsAO2xCJzy4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5401 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi On 2/1/2023 2:16 PM, Akhil Goyal wrote: > Hi Radu, > >> Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16 >> >> Set AES-CTR IV length as 16 instead of taking from >> SA config option since the application populates >> 16B IV in the datapath. AES-CTR requires 16B IV >> constructed from nonce and counter. >> >> Signed-off-by: Tejasree Kondoj > Do you have a comment on this? No real objection, only that there is already an inconsistency in the definitions of the aes-xxx-ctr entries, 128 bit IV is 8 bytes, 192 and 256 are 16 bytes. Maybe it would be better to change the 128 bit variant definition? In any case: Reviewed-by: Radu Nicolau