DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matej Vido <vido@cesnet.cz>, dev@dpdk.org
Cc: remes@netcope.com, Thomas Monjalon <thomas@monjalon.net>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/4] net/szedata2: use dynamically allocated queues
Date: Fri, 6 Apr 2018 14:20:33 +0100	[thread overview]
Message-ID: <4eac6e85-1c35-51bb-66ef-24c9a4641ab3@intel.com> (raw)
In-Reply-To: <1522849341-49049-3-git-send-email-vido@cesnet.cz>

On 4/4/2018 2:42 PM, Matej Vido wrote:
> Previously the queues were the part of private data structure of the
> Ethernet device.
> Now the queues are allocated at setup thus numa-aware allocation is
> possible.

Hi Matej,

Yes by default [rt]x_queues are allocated via rte_zmalloc, which uses SOCKET_ID_ANY.

And in burst functions, we do:
 nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id], rx_pkts, nb_pkts);

So there is an access to rx_queues in each rte_eth_rx_burst() call.

I wonder if you observe any performance difference with this update?
And what about moving to the ethdev layer instead of keeping local to the PMD?

> 
> Signed-off-by: Matej Vido <vido@cesnet.cz>

<...>

  reply	other threads:[~2018-04-06 13:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 13:42 [dpdk-dev] [PATCH 0/4] net/szedata2: fixes or improvements Matej Vido
2018-04-04 13:42 ` [dpdk-dev] [PATCH 1/4] net/szedata2: fix total stats Matej Vido
2018-04-04 13:42 ` [dpdk-dev] [PATCH 2/4] net/szedata2: use dynamically allocated queues Matej Vido
2018-04-06 13:20   ` Ferruh Yigit [this message]
2018-04-06 13:51     ` Ferruh Yigit
2018-04-04 13:42 ` [dpdk-dev] [PATCH 3/4] net/szedata2: add stat of mbuf allocation failures Matej Vido
2018-04-04 13:42 ` [dpdk-dev] [PATCH 4/4] net/szedata2: fix format string for pci address Matej Vido
2018-04-06 13:53 ` [dpdk-dev] [PATCH 0/4] net/szedata2: fixes or improvements Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eac6e85-1c35-51bb-66ef-24c9a4641ab3@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=remes@netcope.com \
    --cc=thomas@monjalon.net \
    --cc=vido@cesnet.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).