From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81E9542CB7; Wed, 14 Jun 2023 17:39:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EDAE40E0F; Wed, 14 Jun 2023 17:39:14 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2070.outbound.protection.outlook.com [40.107.220.70]) by mails.dpdk.org (Postfix) with ESMTP id B3B5D40DDB for ; Wed, 14 Jun 2023 17:39:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c6xfM9crFYT4h9Hklz98La/93brbyBDPPGf9UdlAO5OQ2I9aOY+cfPu+YjDI3EwWP7IzAm2+dutGjs9YYjiJJHYky40axRPrC2Hl9Lm2NUNz167myHA/YJQfcvYUbeFuVTNsr2NXXgoKpamG1qc0u6q7b0szssUZugQTHnQd2/0xS5jtwoUksZivlBsLvHxGflPyWE8rAM32bvJ60iDdJbwS1XfOG7iSeqWlOMC8yI0zEqMEMnM+LlHfQdsKV5UPU7sutt4y2DXGcJUn2bdsNYwJ6rqW3oYE22W1mdUUJW5ZxxXMddpK0S/jTynDdNreZ1Re9ZDELvj1ohAGKEnYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ilg/xVckZeV4VwDBLlu08gmMPXlJRQ38nVHPavbfCyA=; b=gqgZOGEVNu3I0jg3ug6XSdplIXUKv76GGoyS8fG68Ag3q9MPPMG56M5/Z3HPSb8UuE5dVlPn1nK4FfN6k5318u/PjKikAtfMJgox+N5UaSinllcP5U+ZZgBcjcGVAjuno4HBGpThkjL0aYGh47hj3kLK+VOTbktfU57wEkF4xQre5je7BP0jDIiwZQ5tFx85eyihvDVUvVGLCjzoiUXRPI+L/HHdIQY5ckLC2KmTarIUBMB2D9A+xpLBluSqOwJr40JgitMcsQFvj14MlmqMPwY8hjjCPazYLyfVQ3IYUX4SEO6NzxvzgHmxsEX1551AhuUTzYStcWSbN8aq0caYPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ilg/xVckZeV4VwDBLlu08gmMPXlJRQ38nVHPavbfCyA=; b=f+ptefGtPiYJhM4qA3ZcyjfUJp63n0xil3YJJvZlaFL7jgUtoRwKKKwLWcspXwU/OyXWZBngH0z3lMlgyNhXRWtnvTdjNc2FnwckDtr7js9atei6J6hFPQTWkaI4EorH8mMFmUEhOmxPd0PXYjYFTv4csRgxvKPkDXRiT6nQJX4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6821.namprd12.prod.outlook.com (2603:10b6:806:25c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Wed, 14 Jun 2023 15:39:10 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6477.037; Wed, 14 Jun 2023 15:39:10 +0000 Message-ID: <4ec5b160-f2e1-832f-ffd6-b581c3d9028d@amd.com> Date: Wed, 14 Jun 2023 16:39:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] ethdev: rename functions checking queue validity Content-Language: en-US To: Thomas Monjalon , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Andrew Rybchenko , Dengdui Huang References: <20230614152100.1664198-1-thomas@monjalon.net> From: Ferruh Yigit In-Reply-To: <20230614152100.1664198-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0046.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6821:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e690b9d-ebe1-4ea5-dedb-08db6ced7f14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ahkJMlrxVWFTIbwg0vNaawRk49gHxzgEogj15dyHNgt3f1KcIX9GTQIYcn6GFJy19DrWKNa/Q68pcbTwBrUUmea6XAHmE2p637SOdMc8PUdTQop3QQ1kOGXBPd+6T/1HHRAY62sApNgsTJm+rYHpew2MWMCZeFJsOG1tx+9dz0RktTKsTuSZHzI+xlus7X9J1mDae/iaGF4Nz/wetV/QRlZC/ghoOEbsV55ZusKw3mm6d2AZhEvE7usA3pyDkYR0We5Hlx+y2ac2/Edu4QFqJZ8+d8QiyYgEK0tznUzHnXbIcs2hZecDbn/ETuqwOzy7uqvb+IkPDL0bKJH2XAOMSwxHG6fimoPIBoxjlwDtHroYZzng/uG1g0Tciv4DDLlrROJMEXCABXzhVeYuQLM9oGg3TxoEHd/g9FavNM2frVCtE60jCAhXbvLj6FiuIRe8DJU0ni1SGTg9X91qqRvxzEqI8bTtlHUU/q4he8yfm/gAwb5855EM49D2bgF5Iu1A+qpK48yzA9wGb9SuMC7+R8RHD5r+4QI7ugIog0epiI9arAHU9qNyqMoVtMvzsdU8Q98yH9JiBGN7Z1HKBe9+r55ly7LtUtssXU+R6LYWlhD8y6G+FEdeDfhmlNRe1mTCqsQupjaooFbnvBBywdXqjg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199021)(66556008)(66946007)(66476007)(8936002)(8676002)(5660300002)(31686004)(478600001)(54906003)(6666004)(36756003)(4326008)(2616005)(316002)(6486002)(41300700001)(38100700002)(44832011)(186003)(6512007)(26005)(53546011)(86362001)(6506007)(31696002)(83380400001)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MW5zb1RUVWpIaFFMMGNiMHZodWl0SFc2Tm9zcVVIcmVsY2tkbXl4eHZOc1V1?= =?utf-8?B?K1M0WHFaMGdIak02MVliQzh3YWhPelJXM3ZOTWFFNUhEU1V0V08ySm5hTUdj?= =?utf-8?B?T2x3RmduSGNFbEVXb3FIRW5IZHRaYk9mZS8rZ0tuOGtRZEZFSkthU1lTWTgw?= =?utf-8?B?S3hGNWlNTU1NQ1dTQ3ZnVVB1RE84ZXFrLzZHS1dmUnZhT0hwNUc2VGFUdmlx?= =?utf-8?B?WmQvWkxiSUdJL1E3d2RULzRwWkh6a3E1YWl2a0xqUDYvZ3E2SDlqb1NmbUdv?= =?utf-8?B?OWIwdjlyZytWSkVGaUxxeG5Nb0VkTlJTdzFVSllNcWhCRHE4MTFlNzBlUTh3?= =?utf-8?B?Q0g1cnNJR0lRbXJYeXlHQjIxZlIvWThDQkpibm9IekhXcGpJZTBLakNKbFo4?= =?utf-8?B?WTFDd3pYTkwvSEN1MTdSbCs3bkZDQ1V1dmVINmI5cnF1RkI5dHFocnMwS2xn?= =?utf-8?B?T2FjeGN5WXdDYkhlVW9KS1V4Nk8xSk9RZ3lwUHRLNXBLM0RmZ2FMaDViS1I5?= =?utf-8?B?ZGdueGp6bExad0l3Wmp1ZVpybFRjb3JmTXVpT0JFMmV3UkhoNmw3VGtXOWRp?= =?utf-8?B?SFJJSVZSYWdPU0hXdDdqZGhzR3hBL04rUW1VYWxVaVhmRkNLTmkzZmswR3hw?= =?utf-8?B?ZjJFd08xYm9RTlMwUmoxMVk0RGZ4N3NKWmlGaUtYRXlqZllEUmV0ZkRxM3VB?= =?utf-8?B?YkpYQ1JUQWJPUTh1dGpGUkkxZ0prL0hVcDQ2VGVmZnM4UVpQTitRUjNncDd3?= =?utf-8?B?SFhZYzNKbUFEb3RhTkIySFBMaWxnYVUwOVlvQjFmNmU5NlZNUVFUR2hTc0xE?= =?utf-8?B?NjFtVUJzVHlvVEhaTHBPbzV1c0RFOWdqSklTdVFTTVdvRWFkM0FBMUxwMm1M?= =?utf-8?B?cEVlRlVxbWw1cGZZL2RjRGQ1YWRHeWR5Mjk5bUhRZ1lhemFneUJtbjJac2xp?= =?utf-8?B?ZllDSzR5UHFVY3BzQldneTZnOGpOWTNYN3NSVm1nQTVOWEVqSXNmZ1BJbHpw?= =?utf-8?B?eUVVU3hHR2g0YWYycW0rUU5ORE84U2M0VVlsVXhZT213blNmN2lEZE1sdWYy?= =?utf-8?B?S2lWVkVHd3Qwazd2a0FGc1JPbnNxcm1ndmRocEtDdlZkQm9KeWhtVG4rTnJN?= =?utf-8?B?L1NFaGwwM1NzWW5uVGpsMVZCZFAzWjRYY0F5OUFyVENIeFRCVmM3OW1WUnVv?= =?utf-8?B?NE5ySVBDQ0gvZHUxMTNCVzUvRlVUb1pDZldXVVJ1VEhqT1FtVGpxTll1RkJT?= =?utf-8?B?S09BUFI5TDFHbEx2T2ZWRGNBbkZQRU9obFlHenhTUnNBa2g4anBHTDhBQWhN?= =?utf-8?B?NGRmTmFQUHFyL1JXaEg4QW9tMi9RK3hEcllDdHVkQ3QzUzlHd2czdmVWbmNj?= =?utf-8?B?KzNndGFLaVlvMFhtS2ZqdHhPcGY3eTVHTDA5b09JZlg1NWFlR2RXNU1SdFVE?= =?utf-8?B?MmpVTlhYZ1Q3Zm53NE93QUcrcEovV0lMQlIwMEt5M1IrSStBbEdlVFBGRUh6?= =?utf-8?B?eERrUWR6K1lyZmk1c0RTNmpyYWR5c2hLVnZvWUJYR1RweUJ1bWpWY3pxTHNN?= =?utf-8?B?V045NUFqTS91L2tQL3psRzlUR3AvSGdFcU1iSUErdUZVQTdPckp2NXUzQVB3?= =?utf-8?B?TFo5RnNaMllLWk9MMzlnTzNaMnRIVHBpeDBrang1d2hVYTVydEVnWFZxKzd5?= =?utf-8?B?OE9rSG1HVWJPSnFuRDRSM3dUYkpCY0plUTNWOWtiN3FrNm8wK0Y0NXlBVlk1?= =?utf-8?B?UEZQdTdrd0g3aldEUWVYeVJkbWZaVTgzNzdBRzgyT04wMlVqcWhodWo2UEQy?= =?utf-8?B?MUlBemJKSUdkMlp2R2Mza0pzODNCSXFQVEZBTkcxMmowMGEzYkdBTkdjaFFB?= =?utf-8?B?TllDWG9aTzhYR1JCUkNuc2ZBRlp1SW5ZckZ5Z0gvdVdWb01aVkNjaEt4K3RE?= =?utf-8?B?SFB3MEx3QXpkSFZ1aGRadDFvVzgwRnZOVW1WbXNObFpvcDVTRmNVaGRITGVQ?= =?utf-8?B?UkphcUx4SVd6TkNBZGhCNmsxeGNIR2VSbUlEVUxjUmZnNnNsSjY4K25ZUVJM?= =?utf-8?B?SUNNNmlqUVkwS2tYTVNpVnliaFRmZFFiMkxMMHlLRFNaMVNsSEc2ZXhmRnhv?= =?utf-8?Q?dPjyOfzgmgiydVL4YRHtKRq6P?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e690b9d-ebe1-4ea5-dedb-08db6ced7f14 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 15:39:10.0399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Up3rUSwvY6kaaHgWszGjSiBg9DVs7nOqQCmvq2v5jOZKUSA2tub1af3ufKn2yiKT X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6821 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/14/2023 4:20 PM, Thomas Monjalon wrote: > Two functions helping to check Rx/Tx queues validity > were added in DPDK 23.07-rc1. > As the release is not closed, it is still time to rename. > > The name proposed originally > rte_eth_dev_is_valid_*xq > is consistent with this function: > rte_eth_dev_is_valid_port() > However, the suffixes "rxq" and "txq" are uncommon in ethdev functions. > > Also for shortness, many functions are dropping "_dev_" > as these functions which manage the queues: > rte_eth_*x_queue_info_get() > rte_eth_*x_queue_setup() > rte_eth_*x_hairpin_queue_setup > For completeness, there are some old functions having "_dev_": > rte_eth_dev_*x_queue_start() > rte_eth_dev_*x_queue_stop() > Anyway in all above examples, the subject is after the prefix, > and the verb is at the end. > > That's why I propose renaming into: > rte_eth_*x_queue_is_valid() > > Fixes: 7ea7e0cd3a08 ("ethdev: add functions to check queue validity") > > Signed-off-by: Thomas Monjalon > Acked-by: Ferruh Yigit