From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE01BA00C3; Fri, 7 Oct 2022 16:13:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60607427F6; Fri, 7 Oct 2022 16:13:46 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E9CD7400D5 for ; Fri, 7 Oct 2022 16:13:44 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B7F5E7B; Fri, 7 Oct 2022 17:13:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B7F5E7B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665152023; bh=MrGTSkqb3FgGvyB0loX2N7sGRRPnBV3qaXEU06mHnGQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WFY74XJDO80rfwdv6Rdxo4f62OaOPiTcX1g+qqLy1dmYTIilQazYT/I4MCUVtYFWE VWLPFFnnEVZQ9Eeh3mS0+pDQ6eShtuK9AHjI+695MBPgy2R4GeGhSBIhkWmJz6wnJ7 MN2zzWnkw8o5cLTomoKptB8o+ovJDF8hCErGacQc= Message-ID: <4ec6f663-76d7-2692-7b81-230cb351aba2@oktetlabs.ru> Date: Fri, 7 Oct 2022 17:13:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 1/3] ethdev: support mulitiple mbuf pools per Rx queue Content-Language: en-US To: Stephen Hemminger , Hanumanth Pothula Cc: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org, xuan.ding@intel.com, wenxuanx.wu@intel.com, xiaoyun.li@intel.com, yuanx.wang@intel.com, mdr@ashroe.eu, yuying.zhang@intel.com, qi.z.zhang@intel.com, viacheslavo@nvidia.com, jerinj@marvell.com, ndabilpuram@marvell.com References: <20220915070732.182542-1-hpothula@marvell.com> <20221006170126.1322852-1-hpothula@marvell.com> <20221006102936.2c4074af@hermes.local> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221006102936.2c4074af@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/6/22 20:29, Stephen Hemminger wrote: > On Thu, 6 Oct 2022 22:31:24 +0530 > Hanumanth Pothula wrote: > >> + /** >> + * Points to an array of mempools. >> + * >> + * Valid only when RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL flag is set in >> + * Rx offloads. >> + * >> + * This provides support for multiple mbuf pools per Rx queue. >> + * >> + * This is often useful for saving the memory where the application can >> + * create a different pools to steer the specific size of the packet, thus >> + * enabling effective use of memory. >> + * >> + * Note that on Rx scatter enable, a packet may be delivered using a chain >> + * of mbufs obtained from single mempool or multiple mempools based on >> + * the NIC implementation. >> + */ >> + struct rte_mempool **rx_mempools; >> + uint16_t rx_npool; /** < number of mempools */ >> + >> uint64_t reserved_64s[2]; /**< Reserved for future fields */ >> void *reserved_ptrs[2]; /**< Reserved for future fields */ > > Better and safer to just take up some of those existing reserved fields. > I don't understand why. We're braking ABI anyway.