* [dpdk-dev] [PATCH] net/sfc: fix inner TCP/UDP checksum offload control
@ 2018-05-10 11:59 Andrew Rybchenko
2018-05-10 23:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2018-05-10 11:59 UTC (permalink / raw)
To: dev; +Cc: stable
If application uses Tx offload API and sets ETH_TXQ_FLAGS_IGNORE flag,
it still should have inner TCP/UDP checksum offload enabled if it is
supported and TCP/UDP checksum offload is requested.
Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_tx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c
index 579bfab7e..1bcc2c697 100644
--- a/drivers/net/sfc/sfc_tx.c
+++ b/drivers/net/sfc/sfc_tx.c
@@ -449,8 +449,7 @@ sfc_tx_qstart(struct sfc_adapter *sa, unsigned int sw_index)
(txq->offloads & DEV_TX_OFFLOAD_UDP_CKSUM)) {
flags |= EFX_TXQ_CKSUM_TCPUDP;
- if ((~txq->flags & ETH_TXQ_FLAGS_IGNORE) &&
- (offloads_supported & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM))
+ if (offloads_supported & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM)
flags |= EFX_TXQ_CKSUM_INNER_TCPUDP;
}
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix inner TCP/UDP checksum offload control
2018-05-10 11:59 [dpdk-dev] [PATCH] net/sfc: fix inner TCP/UDP checksum offload control Andrew Rybchenko
@ 2018-05-10 23:13 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-05-10 23:13 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: stable
On 5/10/2018 12:59 PM, Andrew Rybchenko wrote:
> If application uses Tx offload API and sets ETH_TXQ_FLAGS_IGNORE flag,
> it still should have inner TCP/UDP checksum offload enabled if it is
> supported and TCP/UDP checksum offload is requested.
>
> Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-10 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 11:59 [dpdk-dev] [PATCH] net/sfc: fix inner TCP/UDP checksum offload control Andrew Rybchenko
2018-05-10 23:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).