From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D37A14F94 for ; Fri, 1 Jun 2018 16:59:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2018 07:59:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,467,1520924400"; d="scan'208";a="60458124" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2018 07:59:43 -0700 To: "Stojaczyk, DariuszX" , "dev@dpdk.org" References: <1527857469-159391-1-git-send-email-dariuszx.stojaczyk@intel.com> <4ad00805-bf12-7426-4040-6a44c51226f2@intel.com> From: "Burakov, Anatoly" Message-ID: <4ef183de-b569-efa7-f9a7-17593c4ab5b4@intel.com> Date: Fri, 1 Jun 2018 15:59:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 14:59:45 -0000 >> Page size shouldn't be zero, should be alloc_sz. > > The 0 above is for the `flags` parameter. Page size is set to alloc_sz. > > ``` > void * > eal_get_virtual_area(void *requested_addr, size_t *size, > size_t page_sz, int flags, int mmap_flags); > ``` > > I believe it's okay. Correct me if I'm wrong. Apologies, you're right. I misread the code. -- Thanks, Anatoly