From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82A91A00C4; Mon, 14 Nov 2022 16:10:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B77C40150; Mon, 14 Nov 2022 16:10:59 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by mails.dpdk.org (Postfix) with ESMTP id C385B4014F for ; Mon, 14 Nov 2022 16:10:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IghQ5GiuvSKNfxPDzRR7w4dKNERbUWkspjGwzAf2mmZAfZxNO0ca2XfDv0rOgTaI2cF3AXkj+peg2KEImgbZnulsl+8/9eSPYYdenGIop0x3e/4fldYA4u+2HrIIiZom1Edr0+hm0kh/35gGtcxtYH4Gadj0UIxCVD+qNC9VgQoSkt87fSpcMbqj34TE6aK3T1adv1c9Y/oipZcrTfxndxz8BnXLkoCIAh+GZT2o1mqpW1rhnk0QwUSRScNId4kXZuI9PaGKvbLWixCDd/PNRp9EJdRRZx/Abu0tgGGF3zLbwLFqDhhSKbSggubbgEGacApyKaUhw5jK478qtaZa1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FJbdiKTcVuobcS7YsZmvmkZkBAXBkP00MQDe1kszYo0=; b=PxuI+U5qR8NJftCJWSx3TNmXeSiRJeWEopp50PJ3dGl2fAXFlRi9eWlE5BQ2huDlWHDN2nA4jSpdLrRMj57+tuLuu9dP0D4JglIX6ORlKbVZYnB/coZANv7JCmL86HSru40KQb60mpXDzv+EiK0h92rx1fZZ4O0QNR7TE0zDwosaYrty5MCod9Fv11RB9nHWqJQbayRZsCURw6OAhIUqmGpjQNzWpquePDVqIfJ3RTCuBmF7iqrjG7T1ugwPOwmIT27+syi+ZPwemYwT9uVpCp1aAcbadaWboiHXa+fH20ZVgOAlP8SVwTbrKy+Li58oX4Kd8OcVXMWHLTgSNPMBwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJbdiKTcVuobcS7YsZmvmkZkBAXBkP00MQDe1kszYo0=; b=UelaKP7yyge6jVxNxjZsvORYjl+Xk9jx4KFTIqf+EodlvuxhAuOPRAWyXF3GDgxcP86e7+pbeIzbyQwdMwKN68JRMCP5D0XVUpbr8WwIN07rUdRP5IltBQFBtN7423SrofoRdeTwOGBClLtDfKF14GroaaxE4QQfiSOQQdCBeLY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5338.namprd12.prod.outlook.com (2603:10b6:408:103::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 15:10:56 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 15:10:56 +0000 Message-ID: <4f0df49a-c78c-b84c-fa4c-ed96f8d900c7@amd.com> Date: Mon, 14 Nov 2022 15:10:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] devtools: catch empty symbol maps Content-Language: en-US To: Bruce Richardson , David Marchand Cc: dev@dpdk.org, omer.yamac@ceng.metu.edu.tr, Thomas Monjalon References: <20221114141651.1255306-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5338:EE_ X-MS-Office365-Filtering-Correlation-Id: 386773aa-6f54-4e11-5f2a-08dac6526cbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQoYEY1KfEsbIo2jo5IEMMPV9tf7kLj7UO1Gqn8mfMlcDoyNuuVWMha6xh76AMKvlIM95UaKXYqH2FiF+Z9wYhS88FGTq02DN5OW5fX0o2Ov6SF/QuFv/+o593gkaDfKrtOPpurRoK14wCZsVk+Jm23QjcP7Exy4Ku/Igr3xLgLokl3irA2XR+JuiOrPLK5kPJVlgA84gwsSZJUb4kJSzm5Cg7FqBwkYzP0jSDEPovMho5e+tvS9PTwUJjmGi5+lXuqsGL1nyvac2yNSYjG8/aGDzRK7VTuFTZwisQ9b2i7MKCdMuNb5L1wD5WTlwkIXNUpANDbp6bd5KPv246v4YdbcbhbavvlH09Quzg8wIuxLwzpUm0p6nSNnoqp7cSIQnUVcd3OyKWpeka0lnNM/2X4YdC22UDQS/neiLm+veX0khkr436CL3Ztoiw7R+4/OVjMmXs6/5tfp5GBSUpfPk90EZC9PjoBi9o2Sj+/WygoD5BV9rgKDLBNfTOe8O/XJdAJ7h0QVblZvxCE+yFkivBEoO6v/yrGRtsHUussIdXZPhL4Qqm/xWOo0Jbi6kd55T8xOIKkq9om3IbBow5pmiJJz43lffXyCzfeMOInx+4csyOUF0goonk4MIO9EjGelkMEp/lXYKaEwgyZCtJgykPTW+TM+GsEEiG+kd0ig0Onpe9NrQ3VYCZl5rO4gTQiedrD4xLIt0XEdlw14RZ2rXqbCIo9nW6awcPa5JC/nv0GBq3SGShlXcA5b6xfIjvUwJmmvHs2NWhIa4G/iPYp6aZZ87Gw3J3Nwvwok8CtUavo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199015)(6486002)(6666004)(110136005)(6506007)(478600001)(31686004)(6512007)(44832011)(8936002)(36756003)(66946007)(4744005)(66556008)(66476007)(4326008)(8676002)(2616005)(41300700001)(5660300002)(186003)(26005)(2906002)(31696002)(53546011)(316002)(38100700002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzJZVUhqWHBnN0RDU28vTndMMUhBUll0aWlrbGdKZFllMmx5Zlk0dDRRYm1q?= =?utf-8?B?VEo4VW9YalRhTG5ZY0xGbzlxMDdqa1ljRVViYll2cE82TTlpenhWQlVRLzlT?= =?utf-8?B?aHNxeHFjSk9peThjNmc4R05BNTZPK1NFa2RyMmQwZWExUUVNVDduaCtxZ1VK?= =?utf-8?B?YWVFcmVkWE9mZU85a3RyR1Q4YXZ4MDdaV3IyZkVoc2hJbGZwb1lxZ1dkclRv?= =?utf-8?B?V2I1bndrZmZFdVh6TGhGL2tCWGlNenBzWXpMMUZrQVN4aVdramVNQ3ExV1JC?= =?utf-8?B?UklZaUZHRmtGVndjZmRMOXRzVyt5QXJEZGQ2TkhGTVZFSk5lUnJib0MrS1gy?= =?utf-8?B?eE1uMFQ4cGpGTGtianRGRGVndWNJclJwWGNXZjhQWlJWT05YaTI0Z0kvU2lH?= =?utf-8?B?b2graHZEZUxSSThTcXRmNDVmeFBOdE5VZ3RubGt1RGk2WmNFY2oxU3I4dDdZ?= =?utf-8?B?dUVRVlhrMVJiTjlhbnpvRW5mRzVMSXloc2ZsTXRSRCtkdEpTdkJJcnRJZWZh?= =?utf-8?B?YWRwSHBiSzZTVnA1Yk54dEUrTlV1Y3gvRnowVk9leSs1dDU0UjAvaitSZjFR?= =?utf-8?B?M0tZUXpJNVExNmNJUkFObS85dFZVUUtaYjY5OU5BczJYbkt5QTZoc2tGUStU?= =?utf-8?B?SmgzU3ZCS2psNkVVSUNuVThLdWRwQnFqcW5VZktHSC8rMTFiUldzZTQzWlJW?= =?utf-8?B?MWlNMnlvR1llSEgzaHBWL005d01tZldxSDBZNG9SeUhVTmdxNFc4MUdhck9P?= =?utf-8?B?bEJVbWpoUktNTGtzWUtNbUd5ZlVRc3FwMjBTcGl5eEI1Q1BxbXBDbmY1YnFo?= =?utf-8?B?SVFQTDZTcVNyeVdVeEFnTGNZQnl5MWh2YXZvKzhzYlFTbWZLOXBwc3BpUUtC?= =?utf-8?B?eUdYOUx4cSs1djd0bGEwaUk1TGpZQ1UvRGg5RkFHbnFUWHk5Yng1MWVvU2xa?= =?utf-8?B?dElSZmNPRmUxN3N1UExuNXd4Mk0ycEpRNi9yeHZyRTByb2Q3N2NxQnA1eVRM?= =?utf-8?B?c3JlTUxRZ0Uvdm1NZkxMaFlJTzRFMW9UNStJME5SNE5DNGR2UkpWSDdHNWty?= =?utf-8?B?RkZ2bk5Gdzc1dmdrSC9wOTVhZ2NROXdBMHArc3c0Q3lVVUpaVEs3bUlJOWlp?= =?utf-8?B?dUZwd2pkeUZzUnVRWWNTYW1RVUF6SWZXRnBLUFp3T01YdHpzSDlJc2oxSVgx?= =?utf-8?B?S0JTMTRBRjZ1SDV0cmlxaVZQVU54UkpXZ3grMHhrU01ZaWF0eG0wRGYyaFp3?= =?utf-8?B?eHZvYzExUWlJejJFTnJ5Z1BqR05JM3pMeUtKS3VRaUo3bFRqNmRkVFBQcjdD?= =?utf-8?B?Zk9lUEJWRVhQTUNwZlRFT2d1TTN3OUF6bnNqTlRjTEl5OWpKOXpkOU9DQ3pl?= =?utf-8?B?K0hCbkhoMCtJQm5OQ1hXK09tWmNZbmVGM2gydk1KdGs3endjaGVxR29IdUk3?= =?utf-8?B?S0U2UzA3YlFCQTdHaTh5a09EcTZpSitMUWlVNVI2ejNseEl3UTdWQ3FOcHlu?= =?utf-8?B?MFNhYlVTSUlPenphYlAySGdxRGtEK1lyS1huTmE5OHVIMjZob0RSTTRrcWpo?= =?utf-8?B?SWtub24vNzJEQ2dsTXpKSkdwVEZheE56ejVIQmZLT3BEMmFidmpoMDFxNHpQ?= =?utf-8?B?UVdJQWRQeVNGeWNGZ2xMQzBoTzFGbVBZajIwMlF3NjZvYzNvMUpkcmdqcDRj?= =?utf-8?B?UlJtL1E4YzVwdWUrU2FaaTFxZnRCd2E4aWg5RGlreHZNNXBGUDdEbjJ2L0ht?= =?utf-8?B?bkh0Qit3TWxYTDhreTh4NjlmeGJZbU56WS9ORThOZTdBTTBRTzdpU2lYcmVt?= =?utf-8?B?NEtxQ1JPMzQ3S2J4UVpXK0ZHZlIyRVU5emg4R1FKeERhVjVFK0dPOHU5MnIr?= =?utf-8?B?UXRidlpISWtoNks1OVFYYVkxaVJweit6K0Y1ZnMvR2xmdkhySEo4UllMNzNt?= =?utf-8?B?RFIzS2pxRGxrR2tKWVVwVEIzY1BkSWUva0pYc243bmFueWU2bjBZQkwvOXpu?= =?utf-8?B?elAyUk5hdGIvUkwyaDVGWUZNYjE0Zms1RjFSU1BPVTFxckhZWGl1ay9WV21R?= =?utf-8?B?K0JWUmJHNW5pWVlUdHluaVl6UnlEa1BzVmVQdzVoM1kvMzRNb1VseVNRNWtJ?= =?utf-8?Q?5S1QHkcP/kSorbzVofTuggVo9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 386773aa-6f54-4e11-5f2a-08dac6526cbd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 15:10:56.4240 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 005uOh7wZa/NGZbcBr6u05NXEu5slueP2ZfCduX194IUpD+KJ3xWCWkgwn28srb9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5338 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/14/2022 2:31 PM, Bruce Richardson wrote: > On Mon, Nov 14, 2022 at 03:16:51PM +0100, David Marchand wrote: >> version.map are now optional for drivers if no symbol is exported. >> Having no symbol exported from a library does not make sense. >> >> Catch all empty maps and warn about them. >> >> Example: >> $ ./devtools/check-symbol-maps.sh >> Found empty maps: >> drivers/crypto/uadk/version.map >> drivers/net/gve/version.map >> drivers/net/idpf/version.map >> >> Signed-off-by: David Marchand >> --- > > Acked-by: Bruce Richardson +1 to have automated checks, Tested-by: Ferruh Yigit