From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 9098D1AF03 for ; Tue, 19 Sep 2017 14:46:15 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id 13so4909026wmq.2 for ; Tue, 19 Sep 2017 05:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=q9NZMEBwzCuM02l5e2f0j8nl0cIs/N6Z2pRFWrq7ARI=; b=TZR3d4hJFmicMwZxB47wvbvB7/CDrSazk/j/O76xJ6JV6qljrCaOIWnEcU2ckLBcvR yvc2mmXXrM/0fvr46RpxS2pQMdNVVc+FvhdxzEAYFRILO3mhehR0ZAdujgQAe7eEk9KS c4LcZCu8pvenH5Pdz4vIVLvZhfBGIdPP8Ek4XsAcwkqUSAXEYT6Fd63fITFO1bg1kwYy IObMKb29oTb/hRLoRkdH7QbJfLDAltDcWMD8HEgBtbDYuvvRMBoxeKWY8xIhBdt5hypC bhEb5mKuLrFNGouYk1lcXLwNVun5NOsLWlvYCXzV00UrdxBzZBiz3HZ8pfQRQfsdLzdW nACQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=q9NZMEBwzCuM02l5e2f0j8nl0cIs/N6Z2pRFWrq7ARI=; b=LbU3OmePVoLiunPGXz9ppFg/elgnOCvFoMQq6p+i3gd6mShejHWlSZOq/phGqCcObp NuSGjd1ZzsTyCGilHeGqFg2erqyP27koij33IuA3V4Ek0ouat8oPgGYlYqWaiKi4cYSC pI2+Ql71JW5w2VVtV0KImgt9RMlLkpqdXw3fVUDhh64QE5HxacZxTt6V1OklnlKtWEDT 3bOH+fGX3JqIZ5meGqHUtEUl0V/NcDBP7ED9XEZXu66iBzpkl74vjuh7dq1733Ot342H kdh7s6168gGGtMVBeTbpDrWyILNfHMqsZywlyIInhxHTksTfiNpdjwX7oKFLQcyFZYrj UACw== X-Gm-Message-State: AHPjjUhuGNveYF8w/Sb1jjKj61BH4O52zzBfbPef9bsQv4EerUtxRa29 9O2pbtp3FTFjl0MkThkwOYIuyw== X-Google-Smtp-Source: AOwi7QBoSm6MHmpaHAK1Jyex8VIKRqWtoii8S1sPZW4j081WyYPv/k5Cfasi6+sjAhxkD6wY/XIjzQ== X-Received: by 10.28.236.212 with SMTP id h81mr969594wmi.42.1505825175214; Tue, 19 Sep 2017 05:46:15 -0700 (PDT) Received: from [192.168.1.79] (82.107.69.91.rev.sfr.net. [91.69.107.82]) by smtp.gmail.com with ESMTPSA id s196sm1232995wmb.26.2017.09.19.05.46.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 05:46:14 -0700 (PDT) To: Ferruh Yigit Cc: dev@dpdk.org, Keith Wiles , Vipin Varghese , stable@dpdk.org References: <20170918184735.43968-1-ferruh.yigit@intel.com> <20170918184735.43968-2-ferruh.yigit@intel.com> From: Pascal Mazon Message-ID: <4f36fa8e-8a03-2c59-eb0f-abc96ddc17d3@6wind.com> Date: Tue, 19 Sep 2017 14:46:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170918184735.43968-2-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: fix unregistering callback with invalid fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 12:46:15 -0000 Looks good. Best regards, Pascal Acked-by: Pascal Mazon On 18/09/2017 20:47, Ferruh Yigit wrote: > From: Vipin Varghese > > tap_intr_handle_set() called by tap_dev_start(), and if LSC is disabled > (dev_conf.intr_conf.lsc == 0), it tries to unregister interrupt > callback without checking the interrupt file descriptor. > > Fixes: c0bddd3a057f ("net/tap: add link status notification") > Cc: stable@dpdk.org > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 00dad167f..fcfd4215e 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -1098,10 +1098,11 @@ tap_intr_handle_set(struct rte_eth_dev *dev, int set) > > /* In any case, disable interrupt if the conf is no longer there. */ > if (!dev->data->dev_conf.intr_conf.lsc) { > - if (pmd->intr_handle.fd != -1) > + if (pmd->intr_handle.fd != -1) { > nl_final(pmd->intr_handle.fd); > - rte_intr_callback_unregister( > - &pmd->intr_handle, tap_dev_intr_handler, dev); > + rte_intr_callback_unregister(&pmd->intr_handle, > + tap_dev_intr_handler, dev); > + } > return 0; > } > if (set) {