From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 165B8A0A02;
	Fri, 26 Mar 2021 11:28:15 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9237840685;
	Fri, 26 Mar 2021 11:28:14 +0100 (CET)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by mails.dpdk.org (Postfix) with ESMTP id 2DD744067B;
 Fri, 26 Mar 2021 11:28:12 +0100 (CET)
IronPort-SDR: zSOrVKCoXN3Q3s9w1NM3xerTQS0ekIQoAtWbRtwNwCoj85FdBG0vSsWgnD4UN8Hz0VeawKhM9G
 +0Hlv2rGKYcA==
X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="188842470"
X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="188842470"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Mar 2021 03:28:11 -0700
IronPort-SDR: FzRdt4puUMbK/G86MpnRC/WU/wmMSF/2wkeArUv8d9JkvFwNRuVxXt4IS91qL8uif6GgAFYSy+
 NEbPRkeNmbaA==
X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="409836863"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.58])
 ([10.252.0.58])
 by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Mar 2021 03:28:09 -0700
To: Guoyang Zhou <zhouguoyang@huawei.com>, dev@dpdk.org
Cc: bluca@debian.org, cloud.wangxiaoyun@huawei.com, luoxianjun@huawei.com,
 yin.yinshi@huawei.com, luojiachen@huawei.com, chenlizhong@huawei.com,
 zengweiliang.zengweiliang@huawei.com, liqingqing3@huawei.com, stable@dpdk.org
References: <cover.1616504799.git.zhouguoyang@huawei.com>
 <b9908924e1a0a0487f067e21195af628b5efde24.1616504799.git.zhouguoyang@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <4f4d7203-01fb-679d-beb7-fae16d4fcaad@intel.com>
Date: Fri, 26 Mar 2021 10:28:06 +0000
MIME-Version: 1.0
In-Reply-To: <b9908924e1a0a0487f067e21195af628b5efde24.1616504799.git.zhouguoyang@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/1] net/hinic: fix coredump
 when in secondary process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/23/2021 1:17 PM, Guoyang Zhou wrote:
> Some apps, such as fstack, will use secondary process to access the
> memory of eth_dev_ops, and they want to get the info of dev, but hinic
> driver does not initialized it when in secondary process.
> 
> Fixes: 66f64dd6dc86 ("net/hinic: fix secondary process")
> Cc: stable@dpdk.org
> Signed-off-by: Guoyang Zhou <zhouguoyang@huawei.com>

Some comments from previous versions seems outstanding, can you please 
check/comment on them please:

http://inbox.dpdk.org/dev/c3ceb0c3-4d35-c14e-ea6b-cd4b311657a4@intel.com/


Also can you please send a new version as reply to previous version?
This keeps different versions in same email thread and helps to find the 
comments/discussing to previous versions easier. You can do this  via "git 
send-email", '--in-reply-to' argument.