From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AA889952 for ; Fri, 17 Feb 2017 16:15:04 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2017 07:15:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="824426538" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by FMSMGA003.fm.intel.com with ESMTP; 17 Feb 2017 07:15:02 -0800 To: "Wiles, Keith" , "Richardson, Bruce" References: <20170217144426.47823-1-keith.wiles@intel.com> <20170217150245.GB8652@bricha3-MOBL3.ger.corp.intel.com> Cc: "dev@dpdk.org" From: Ferruh Yigit Message-ID: <4f5a36b7-ac59-b052-959b-d2dc362461ec@intel.com> Date: Fri, 17 Feb 2017 15:15:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: fix coverity warning on strncpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 15:15:05 -0000 On 2/17/2017 3:05 PM, Wiles, Keith wrote: > >> On Feb 17, 2017, at 9:02 AM, Richardson, Bruce wrote: >> >> On Fri, Feb 17, 2017 at 08:44:26AM -0600, Keith Wiles wrote: >>> Calling strncpy with a maximum size argument of 16 bytes on destination >>> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the >>> destination string unterminated. >>> >>> Signed-off-by: Keith Wiles >>> --- >>> drivers/net/tap/rte_eth_tap.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c >>> index efc4426..f9938d7 100644 >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short flags, int add) >>> return -1; >>> } >>> memset(&ifr, 0, sizeof(ifr)); >>> - strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ); >>> + strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ-1); >> This is why I always prefer to use snprintf for copying strings, you >> can't avoid null terminating. > > Normally I use snprintf to not sure why I reverted to strncpy. Maybe leftover from a previous driver I used as the template. Since you are already updating that line, do you prefer to convert it to snprintf instead of above modification? > >> >> snprintf(ifr.ifr_name, IFNAMSIZ, "%s", pmd->name); >> >> /Bruce > > Regards, > Keith >