From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 7C654199A9
 for <dev@dpdk.org>; Mon,  9 Oct 2017 06:21:02 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP; 08 Oct 2017 21:21:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,498,1500966000"; d="scan'208";a="908027257"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.114.24])
 ([10.254.114.24])
 by FMSMGA003.fm.intel.com with ESMTP; 08 Oct 2017 21:21:00 -0700
To: "Xing, Beilei" <beilei.xing@intel.com>,
 "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
References: <20170818141736.4769-1-danielx.t.mrzyglod@intel.com>
 <94479800C636CB44BD422CB454846E013200861D@SHSMSX101.ccr.corp.intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <4f60894b-4545-2e6c-5aef-a4aa97e1369f@intel.com>
Date: Mon, 9 Oct 2017 05:21:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <94479800C636CB44BD422CB454846E013200861D@SHSMSX101.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to
 determine filesize
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Oct 2017 04:21:02 -0000

On 8/22/2017 3:03 AM, Xing, Beilei wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod
>> Sent: Friday, August 18, 2017 10:18 PM
>> To: Xing, Beilei <beilei.xing@intel.com>
>> Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
>> Subject: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to
>> determine filesize
>>
>> This issue was about passing unsigned argument where should be signed
>> number.
>> In reality this is about wrong usage of fseek and ftell to determine filesize.
>> This patch is compliant to suggestions from FIO19-C:
>> "Do not use fseek() and ftell() to compute the size of a regular file"
>>
>> Coverity issue: 143454
>> Fixes: a92a5a2cbbff ("app/testpmd: add command for loading DDP")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net/master, thanks.