From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F531A0547; Wed, 11 Aug 2021 13:31:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B304640C35; Wed, 11 Aug 2021 13:31:10 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C61F840042 for ; Wed, 11 Aug 2021 13:31:08 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="215131695" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="215131695" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 04:31:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="672816917" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2021 04:30:59 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 04:30:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 11 Aug 2021 04:30:57 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 11 Aug 2021 04:30:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d6MvnMgWGWcaCPm/LQzSRfT7UfsF40TsvW5SUwqfqC4kNnpaP1tx20VgFFLU9qjk3EllYhpcezQhfOy5MYCj6jQXTDGFO92HxFCv6SEdzAFPT/KvX7FUtiqaotKRm3YT22evbxbr46rO6KfyNQVGCq8hKX9/7QJ3XVkS7ES21nz0x/ypx7RHRduOvOmz9YYxiQmGo+LPtueHZbtJD04cKdjs7GfJAd1sa0T2k6OV9kgOO9uiTKimPLG+S9EyfO7n0SCUM7HCq28syrC1MISTUULSSQzIyhwIq9hQgW5MyqHaPYM44qr24ZQv6ChYOiTNLdtqNmyFCwxLRKX0xTk1Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XStC0byUQ/Jjn5I0yc8W73q2StJ9dWFkwrIbNCcdg4=; b=VJVnQkMnOABAAauU+QYnUvBl3e27EKRwcPu/5/V2v/qCMOZGfysbCScIO9oMdwnZb7AFLUILijxXl3UHlEFHNmVjgjJI/90DL9yEfwYQwkwqGny25VdO2a+n3OA587iYrbhnowC6Xf6hi2ys/lGbpb5ipH6uWi1U9bjoSTjKy7zz+66RQ5zFFDgol5+YbU4B58BDYoTfOjE0mR+s7Md+qoiIebBD8ipkeKE39tZpCQ17Hsfa01XJIvEQPkWBbAZxwEjxB0icT5Ob6Pq5RbLGlkoYB44SRShpGFCXZlfrtpRHqWedauPCd53+gGxShGAvwkh1NvDiJf2KmdOwau7bJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XStC0byUQ/Jjn5I0yc8W73q2StJ9dWFkwrIbNCcdg4=; b=lJz+MEYWjEMP/jEvyDPCHJO5wQ8GkTGOQVvxZ3caTA2/b5PjgfOsEUgfcooMlJ9POB4Fvg8ynOWPO+cfUlJs3a2IrxuG3ncaIZ+5jbBhST8w40aAXQyPfpsUzDl9sQtz8QiQkHRAwRm/9kqLjOU9tTJp/XG9kwuay0VoPf7RXtk= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4919.namprd11.prod.outlook.com (2603:10b6:510:34::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Wed, 11 Aug 2021 11:30:56 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.016; Wed, 11 Aug 2021 11:30:56 +0000 To: CC: , , , "Sachin Saxena" , Vanshika Shukla References: <20210727092523.22718-1-rohit.raj@nxp.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <4f637a6c-6364-c8c7-9fd5-7d4dbda125c8@intel.com> Date: Wed, 11 Aug 2021 12:30:49 +0100 In-Reply-To: <20210727092523.22718-1-rohit.raj@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.5 via Frontend Transport; Wed, 11 Aug 2021 11:30:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1d8a8e6c-7bf1-4ae0-3aaf-08d95cbb7c51 X-MS-TrafficTypeDiagnostic: PH0PR11MB4919: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2958; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vh8/tAsfAA/E5147JA29Dx4+FXkbtYsx/W+uVm/J+EfXCwnngchdQphGooAC43nI/A7B/TS2XB3KMXg7W7YHKEE8eeCLPgbJ1r5eKB43N19ZWYNXtriKVMsYc7l5D+qkApSiKD6i1oOZl+OUwcXhBT5dL56AvG7wiQw3F3BaPD1iuSyG3GlzClHex+0S9Mxx0RWzOrHDNcIY6Ou928SpgkZz14geyyFaf+247w5fNcCfGZNE+evAHBmprH0ntA7UWO7vV/TYEJr6cPjvA4v4U3qp/BjQrphC61Ohz37FUc+K2vBOwem6YcmMj08aCgKDB+01k/wtZbuSBxAWA1pOqr1irNu+Rt8ZzLfDhCjJOrMiP7xuUbBF9f/WdYsWNHxgb7uNypWatAbQhcNvhhq0jOJwSc64aNQVbzEMhiONJ+GlnU3SEW/EFxfAnMWYjSbFKAMUkKrM6k0Eowx4QSjzOKmEOiEdyylQ55kNr/luxyj8w6lAyFqDHlyJBvaovd4pXH57ejnGnVL1KG+2sWka7+FkR0/VOabf7E0CRRfPJgK+SZr/08Bh8YSSKhHoQMMnnCfc8PxXmnryIwolj0GEuGNlF+onOWJUica0e7nyT1AFpc9rLB4LRokcM9CPVMOq51mzrdgGfpxRJQZF+8+v34bSjL6awmds6z7MJraN0aeknlUGXsljjtI9MBtaEx9Tz5GySwRR3MGFDthJOzl/BQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(54906003)(2906002)(6916009)(186003)(316002)(16576012)(26005)(6666004)(478600001)(86362001)(53546011)(6486002)(8676002)(36756003)(66946007)(66556008)(66476007)(8936002)(31696002)(4326008)(5660300002)(31686004)(44832011)(83380400001)(956004)(38100700002)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGM2M1Q1Q3BoNFRnWUh0V2REblJ0cjNVbmw2ZFVlNUlDOW5ld2dWcnlSOU1X?= =?utf-8?B?VHJNd1NGdGprc2FmbTcxRTBEWnQrS3VwMTFXNGl1ZWRZVkpTclg3bGd1SDkx?= =?utf-8?B?ckxYYVk5S21jdElidXhJeUs4SmpGRVJUSUhwZXdobmFqSDUwTmt3S2JMTEpr?= =?utf-8?B?L1Bub0QvYmtFRW45UVJ4T1Z4ZWF6aUdkMWhXZUI1dlFFQVdMUmJGczJJNVhx?= =?utf-8?B?WTZyWXZJRFBRNW9NNGl4TEFGZnlRZWpEeEN0czNpZmRyVG5xVnQrSnhqNlZn?= =?utf-8?B?WnlwcmRvZ2FvREF2OUs3cC82RWNocGd5WEIwWS93aHVRQVF1R2VMcUs0NGNB?= =?utf-8?B?RVVaMU5oUHZFTXBSQTNMZGljMWdNYVlNOUlZeXd4M3loVWN1aGxqaDdvTnBn?= =?utf-8?B?YjNCblRGSVlabDFkTE5IU3FCOHJpYjRrTTZiM0MvcXluU0FmaG1xTmlZL2Zz?= =?utf-8?B?TVVLSnl2L1oybFhOYkhvR1YweEZuUDBpeEZhQklQODZwa090QWR6Qi9PdXFG?= =?utf-8?B?OVVKSC8rNWpuRHY3VFpNL1BLbVJLRnFKaWdkb09JL0dMa0xuMXp0bjJSWkEy?= =?utf-8?B?S3l6TzJuRkpqNDNtL1RIVGJYTHJhQjAzbW5RdDgrWWloVUhpSGE4QW42QjBT?= =?utf-8?B?YWdsQmNXYUw0SmFXMnpia1VDYzVKQ3hDak5RaS9iR2FiRUQrYzZaUXFtZUhq?= =?utf-8?B?YVRjcjhVQjh5RFZVaHNEZ0QyRkdldmpkSjZ2OWVHcUF3MjZzUzNWU0lydGhO?= =?utf-8?B?ZU12NktlTGw2ZVA4djlHK2pMdzBCRys1ajA3dkRZVEFJRG9LWlFHemlObjE4?= =?utf-8?B?aGFWeFd5MDRENkpENTlpTlhWTkNEMlcwYzZSV1Z1eXJ4dmpxOG5sQ25ISUVj?= =?utf-8?B?elJEYWJVaFNhVDNhaFlpQ0hHdjFWTWpIbno0WlhKajBhKzZFLyttc2dGSnMz?= =?utf-8?B?S2IzMzhPRjBxVG1EdzA0TC9rdFhuNDJhMDdoa1pIb3BpVEZJMFNqSUR0Y2c2?= =?utf-8?B?SU9oenNaaE5wUkdjSFBIZXoxSWIwejdxc3hVK3VpVSs2RXNxVlp0UzY3Rmph?= =?utf-8?B?YWFldjJZajNhL3JQRS8vcFZ4eEtzQnpFdTE3dnVqaThPK1lhUm1YTllvRjlK?= =?utf-8?B?TDJnSytqcEJPd2NjOTJVd1lnUjR0UUtkNzllSEsxa1MwY2VpdnRvZ2JDbmZP?= =?utf-8?B?d3ZlMFlXNkw2YTVhNTVVcFlYSUw4UmxOODA2aGhBVmFySFFwTlQ5dDA3RFli?= =?utf-8?B?Y3RSWjRzQ2JKTVl0VFVVWnUrcUZJV2tKOFFJS1lzZDdDR09CN2pCcGZVSzBr?= =?utf-8?B?M3E5Kzk0VEJZN1cvaGtIN2pPeVZmU0R4dExEalZ1QXdOdFV4bCt3NUpLT3Zs?= =?utf-8?B?T1YvRkV4ZE93cC9PR3JSSmNaVXF2V3J6SDZKNXk4REJVU0ZsWEJJcVlDOW9x?= =?utf-8?B?NTl4U09RRlk5QlBlNTExQmI1ZDZmUllMVEtocFNXQXdYSlNKR1dDVk9LK1hB?= =?utf-8?B?eVJkVG1YV1Z4aC8vSEVjajZ6V0d6WWpHeHJtdHlnN2x6Nyt1SzVYMnBXdlFH?= =?utf-8?B?UjRqeVgvUEpNTnJYYmcxOWJOekc0VVpsSTZmMzZMbGhISFJIeEtVd29IdS9C?= =?utf-8?B?N3ZLZkxZdzZnc3Bkb2IrZjlsOHJDUHl1YXVqWTJob3V4UmpuWmtyYVVjTVd0?= =?utf-8?B?L2t1Rk8ydm1DUzR1N240cVhUZ0h5Y3FLN2x2UTZLdlJIK1ZxMXkvZVIvN2lh?= =?utf-8?Q?OSaso/kbfuSLgusTp3MOOiqbvVONaqOdbZzdy0o?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1d8a8e6c-7bf1-4ae0-3aaf-08d95cbb7c51 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2021 11:30:56.5143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bJuqqyyDKeiRRF+e8/O3eBAAetHy5ZqvUyJNPWOm97NRLeXWIf5IJfz+cCU4C39cPAXQyHVB3TbSfNjVm6ndpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4919 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/27/2021 10:25 AM, rohit.raj@nxp.com wrote: > From: Rohit Raj > > l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is > not able to store packets with size greater than 2KB, hence these > packets are dropped. > > This patch fixes this issue by enabling scatter for jumbo packet, if > it is supported by NIC. > > If scatter is not supported by NIC and max jumbo packet length is > greater than default mbuf data size, then application exits with > proper error message. > > Fixes: f68aad7904f ("examples/l3fwd: update") > > Signed-off-by: Rohit Raj > Signed-off-by: Sachin Saxena > Signed-off-by: Vanshika Shukla > --- > examples/l3fwd/main.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 4cb800aa15..6aaaa8ecb5 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -1035,6 +1035,20 @@ l3fwd_poll_resource_setup(void) > "Error during getting device (port %u) info: %s\n", > portid, strerror(-ret)); > > + /* Enable Receive side SCATTER, if supported by NIC, > + * when jumbo packet is enabled. > + */ > + if (local_port_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_JUMBO_FRAME){ > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_SCATTER; > + else if (local_port_conf.rxmode.max_rx_pkt_len > > + RTE_MBUF_DEFAULT_DATAROOM) > + rte_exit(EXIT_FAILURE, > + "Max packet length greater than default MBUF size\n"); This is a configuration set by application. So application is failing itself because of configuration it sets, seems odd. I guess the jumbo frame can be enabled when user provides '--enable-jumbo' argument. What do you think adding above check where that argument is parsed. Btw, no need to enable scattered Rx if the packets fits into buffer, so above check can be done slightly different: if (max_rx_pkt_len > buffer_size) if (OFFLOAD_SCATTER supported) enable OFFLOAD_SCATTER else fail > + } > + > if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > local_port_conf.txmode.offloads |= > DEV_TX_OFFLOAD_MBUF_FAST_FREE; >