From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64185A0C57; Mon, 1 Nov 2021 13:39:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8DE740E28; Mon, 1 Nov 2021 13:39:09 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C8C2A40DF6 for ; Mon, 1 Nov 2021 13:39:08 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="218193775" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="218193775" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 05:39:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="727349208" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 01 Nov 2021 05:39:07 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 05:39:07 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 05:39:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 05:39:06 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 05:39:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6OVvcrpyKvlm14mWdDWLpT/9LQmOQHuqs2FZc+byr1d2LMj08JwBoB03c9EQ8RQoYKziErVbK0pkpQ9jW+UXqZWLbCrpBdk4U+0WFX9v2hwJBSomlX8OlNZ+0kumJekwxajSAl7duwIwOC0VJnFzMQxvWGOcr2e43/Upa8BBFamxUqGNEnKhJSo+k7E2mmdy7MwYiEThLyqN9uk8XJNslwvcidUr0Pf6ONTzk27O4N1nFOXjLDiIcE7OyvKKsSm5HkY/6N5gWAjlemJPXFrP3LwXwvOVhjj5sHxIC6aBVT0u6Tbkjz50T9kBQxMV3SOcdorFQdf8t2mywKo5PMfQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vULENysXbDWtqN8pss8sybhEcrj3+G/XWhgmReTYCOY=; b=Np8tRESW+FS80VB7iMA4D4Byp4vsat1mWvSc/vW2YH3h0i+KMI8RUfI4ya7coylzzMGNysphGoHs5VXbpnfCSKWSE4XK2IHtkZ7akHJPAzMEnAo1qfQVjNM93hGwh+oqzapKh9ZFaQHEs0ArlkXA3BK6P73OXL/kV8C77ZwBcD0mLpXNEA5l05q3c1UIqaiJrISOPsFB7qiBv8bc5Or4q2nal2umZ4NKJY9TDy0JJhKOeHFyVnrfb1werhN2lgfNAQzeYKD75/MBG8wOeOI0h0Qtx4bRn8b1KYNCfNZ7MYPNLSA0kVggsQedxyXxASH6vW2rFmfG190+HKNH7nyHmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vULENysXbDWtqN8pss8sybhEcrj3+G/XWhgmReTYCOY=; b=Iy/yviUItT4ds3bRl+NDUwmj2pXJ2YrEfl0B4BxNK8qOjw76Y6ce438ws8CNqaoGELdETo5Unj7uv6ATqt389rxwft/5CtyeCT4pTFBPlVcFH8BeYVNrbMP9s+Srd7KQbddmuVcGT/Tsz/TNDJvWcVOJJZGsuiFL+bvJT8Xahm0= Authentication-Results: trustnetic.com; dkim=none (message not signed) header.d=none;trustnetic.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4807.namprd11.prod.outlook.com (2603:10b6:510:3a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Mon, 1 Nov 2021 12:39:06 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 12:39:06 +0000 Message-ID: <4f7f64fa-dc6f-8725-3fd0-f3d41d0bce03@intel.com> Date: Mon, 1 Nov 2021 12:39:00 +0000 Content-Language: en-US To: Jiawen Wu CC: References: <20211022020243.2932559-1-ferruh.yigit@intel.com> <20211022110314.470843-1-ferruh.yigit@intel.com> <011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0107.eurprd07.prod.outlook.com (2603:10a6:6:2c::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0107.eurprd07.prod.outlook.com (2603:10a6:6:2c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4 via Frontend Transport; Mon, 1 Nov 2021 12:39:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 360271ca-0585-4ac4-a28d-08d99d34976d X-MS-TrafficTypeDiagnostic: PH0PR11MB4807: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:612; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ZRpr+IUeLkj2lE+NVPdCXYGcK5OYzctuOz0VyaFK23Ho4KDYcgmgDBfe6gC6F/hO2MX9Mxn66Hj/vOcvPMvs7gPHxMdxuqULnZ264o97RDAbOku3DEIBFlyZiRNlh269jSpW4lvFGaqSRFOLy51jLUR5E5rJk06sxa9qjgGiQI1T/awrS0CenuwilgCMeTZmtyxzgaLytOOao7jrEIrLZYi1Jh6/HNUZEudLkq8rCu6UpbdMRtavyRPdtG5IOb33MrQze3dFjLf/2slXq7ZmlTtWFIatX28A2Bjv4QQ0vetwappyaReH5bCl9eV7cYOXGJ8l+9vlDNUSP5T58oQ43+mYaVx0v5bw8fEr35Q8fTmRcY771aiEi0SDh32U/MdlwdCl0H6EgF1K8ZAIJxsA9Ksz2IpWbEAlT9mgYzNV9bIFdvvCIbendWC5Cbb3lewziM/vKT+F1c8+GeX0uX/UAx/wr+/VccSDo4H6bqijEsq+bAspvomR4rXlATLpH55toiwUl+B6ML+fS8FQm3xhQLT6oZK10sOBljYOY5hznuSIEj1KCpGPC/qCE+mIJx/RHPPy/1qX4lWNs7UYXRIiSgt1Beq3disxuqT2SucXTAngLRPLk/0bYboNxu0AvH2OUrfUcBViYwP9LMuLeRZWsXrSO6B5RqnCQ2a7Nt3KAJTxMDOvpGyHDYfWI4xk+2TUO7H44qKUdBnpbcS7hUM7A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(956004)(8936002)(44832011)(5660300002)(86362001)(66476007)(16576012)(26005)(6916009)(31686004)(82960400001)(38100700002)(66556008)(83380400001)(8676002)(508600001)(2906002)(4744005)(36756003)(53546011)(4326008)(6666004)(66946007)(2616005)(6486002)(31696002)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFR1MkNXN3Z2UWljUWphaEhPaFVWZ3NQY2tlVUdRRUJGTGh2ckVjSmI5bm0r?= =?utf-8?B?TzNCa0VHcTk2Q2drd3RYeGx1aE5GQSszdTIrOG5Hci8rU0JIbHQ4cHZ3MzJ5?= =?utf-8?B?QS9OcWNkV0UrNDZwZGlYdVl3TFlHTzBic2ZJR0VpUGoyaWFrU1ZlQzg0YXo3?= =?utf-8?B?UmJ2N3Rkc3dhazVPekc3R2VNWU1vTEJvR29nNkpvNlJWTVRYdkRUbXdtMlJy?= =?utf-8?B?dDFyK1dtcVpabEdRTnNsYTVtN3FjTExrd3FtMTByYnB1V3BuOHZQSWlSVjk5?= =?utf-8?B?c3l0emdZRjJqdTh2N2JGY1l2ZmVycktzMHprUWh4MTNkSG8ycUNjRHRBdVQz?= =?utf-8?B?UmhCQ0lyQ2J3MjBTems0WkhqSkY1eVVhSzJWamd3N2RiR3BoNW9Ma2JnYVpC?= =?utf-8?B?MUM2VzVNTkJwdG9kTm4rYW52M0dZNEJxZUZhYjlNVWM3WVQ4MCs5eFpjd2h3?= =?utf-8?B?QlVqTFNGS3RxS2VkekltR3lWNG44VW1iTDhkbGFQSnFvRlhIaWxQNnh5S1J5?= =?utf-8?B?dUZscVFsNi9IWENycXhZeWd4L3ZlTldnVUIrenNJU0FHN3VmVTJvNUs0Q0lk?= =?utf-8?B?dVBWTTVpNmRhWHpoUU9zQlNHbmpFaHNsTGhSb3NVcS9pMVZqb1FCMTl3dlhz?= =?utf-8?B?Umd2ZHhXMVNqbjc1RDdYTkIybWNxK3JkZElzcTJKSEtSVVlkYWxSTno1N20x?= =?utf-8?B?eXRDMWRrYno3bDExMS94cmtrc0JKVTdoN3VXYlRMTmhjN2s3aC9QOHFCL3ZO?= =?utf-8?B?NXRhV2JTVTR3VWZPVFFPQXMwOWdaQ1A5NzhUaXhCRVpxaUNqQ3dHdm44Z1hM?= =?utf-8?B?ZzZXNVg2d0g3SHk5UG43WmJISlB6bFlCSVArc1YvUy8zOG92K25HR28rL3RM?= =?utf-8?B?MktnNU9lbVJmcm5qQ2E2N1ZNNzRmSVZhdEJ5eXhwTm5KWE1GVEFyS2dIampn?= =?utf-8?B?RUhadXp3SFdob1hmWlJISUhrcUw1K3JEa29pWTlXMmFwdmxTVkRLeHlvQ3Q4?= =?utf-8?B?aHFya2s3Y2pyS1kyT0FnRW8wWG1mS05LWXNuSjFDUkxyM1c3U1EwZ2xwbEJ1?= =?utf-8?B?ckdFVUtEQVhWbC9SRFk2VjZ4d0QzaWlhZTN1R0JwSWc0K05ab1ZYK1NrYjA3?= =?utf-8?B?MGtLT2Y3RHl1bXIreVBGRThEMThBTWJXMy9QWDVjamxjK250c2dndHFkUytB?= =?utf-8?B?ckJuTjhnSldoUGJWNHZNL1AzUWorVmNNYTlCZnQ2M1ViMGZKOStWYjczd21U?= =?utf-8?B?RnRnNEg4VzAxTkk1QnFwdUUrclNldGI5bGx2TWZXVVZDVjg4a3lTdXh3bW5V?= =?utf-8?B?bVMwdUhISU5wajBPNFFJMnJWdTZDRFJRbWs1UlVtMERhWWg2Q3laUnhwaldL?= =?utf-8?B?ejVMODlZZ2RicVl6NW9kRldUR1R5Nk9PR0VKKzZXOCtJc0VqZVBxOHdIbEhv?= =?utf-8?B?OTc0RGpJNTNicTFTYmk5ZEZ6UzR5ZG1yNTlkbVRVRmJMWEZXSUNhK0NTbmpQ?= =?utf-8?B?am1LQzdQT1pGQWc2U1UrNWMrOUdtY0dYUExYRHdVNTl1ZXhwSVJSaFV4bmFV?= =?utf-8?B?aTVOeWc0Ry91RFB1M3ltMHI2MnB5cnFkWnpEZU8rdlFPVVMxTXoyNDY2TnFH?= =?utf-8?B?QUNFeUdxbHJCVmxhOXlrTEI4R0Z6bHhqRUUyUWVwVndKYlhqVDA3aGppbHM3?= =?utf-8?B?Rk9mNXBrd2txYWh3UjZ5QWlqTUlRWElGVVUzUlN4QWtVUlpTaWlVcUxqU0h2?= =?utf-8?B?cGVPUU95Z2ZZc1hLQW9NN0dGT1NDamtSdzhsSFhOZHdlbHZFTHpldG4rTjNx?= =?utf-8?B?VndOWjZacHk2aWpKbmZRelRtRGppK3Y0NE1FcDQwQzZxb3lyUjV5Q2k3c1RZ?= =?utf-8?B?THBjTXdOUFhlREtXazVXRHBoWFQ1c1pRSlpoZXQ4bUliTjdmenROcXRrTEdu?= =?utf-8?B?cGM2cnJFc0E5S2pCaWFJdldBNk5hZlhzV0V1b3JlRXdVOVA5M0VHd0lJcHdk?= =?utf-8?B?dkFmYUNJbDJCaGZMQm9yeG1CQWRWcnpiQXNRQ01jR2VWZGRRenFoUWFvS3VG?= =?utf-8?B?a2ZSeFMzeWwrSWwrYTJhWkZtdXZDR29BczF0Tmtjb0dMaVFaL25OYjRDcmlh?= =?utf-8?B?R0FTc0U5SHMzajJXNUxmbi9IWjhuWGNna3VTSm9lc1QyQVRJR1o2bFJoOXZU?= =?utf-8?Q?U84/kuhgcq+jSQilgGQlde0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 360271ca-0585-4ac4-a28d-08d99d34976d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 12:39:05.9586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RhzdxThqGw4KHCZnpVmmTrCFEujJSxcIQKvEKf+QxNDXd0C7cYTQ0A3AKhUA6rufIfXscPm3Doem5ss2TFKgAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4807 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/1/2021 9:23 AM, Jiawen Wu wrote: > On October 22, 2021 7:03 PM, Ferruh Yigit wrote: >> >> diff --git a/drivers/net/txgbe/txgbe_ethdev.c >> b/drivers/net/txgbe/txgbe_ethdev.c >> index 7b46ffb68635..0b0f9db7cb2a 100644 >> --- a/drivers/net/txgbe/txgbe_ethdev.c >> +++ b/drivers/net/txgbe/txgbe_ethdev.c >> @@ -2695,11 +2695,11 @@ txgbe_dev_link_update_share(struct rte_eth_dev >> *dev, >> int wait = 1; >> >> memset(&link, 0, sizeof(link)); >> - link.link_status = ETH_LINK_DOWN; >> - link.link_speed = ETH_SPEED_NUM_NONE; >> - link.link_duplex = ETH_LINK_HALF_DUPLEX; >> + link.link_status = RTE_ETH_LINK_DOWN; >> + link.link_speed = RTE_ETH_SPEED_NUM_NONE; >> + link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX; >> link.link_autoneg = !(dev->data->dev_conf.link_speeds & >> - ETH_LINK_SPEED_FIXED); >> + RTE_ETH_LINK_AUTONEG); >> > > Hi Ferruh, > Is there some wrong that 'ETH_LINK_SPEED_FIXED' is changed to > auto-negotiation? > Not sure how it happened, but I will send a patch to fix it.