From: "Doherty, Declan" <declan.doherty@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test: register test as failed if setup failed
Date: Wed, 10 Jan 2018 14:24:19 +0000 [thread overview]
Message-ID: <4facb05e-9cfa-3bf3-c05a-0323758bdb80@intel.com> (raw)
In-Reply-To: <432ebfd1f25d903f60b276790a3029c5480e3306.1513867661.git.anatoly.burakov@intel.com>
On 22/12/2017 10:21 AM, Anatoly Burakov wrote:
> If test set up couldn't be completed, the test was previously
> shown as succeeding, even though setup failed. Fix this to report
> test as failed, and count all tests that should've been executed,
> as failed as well.
>
> Fixes: ffac67b1f71b ("app/test: new assert macros and test suite runner")
> Cc: declan.doherty@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> test/test/test.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/test/test/test.c b/test/test/test.c
> index 0e6ff7c..fe41d40 100644
> --- a/test/test/test.c
> +++ b/test/test/test.c
> @@ -162,8 +162,20 @@ unit_test_suite_runner(struct unit_test_suite *suite)
> }
>
> if (suite->setup)
> - if (suite->setup() != 0)
> + if (suite->setup() != 0) {
> + /*
> + * setup failed, so count all enabled tests and mark
> + * them as failed
> + */
> + while (suite->unit_test_cases[total].testcase) {
> + if (!suite->unit_test_cases[total].enabled)
> + skipped++;
> + else
> + failed++;
> + total++;
> + }
> goto suite_summary;
> + }
>
> printf(" + ------------------------------------------------------- +\n");
>
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2018-01-10 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 10:21 Anatoly Burakov
2018-01-10 14:24 ` Doherty, Declan [this message]
2018-01-17 23:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4facb05e-9cfa-3bf3-c05a-0323758bdb80@intel.com \
--to=declan.doherty@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).