From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61E22A0503; Wed, 18 May 2022 14:54:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B19D40156; Wed, 18 May 2022 14:54:18 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by mails.dpdk.org (Postfix) with ESMTP id 37033400D6 for ; Wed, 18 May 2022 14:54:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kAPv9v9w5NMo7gKgyF62sfYpvw1FlclGz3fK2vEx0xkUZbtySWW5JENm+6v86FrhM8sKxxX7nVNJJZUnzKwOo+opNLGIhgL/RCPiZSdINty1uyjwFjx81fBmSz8GY6dWZCSDfU0CDpJ2IHSY8TFjuPg4q6SJYB+Bwswszgz5RS5FOqs/c+51DgZL/dDEKH7z3NFxdNjyque+sRNikHQLSsb0l7hWyUENW9Yuw0lDCifqtDTzWfzvlFz6zopnCbo89kTtHpTE2JH+ETLvnBBNlpiX7a66W+XZzOBNynwdabwq4L0cAT/3QbBzt56yN0LinguYxR2TFjVzg7A/2Mo7lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UBSQIB56vZO0g3+BCdeIHdYXjnVs9yHgVGG7jmgLqHk=; b=fpuJGB6iC6qh1b/oAdn80qlDQJFOSSjafeGDh7cWN3WflsJhhCwMtsIAp33ql5LGIpt+e9RIfN0j0CS8K+kqxU7VmHJmjVIBXKdEYCtt0RGxBUK1AOefccRw78vJSLlUzX8/Ju/TlAlGmxKhYG7PAlIomlMXRr3I9LPmGp8i2BGYYY2kPBl6sklsfZvljA/ju552M/oWbqN9eVr/tz9XRy5D9z4YpU7CCXonKrVXzOHE/C7W0yrauA/plVAIE9+Mayydk6CDdRCGK2XlMcYObn+CsQbsjC7dYuSBjOQg+uBneXC0FWJoHUMbX4cbXxQxfcCiGSRi7p29U7JX2CDUOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=atomicrules.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UBSQIB56vZO0g3+BCdeIHdYXjnVs9yHgVGG7jmgLqHk=; b=J0IvH6oB7gc3bSUaaDcBo9YsRmz0pJCVTGG/ug8+j9U2Jb5C4kII8Xib4XBeOMRwBW4w49H4WXRF8NuyZFrZHGYvoS7ih7VWXBFFegApThAYAVE52TCPh3vcPxmCBbKSpGIMJES7zmp3ZHLmZ9tWpfMBuQvY0XlYnTPh+xzFSag= Received: from BN1PR14CA0019.namprd14.prod.outlook.com (2603:10b6:408:e3::24) by DM5PR02MB2460.namprd02.prod.outlook.com (2603:10b6:3:3e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Wed, 18 May 2022 12:54:15 +0000 Received: from BN1NAM02FT017.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e3:cafe::4) by BN1PR14CA0019.outlook.office365.com (2603:10b6:408:e3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Wed, 18 May 2022 12:54:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT017.mail.protection.outlook.com (10.13.2.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 12:54:15 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 18 May 2022 13:54:14 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 18 May 2022 13:54:14 +0100 Envelope-to: ed.czeck@atomicrules.com, dev@dpdk.org, shepard.siegel@atomicrules.com, john.miller@atomicrules.com, bluca@debian.org, ktraynor@redhat.com Received: from [172.21.34.28] (port=30299) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nrJBt-00022X-OC; Wed, 18 May 2022 13:54:14 +0100 Message-ID: <4fbed18d-794a-dc11-ae98-20ab4f345e44@xilinx.com> Date: Wed, 18 May 2022 13:54:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1 1/5] net/ark: update mpu code to match current hardware version Content-Language: en-US To: Ed Czeck , CC: Shepard Siegel , John Miller , Luca Boccassi , Kevin Traynor References: <20220502212232.1283-1-ed.czeck@atomicrules.com> <20220506212732.28504-1-ed.czeck@atomicrules.com> From: Ferruh Yigit In-Reply-To: <20220506212732.28504-1-ed.czeck@atomicrules.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1c700ed-b51b-440a-fa63-08da38cd8384 X-MS-TrafficTypeDiagnostic: DM5PR02MB2460:EE_ X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 19tVUp2Dnl6hPculOK3gGV782aOi0BxRu0pImCVyOiPd/CUtg+DWqXZcNtH19zg3pmNEDz6MgX7CShSi84Pz8eHY1csMHTED/3EpDVrd6GJCFqAFpiysZ2AhFtiqgeeyzYO+AxfClYQ7SJlwEUZjC/NZkM2UUBBeOTUKVZ788G0COTe1no4X+DMazBgCf0AjUZU7oB5mciCiG+BHuTWyLTgGOrH/oxQygzD3gX0GEm0fhKmfnzjIofYUiEquMiIfVL5Eh6JKxA8bWjZeFm+5SXr8HZdycr5dxWathENmraYJrtOnyfd8+WFzCytjKS3n1DQyh+vS+hP33q3mFF2GqJlzhxCRv0LX5WzrK5oRcAWtZEIpjfe0Jy0bxY+4HJ/IJB+qaJ+a5VgmF8if9icIwTtyCwoCZfFl3Ssynybuun8wJBCyST1p5zOV+QZVlKNT3td7ywUd8TBz5yx/+ZNapUSc2DK2QBwVy+eSxtui3qIRP/f3vSV4sVp8skFdk8q9hUbGuSpVqo10tnCu5yKjh2N3tt+HZMHFJV7Y0AsGDIVIIaIo2kXdyHqWm9m0Iy+PwcZvAh5FuAsf5Lo/yROlbwKlIgkoUKs8wmDjCiFYIOBxnaMFNEeX7ZOAWZACP048ypnhwccirTwiGzMBW8740njBQhv2pzBuTRynhQqxOpwTkMpBn+5sAeIT5MGxDODdw1RrAB4ndL9IZWdkh02lvgUUyThYehpADh3SU6I3N+k= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(70586007)(70206006)(8676002)(4326008)(508600001)(31696002)(9786002)(7636003)(40460700003)(26005)(8936002)(5660300002)(83380400001)(36860700001)(2616005)(44832011)(54906003)(2906002)(47076005)(426003)(31686004)(186003)(15650500001)(336012)(36756003)(110136005)(316002)(356005)(53546011)(82310400005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 12:54:15.0609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1c700ed-b51b-440a-fa63-08da38cd8384 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT017.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2460 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/6/2022 10:27 PM, Ed Czeck wrote: > new version code > remove device-level global operations > remove ark_mpu_reset_stats function > Hi Ed, please find a few comments inline. Also I assume 'mpu' is an abbreviation, can you please document what it stands for in the commit log, like MPU (M.. P.. U..)? And can you please make it uppercase in the commit title, also if you can add them to 'devtools/words-case.txt' (in a separate patch), it will be checked next time by './devtools/check-git-log.sh' script. Same for all patches. > Signed-off-by: Ed Czeck > --- > drivers/net/ark/ark_ethdev.c | 2 -- > drivers/net/ark/ark_ethdev_rx.c | 4 ---- > drivers/net/ark/ark_mpu.c | 21 ++++----------------- > drivers/net/ark/ark_mpu.h | 29 ++--------------------------- > 4 files changed, 6 insertions(+), 50 deletions(-) > <...> > @@ -24,10 +24,10 @@ ark_mpu_verify(struct ark_mpu_t *mpu, uint32_t obj_size) > { > uint32_t version; > > - version = mpu->id.vernum & 0x0000fF00; > - if ((mpu->id.idnum != 0x2055504d) || > - (mpu->hw.obj_size != obj_size) || > - (version != 0x00003100)) { > + version = mpu->id.vernum; > + if (mpu->id.idnum != ARK_MPU_MODID || > + version != ARK_MPU_MODVER || > + mpu->hw.obj_size != obj_size) { The driver will work with a specific version of the 'MPU'. So a device previously working with previous version of the driver, won't work anymore after this patch, and will be forced to a (FW/bitstream/?) update. I am not sure how problematic is this from the stable release perspective. cc'ed maintainers. But at least won't it be good to document this in release notes, and perhaps having a table in the driver documentation to list which DPDK version requires which HW version can be good, what do you think?